From patchwork Sun Jul 21 12:53:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Yanjun X-Patchwork-Id: 1134534 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="Zioe3wH9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45s4Gv4y5Gz9sNF for ; Sun, 21 Jul 2019 22:45:59 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726430AbfGUMpu (ORCPT ); Sun, 21 Jul 2019 08:45:50 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:53954 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726188AbfGUMpt (ORCPT ); Sun, 21 Jul 2019 08:45:49 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6LCigru045062; Sun, 21 Jul 2019 12:45:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=3KM55SQ5FMVvfyB3yo4FO5S35Jci7niUEHnxJduM8Gs=; b=Zioe3wH9VpNgQLHJZTRVCWWW1MPdDvbxti1a2aUbyuIRtgBv2Mm3t9MuSf0CSiGonq3q Btk9vUzzRoYn2+z9FZxSn0LtNXpJxFGKMS0tELf9ZAbjavH+VCMhFgVF9/8P8XJJsqkz evlN/T1cjaqTU7cEQ6024wHxJnlZzKwnvIrEWl5D9UcASDAmy/6rGjnJYJ7bLYOEJm+5 rPkeaJKYUB4eM1CW+dpyJXFE6jdCBNNg4LpdOeyDTqrpQAIZ7D7qXf4LrUKY/IUp6ON1 CH+nP+b8AcFRaqNvxFANw7gZlVPibgszUaXuQOwi/Qzn/9pynzrHdeByrd9xxfyFdqvp AA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2tutwp2qds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 21 Jul 2019 12:45:42 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6LChcGT039137; Sun, 21 Jul 2019 12:45:42 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2tus0b4w13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 21 Jul 2019 12:45:42 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x6LCjfPt002446; Sun, 21 Jul 2019 12:45:41 GMT Received: from shipfan.cn.oracle.com (/10.113.210.105) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 21 Jul 2019 12:45:41 +0000 From: Zhu Yanjun To: yanjun.zhu@oracle.com, davem@davemloft.net, netdev@vger.kernel.org Subject: [PATCHv2 2/2] forcedeth: disable recv cache by default Date: Sun, 21 Jul 2019 08:53:53 -0400 Message-Id: <1563713633-25528-3-git-send-email-yanjun.zhu@oracle.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1563713633-25528-1-git-send-email-yanjun.zhu@oracle.com> References: <1563713633-25528-1-git-send-email-yanjun.zhu@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9324 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907210153 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9324 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907210153 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The recv cache is to allocate 125MiB memory to reserve for NIC. In the past time, this recv cache works very well. When the memory is not enough, this recv cache reserves memory for NIC. And the communications through this NIC is not affected by the memory shortage. And the performance of NIC is better because of this recv cache. But this recv cache reserves 125MiB memory for one NIC port. Normally there are 2 NIC ports in one card. So in a host, there are about 250 MiB memory reserved for NIC ports. To a host on which communications are not mandatory, it is not necessary to reserve memory. So this recv cache is disabled by default. CC: Joe Jin CC: Junxiao Bi Tested-by: Nan san Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/nvidia/Kconfig | 11 ++++++++ drivers/net/ethernet/nvidia/Makefile | 1 + drivers/net/ethernet/nvidia/forcedeth.c | 46 ++++++++++++++++++++++++++------- 3 files changed, 48 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/nvidia/Kconfig b/drivers/net/ethernet/nvidia/Kconfig index faacbd1..9a9f42a 100644 --- a/drivers/net/ethernet/nvidia/Kconfig +++ b/drivers/net/ethernet/nvidia/Kconfig @@ -26,4 +26,15 @@ config FORCEDETH To compile this driver as a module, choose M here. The module will be called forcedeth. +config FORCEDETH_RECV_CACHE + bool "nForce Ethernet recv cache support" + depends on FORCEDETH + default n + ---help--- + The recv cache can make nic work steadily when the system memory is + not enough. And it can also enhance nic performance. But to a host + on which the communications are not mandatory, it is not necessary + to reserve 125MiB memory for NIC. + So recv cache is disabled by default. + endif # NET_VENDOR_NVIDIA diff --git a/drivers/net/ethernet/nvidia/Makefile b/drivers/net/ethernet/nvidia/Makefile index 8935699..40c055e 100644 --- a/drivers/net/ethernet/nvidia/Makefile +++ b/drivers/net/ethernet/nvidia/Makefile @@ -4,3 +4,4 @@ # obj-$(CONFIG_FORCEDETH) += forcedeth.o +ccflags-$(CONFIG_FORCEDETH_RECV_CACHE) := -DFORCEDETH_RECV_CACHE diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index f8e766f..deda276 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -674,10 +674,12 @@ struct nv_ethtool_stats { u64 tx_broadcast; }; +#ifdef FORCEDETH_RECV_CACHE /* 1000Mb is 125M bytes, 125 * 1024 * 1024 bytes * The length of recv cache is 125M / skb_length */ #define RECV_CACHE_LIST_LENGTH (125 * 1024 * 1024 / np->rx_buf_sz) +#endif #define NV_DEV_STATISTICS_V3_COUNT (sizeof(struct nv_ethtool_stats)/sizeof(u64)) #define NV_DEV_STATISTICS_V2_COUNT (NV_DEV_STATISTICS_V3_COUNT - 3) @@ -850,10 +852,12 @@ struct fe_priv { char name_tx[IFNAMSIZ + 3]; /* -tx */ char name_other[IFNAMSIZ + 6]; /* -other */ +#ifdef FORCEDETH_RECV_CACHE /* This is to schedule work */ struct delayed_work recv_cache_work; /* This list is to store skb queue for recv */ struct sk_buff_head recv_list; +#endif }; /* @@ -1814,8 +1818,12 @@ static int nv_alloc_rx(struct net_device *dev) less_rx = np->last_rx.orig; while (np->put_rx.orig != less_rx) { +#ifdef FORCEDETH_RECV_CACHE struct sk_buff *skb = skb_dequeue(&np->recv_list); - +#else + struct sk_buff *skb = netdev_alloc_skb(np->dev, + np->rx_buf_sz + NV_RX_ALLOC_PAD); +#endif if (likely(skb)) { np->put_rx_ctx->skb = skb; np->put_rx_ctx->dma = dma_map_single(&np->pci_dev->dev, @@ -1840,15 +1848,15 @@ static int nv_alloc_rx(struct net_device *dev) u64_stats_update_begin(&np->swstats_rx_syncp); np->stat_rx_dropped++; u64_stats_update_end(&np->swstats_rx_syncp); - +#ifdef FORCEDETH_RECV_CACHE schedule_delayed_work(&np->recv_cache_work, 0); - +#endif return 1; } } - +#ifdef FORCEDETH_RECV_CACHE schedule_delayed_work(&np->recv_cache_work, 0); - +#endif return 0; } @@ -1862,7 +1870,12 @@ static int nv_alloc_rx_optimized(struct net_device *dev) less_rx = np->last_rx.ex; while (np->put_rx.ex != less_rx) { +#ifdef FORCEDETH_RECV_CACHE struct sk_buff *skb = skb_dequeue(&np->recv_list); +#else + struct sk_buff *skb = netdev_alloc_skb(np->dev, + np->rx_buf_sz + NV_RX_ALLOC_PAD); +#endif if (likely(skb)) { np->put_rx_ctx->skb = skb; @@ -1889,15 +1902,15 @@ static int nv_alloc_rx_optimized(struct net_device *dev) u64_stats_update_begin(&np->swstats_rx_syncp); np->stat_rx_dropped++; u64_stats_update_end(&np->swstats_rx_syncp); - +#ifdef FORCEDETH_RECV_CACHE schedule_delayed_work(&np->recv_cache_work, 0); - +#endif return 1; } } - +#ifdef FORCEDETH_RECV_CACHE schedule_delayed_work(&np->recv_cache_work, 0); - +#endif return 0; } @@ -1981,6 +1994,7 @@ static void nv_init_tx(struct net_device *dev) } } +#ifdef FORCEDETH_RECV_CACHE static void nv_init_recv_cache(struct net_device *dev) { struct fe_priv *np = netdev_priv(dev); @@ -2017,6 +2031,7 @@ static void nv_destroy_recv_cache(struct net_device *dev) skb_queue_purge(&np->recv_list); WARN_ON(skb_queue_len(&np->recv_list)); } +#endif static int nv_init_ring(struct net_device *dev) { @@ -3108,8 +3123,10 @@ static int nv_change_mtu(struct net_device *dev, int new_mtu) nv_drain_rxtx(dev); /* reinit driver view of the rx queue */ set_bufsize(dev); +#ifdef FORCEDETH_RECV_CACHE nv_destroy_recv_cache(dev); nv_init_recv_cache(dev); +#endif if (nv_init_ring(dev)) { if (!np->in_shutdown) mod_timer(&np->oom_kick, jiffies + OOM_REFILL); @@ -4137,6 +4154,7 @@ static void nv_free_irq(struct net_device *dev) } } +#ifdef FORCEDETH_RECV_CACHE static void nv_recv_cache_worker(struct work_struct *work) { struct fe_priv *np = container_of(work, struct fe_priv, @@ -4162,6 +4180,7 @@ static void nv_recv_cache_worker(struct work_struct *work) skb_queue_tail(&np->recv_list, skb); } } +#endif static void nv_do_nic_poll(struct timer_list *t) { @@ -4218,8 +4237,10 @@ static void nv_do_nic_poll(struct timer_list *t) nv_drain_rxtx(dev); /* reinit driver view of the rx queue */ set_bufsize(dev); +#ifdef FORCEDETH_RECV_CACHE nv_destroy_recv_cache(dev); nv_init_recv_cache(dev); +#endif if (nv_init_ring(dev)) { if (!np->in_shutdown) mod_timer(&np->oom_kick, jiffies + OOM_REFILL); @@ -4772,8 +4793,10 @@ static int nv_set_ringparam(struct net_device *dev, struct ethtool_ringparam* ri if (netif_running(dev)) { /* reinit driver view of the queues */ set_bufsize(dev); +#ifdef FORCEDETH_RECV_CACHE nv_destroy_recv_cache(dev); nv_init_recv_cache(dev); +#endif if (nv_init_ring(dev)) { if (!np->in_shutdown) mod_timer(&np->oom_kick, jiffies + OOM_REFILL); @@ -5495,9 +5518,11 @@ static int nv_open(struct net_device *dev) /* initialize descriptor rings */ set_bufsize(dev); +#ifdef FORCEDETH_RECV_CACHE nv_init_recv_cache(dev); INIT_DELAYED_WORK(&np->recv_cache_work, nv_recv_cache_worker); +#endif oom = nv_init_ring(dev); writel(0, base + NvRegLinkSpeed); @@ -5679,9 +5704,10 @@ static int nv_close(struct net_device *dev) nv_txrx_gate(dev, true); } +#ifdef FORCEDETH_RECV_CACHE /* free all SKBs in recv cache */ nv_destroy_recv_cache(dev); - +#endif /* FIXME: power down nic */ return 0;