| Message ID | 1556880164-10689-14-git-send-email-jiong.wang@netronome.com |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | bpf: eliminate zero extensions for sub-register writes | expand |
On Fri, May 03, 2019 at 11:42:40AM +0100, Jiong Wang wrote: > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > Signed-off-by: Jiong Wang <jiong.wang@netronome.com> > --- > arch/s390/net/bpf_jit_comp.c | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) When sending patches which affect s390, could you please add Martin and me on cc to _all_ patches? We now received only the cover-letter plus one patch. It's always hard in such cirumstances to figure out if the code is doing the right thing. Usually I end up looking up the missing patches within other mailing lists, however I haven't subscribed the bpf and netdev mailing lists. The extra e-mail volume because of being added to CC really doesn't matter at all.
On 5/3/19 9:41 AM, Heiko Carstens wrote: > On Fri, May 03, 2019 at 11:42:40AM +0100, Jiong Wang wrote: >> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> >> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> >> Signed-off-by: Jiong Wang <jiong.wang@netronome.com> >> --- >> arch/s390/net/bpf_jit_comp.c | 20 +++++++++++++++++--- >> 1 file changed, 17 insertions(+), 3 deletions(-) > > When sending patches which affect s390, could you please add Martin > and me on cc to _all_ patches? We now received only the cover-letter > plus one patch. It's always hard in such cirumstances to figure out if > the code is doing the right thing. > > One possible way is to use --signed-off-by-cc option in git send-email --[no-]signed-off-by-cc If this is set, add emails found in Signed-off-by: or Cc: lines to the cc list. Default is the value of sendemail.signedoffbycc configuration value; if that is unspecified, default to --signed-off-by-cc.
Heiko Carstens writes: > On Fri, May 03, 2019 at 11:42:40AM +0100, Jiong Wang wrote: >> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> >> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> >> Signed-off-by: Jiong Wang <jiong.wang@netronome.com> >> --- >> arch/s390/net/bpf_jit_comp.c | 20 +++++++++++++++++--- >> 1 file changed, 17 insertions(+), 3 deletions(-) > > When sending patches which affect s390, could you please add Martin > and me on cc to _all_ patches? We now received only the cover-letter > plus one patch. It's always hard in such cirumstances to figure out if > the code is doing the right thing. OK, will do it next time. Will just CC back-end maintainers on all patches including patches for the other back-ends to make the information complete. Regards, Jiong > Usually I end up looking up the missing patches within other mailing > lists, however I haven't subscribed the bpf and netdev mailing lists. > > The extra e-mail volume because of being added to CC really doesn't > matter at all.
diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c index 51dd026..8315b2e 100644 --- a/arch/s390/net/bpf_jit_comp.c +++ b/arch/s390/net/bpf_jit_comp.c @@ -299,9 +299,11 @@ static inline void reg_set_seen(struct bpf_jit *jit, u32 b1) #define EMIT_ZERO(b1) \ ({ \ - /* llgfr %dst,%dst (zero extend to 64 bit) */ \ - EMIT4(0xb9160000, b1, b1); \ - REG_SET_SEEN(b1); \ + if (!fp->aux->verifier_zext) { \ + /* llgfr %dst,%dst (zero extend to 64 bit) */ \ + EMIT4(0xb9160000, b1, b1); \ + REG_SET_SEEN(b1); \ + } \ }) /* @@ -515,6 +517,13 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp, int i jit->seen |= SEEN_REG_AX; switch (insn->code) { /* + * BPF_ZEXT + */ + case BPF_ALU | BPF_ZEXT: /* dst = (u32) dst */ + /* llgfr %dst,%dst */ + EMIT4(0xb9160000, dst_reg, dst_reg); + break; + /* * BPF_MOV */ case BPF_ALU | BPF_MOV | BPF_X: /* dst = (u32) src */ @@ -1282,6 +1291,11 @@ static int bpf_jit_prog(struct bpf_jit *jit, struct bpf_prog *fp) return 0; } +bool bpf_jit_hardware_zext(void) +{ + return false; +} + /* * Compile eBPF program "fp" */
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Jiong Wang <jiong.wang@netronome.com> --- arch/s390/net/bpf_jit_comp.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)