From patchwork Tue Apr 16 17:13:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ioana Radulescu X-Patchwork-Id: 1086434 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="c2P5Zt1c"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44kBm238TYz9s55 for ; Wed, 17 Apr 2019 03:13:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729936AbfDPRNf (ORCPT ); Tue, 16 Apr 2019 13:13:35 -0400 Received: from mail-eopbgr30082.outbound.protection.outlook.com ([40.107.3.82]:60930 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727618AbfDPRNc (ORCPT ); Tue, 16 Apr 2019 13:13:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qOSoHao5Q6MB+23tMvFeF3bCdqhjvoWZxFGT5wh9ZC4=; b=c2P5Zt1cYZYc35OFshfYhQDJyRNpEueUUgw9TyYB4ghi6zKaOf5ct541bm1ysbybc+xbGO8oMXvOuDea8HxiPjM+8O7KmVqym1XAt7VqUI5Pxx2z0N2oW7VwYwWJKb5Ukzpi9ZC3M3Gj3Q68kfbgSK5qpLRWkb14+NS86UctLFw= Received: from AM0PR04MB4994.eurprd04.prod.outlook.com (20.177.40.15) by AM0PR04MB6081.eurprd04.prod.outlook.com (20.179.35.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Tue, 16 Apr 2019 17:13:28 +0000 Received: from AM0PR04MB4994.eurprd04.prod.outlook.com ([fe80::80e9:c360:27b3:30b7]) by AM0PR04MB4994.eurprd04.prod.outlook.com ([fe80::80e9:c360:27b3:30b7%3]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 17:13:28 +0000 From: Ioana Ciocoi Radulescu To: "netdev@vger.kernel.org" , "davem@davemloft.net" CC: Ioana Ciornei Subject: [PATCH net-next 1/4] dpaa2-eth: Fix Rx classification status Thread-Topic: [PATCH net-next 1/4] dpaa2-eth: Fix Rx classification status Thread-Index: AQHU9He1KvthqrpfCUiWznnyWFuGTQ== Date: Tue, 16 Apr 2019 17:13:28 +0000 Message-ID: <1555434800-17462-2-git-send-email-ruxandra.radulescu@nxp.com> References: <1555434800-17462-1-git-send-email-ruxandra.radulescu@nxp.com> In-Reply-To: <1555434800-17462-1-git-send-email-ruxandra.radulescu@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR07CA0181.eurprd07.prod.outlook.com (2603:10a6:802:3e::29) To AM0PR04MB4994.eurprd04.prod.outlook.com (2603:10a6:208:c7::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=ruxandra.radulescu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [212.146.100.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e55d631-e9bc-4fbc-3ada-08d6c28ed7ce x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR04MB6081; x-ms-traffictypediagnostic: AM0PR04MB6081: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(346002)(136003)(366004)(199004)(189003)(2501003)(52116002)(6486002)(186003)(26005)(5660300002)(66066001)(86362001)(53936002)(11346002)(6506007)(102836004)(386003)(6512007)(99286004)(68736007)(6116002)(76176011)(2616005)(3846002)(106356001)(446003)(105586002)(476003)(8936002)(8676002)(81166006)(71200400001)(71190400001)(486006)(256004)(14454004)(14444005)(25786009)(478600001)(2906002)(6436002)(7736002)(97736004)(316002)(305945005)(50226002)(81156014)(110136005)(36756003)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB6081; H:AM0PR04MB4994.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dsOETqJfUM3Ronf6+nhYxFpNa+ULSOpp1xaGh9H4pt2bfP6vlG2iT1a/lxk8SS3IYSo2PQejAl0ez/pwDZT+OOAlBQwrdLNYoqpTwfvmE7so1YS4ULuto3C8mZ4VcWkW/8Mqpacs/Evhg19JNTI6a++aMcK5t/WfaLd4LJG32Kv+OR74yw+LbdMN1PUNm36kOAMy7jXHvw0/mrjHK5hXnz5BzVGMt3CsvgufdoelX9wYnNP1cGMv2Q5wL7gaxPheOaVBm5WPCgTSNVztb6Mc0M2X0lvUf3K+NdOLBpEVvuClVZAxyuDtMI0PbQuGCjNMdfVOvnNjHa/gm0/ZDKZO9JvaPrlmnVyFX+NJyMsSO8Leu3IN2XSr3XujFjNJc8Jus4UGa7uNCy2FaaBQvnOLDGZuQIQuXPCApIQnkYCBl4Q= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e55d631-e9bc-4fbc-3ada-08d6c28ed7ce X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 17:13:28.4027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6081 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Set the Rx flow classification enable flag only if key config operation is successful. Fixes 3f9b5c9 ("dpaa2-eth: Configure Rx flow classification key") Signed-off-by: Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index 2055c97..1cbef6c 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -2802,6 +2802,7 @@ int dpaa2_eth_set_hash(struct net_device *net_dev, u64 flags) static int dpaa2_eth_set_cls(struct dpaa2_eth_priv *priv) { struct device *dev = priv->net_dev->dev.parent; + int err; /* Check if we actually support Rx flow classification */ if (dpaa2_eth_has_legacy_dist(priv)) { @@ -2820,9 +2821,13 @@ static int dpaa2_eth_set_cls(struct dpaa2_eth_priv *priv) return -EOPNOTSUPP; } + err = dpaa2_eth_set_dist_key(priv->net_dev, DPAA2_ETH_RX_DIST_CLS, 0); + if (err) + return err; + priv->rx_cls_enabled = 1; - return dpaa2_eth_set_dist_key(priv->net_dev, DPAA2_ETH_RX_DIST_CLS, 0); + return 0; } /* Bind the DPNI to its needed objects and resources: buffer pool, DPIOs,