From patchwork Wed Apr 10 19:50:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiong Wang X-Patchwork-Id: 1083561 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Dlf+3zdG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44fZX33Jvcz9s71 for ; Thu, 11 Apr 2019 05:50:43 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbfDJTum (ORCPT ); Wed, 10 Apr 2019 15:50:42 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36832 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726181AbfDJTul (ORCPT ); Wed, 10 Apr 2019 15:50:41 -0400 Received: by mail-wm1-f65.google.com with SMTP id h18so3907971wml.1 for ; Wed, 10 Apr 2019 12:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=O6OlTHii6j9e7eTQ+bnhdP8ya9aIrO2QI22g5wX9eOY=; b=Dlf+3zdGa/xsUucE8VU8V1MkDiasfXBFiRiblGXyUJRhZMqTJEiibbyJKboAoXPfT1 wz6mQMyKynUmfa/PWRD2lSvQtfhGL2gyaGO/SWI0rLUtkSA6A/fsnBhrP4Ra7GvLvBEn 4gy8XTynX9dYzprO9EVK4qD98mEodm6TjBZjIBNwgWZRLQsFrx82Db5EIDBIIc1+gHCu HYj6zOLX9M1YLC5rf2Jmk7Y2wrkjFsq58p9eRvngrR+JXqWze8yDWNK0PuhNRK3jdSgM BG/olKCKDSZo6P49mzCclAajEuom0Ze2m4ir/NRYKhYLXxpeTsV3RiJaop9yXXBwj5xh 7g2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=O6OlTHii6j9e7eTQ+bnhdP8ya9aIrO2QI22g5wX9eOY=; b=cMKnEBYetr7lQEG8ERDzsoT1bUT3P61dcIPjPr85qZ8tfOdc4/APMZDi3M8JXN6QPj FCGxDHZ8t9wbxuoSsCjx4dw0nVE53aLkYhXSU+pP7QU+y7Eii+QOnXKGpilAlxeTW3mw ckb6x64w64z0k6aBuBwEomw5B4L1iQfTR2wNVG9cUYBlxjI4rRqB8iBjn0rAHZd+No85 S/IfzKoKlmv9xmoX71byvGVhEZpizhd3Q8ZL0yBYX9hcz9ynR8K2LXjpXiaujnN+s7Vc qRLjoRdprDdsxnAvEjUIsZ3ffEQz6HFMT9qsuZs4Ur6hDW5qYquP8koXEdp/7BAMr7FB Mb1g== X-Gm-Message-State: APjAAAUK2wU+4/cruY4RRAxxWtvX0gwmmRBUqfyQQX2wNnin7rOj8I86 6HuAZEjeh8FA5iVjwjVNTKW9VQ== X-Google-Smtp-Source: APXvYqxhnZ28KPgl7KHA79WsXkfG54+6TnnyBtfvb5Kp2pcJxMPV4i5mVNiay2/W8iC+5jh+VdF4sQ== X-Received: by 2002:a1c:e0d6:: with SMTP id x205mr4153012wmg.28.1554925840152; Wed, 10 Apr 2019 12:50:40 -0700 (PDT) Received: from cbtest28.netronome.com ([217.38.71.146]) by smtp.gmail.com with ESMTPSA id 4sm2288540wmg.12.2019.04.10.12.50.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Apr 2019 12:50:39 -0700 (PDT) From: Jiong Wang To: alexei.starovoitov@gmail.com, daniel@iogearbox.net Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, Jiong Wang Subject: [PATCH/RFC v2 bpf-next 01/19] bpf: refactor propagate_liveness to eliminate duplicated for loop Date: Wed, 10 Apr 2019 20:50:15 +0100 Message-Id: <1554925833-7333-2-git-send-email-jiong.wang@netronome.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554925833-7333-1-git-send-email-jiong.wang@netronome.com> References: <1554925833-7333-1-git-send-email-jiong.wang@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Propagation for register and stack slot are finished in separate for loop, while they are perfect to be put into a single loop. This could also let them share some common variables in later patches. Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index b747434..f6ebe80 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -6223,10 +6223,8 @@ static int propagate_liveness(struct bpf_verifier_env *env, return err; } } - } - /* ... and stack slots */ - for (frame = 0; frame <= vstate->curframe; frame++) { + /* Propagate stack slots. */ state = vstate->frame[frame]; parent = vparent->frame[frame]; for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&