From patchwork Wed Feb 27 17:47:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 1049078 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=semihalf.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b="A6iZ9OW1"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 448jnf3xhRz9s4Y for ; Thu, 28 Feb 2019 04:47:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729115AbfB0Rrq (ORCPT ); Wed, 27 Feb 2019 12:47:46 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:35101 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726356AbfB0Rrq (ORCPT ); Wed, 27 Feb 2019 12:47:46 -0500 Received: by mail-lf1-f68.google.com with SMTP id m73so7571997lfa.2 for ; Wed, 27 Feb 2019 09:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=mmyBk9GgC8EvaZvsSj8EKGJFsCq9XS5xh0XfvJeZhkM=; b=A6iZ9OW1g/IIKbEvxkLCcp0DyilxMt7omV7zMciJ5Ev3wNiwQuIImYMWMckMjTcm8S JZFzQTMRbQgHgydFHny/otMDF/IG1tCoFKXTHXNTADhsfiWv3eIXYC0A0K8SeH1lBB3G dbNx8PxoKWBKtlPOSfZ85liifynfr1kBnQEYQHH/Q010CKme+iIsEd1ry4Yb8EOAwMsC hmCIbwkSjfydkwOOVezYCTv0zu8RCIJ22SzqgPv2G8YzcEvOWclvygf99E49P32pgVhJ P7mMFES8S4B1On/W2KnT1uigllPLCAiVdlHlGaNnYIFVXOw9s2U4cEGmrhzuIOw/j4gC 8RJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mmyBk9GgC8EvaZvsSj8EKGJFsCq9XS5xh0XfvJeZhkM=; b=rv96W62THqrciwGNS5YbmlRAejCQDy2xpQsOcrHkNcisYIBOZqc/e77zDvE452xkg3 qrn0Q/uXfLNTI+EcRTI3i4w5ojLPlitQf7zX+8EGKdgenUDTwWGDh2lIeD0+bujXo+m8 6tvXS/KmXhHT4x+J0lguJGRoGcMIAnEODQP6SZwSAF/YW34cJ9F+Bs2BvwQcow/QNT6Z /3S+hG8hpPAxB7y4enesWUYhd+1AxCsaDjHxezJsR7+PQ5lG0GYWCjOo3ZaLqdA4vYO1 oKqb7Np9zzZHpJdhIeRhGkV+knquEV5OQwoXonONYTS+u+pZ4rCavaQqVLEgt9FYIOFq obCA== X-Gm-Message-State: AHQUAuYp+Hs8SbJMr1MQbAdWUlidmRxJDu7gI1crjdXy6wbIbJsk9j+H HiAL2Y5iqft7S5Wl9HC893MqZg== X-Google-Smtp-Source: AHgI3IYiEUnhOIAF9R6AfcE20S+QTWnML4Mbba11DqQDiwQoxl71EY1NiGxicUp6KPTCWsOlAJSVZQ== X-Received: by 2002:a19:384a:: with SMTP id d10mr1577325lfj.111.1551289663762; Wed, 27 Feb 2019 09:47:43 -0800 (PST) Received: from gilgamesh.semihalf.com (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id m26sm3561637lji.22.2019.02.27.09.47.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Feb 2019 09:47:42 -0800 (PST) From: Marcin Wojtas To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Cc: davem@davemloft.net, linux@armlinux.org.uk, antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, stefanc@marvell.com, nadavh@marvell.com, mw@semihalf.com, jaz@semihalf.com, tn@semihalf.com Subject: [net: PATCH] net: mvpp2: disable link IRQ waiting for IDLE frames Date: Wed, 27 Feb 2019 18:47:32 +0100 Message-Id: <1551289652-7377-1-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Current version of the driver was configuring XLG MAC in a way to wait 3 IDLE frames before allowing for the link-up interrupt to be triggered. This resulted in an issue, preventing to detect the link change during RX traffic on the interface. Fix that. Fixes: 4bb043262878 ("net: mvpp2: phylink support") Signed-off-by: Marcin Wojtas --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index 16066c2..f1378f9 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -4532,8 +4532,7 @@ static void mvpp2_xlg_config(struct mvpp2_port *port, unsigned int mode, ctrl0 |= MVPP22_XLG_CTRL0_RX_FLOW_CTRL_EN; ctrl4 &= ~MVPP22_XLG_CTRL4_MACMODSELECT_GMAC; - ctrl4 |= MVPP22_XLG_CTRL4_FWD_FC | MVPP22_XLG_CTRL4_FWD_PFC | - MVPP22_XLG_CTRL4_EN_IDLE_CHECK; + ctrl4 |= MVPP22_XLG_CTRL4_FWD_FC | MVPP22_XLG_CTRL4_FWD_PFC; writel(ctrl0, port->base + MVPP22_XLG_CTRL0_REG); writel(ctrl4, port->base + MVPP22_XLG_CTRL4_REG);