From patchwork Wed Feb 27 15:31:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 1049571 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aoO+8PzG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 449G653rR6z9s1b for ; Fri, 1 Mar 2019 02:03:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730388AbfB1PD4 (ORCPT ); Thu, 28 Feb 2019 10:03:56 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42632 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726027AbfB1PDz (ORCPT ); Thu, 28 Feb 2019 10:03:55 -0500 Received: by mail-pf1-f195.google.com with SMTP id n74so9847977pfi.9 for ; Thu, 28 Feb 2019 07:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Au5vlW0/T/UVsvKsDSVoNHoCDSTmkuAehtL6M83B73A=; b=aoO+8PzGuge9TyAnmxH7kE4lDD7IsPzsM5Y0OOgj4REC27tVmui+KZY1rkQA96ZrIp ramfruGo7oNdV6yvwoMcKwzi7s54QD8+TXxhla4z/J8Vhxt8PZ0QI1Q1l+fqX0gLXAhi iHaaSB7Gob7rp0SlFLPOc4BzVAVlk4y8CffdvMi01yDgOY0pXsfCf1gRsdtwhf3z8o/i Iq2+OaazjsqxoIQoFN/EzoKOCmjkGXCA0gpDKYd1SKVWbgpqow5km+pe68TfVmdhxBnY bfKVJJSpb/2I4nRwHssjmqtaeb8nNK2HVHQq1onOxW48fN/RUfCGGHk48Rd1ax1fJj38 WYDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Au5vlW0/T/UVsvKsDSVoNHoCDSTmkuAehtL6M83B73A=; b=tc+5n3qEaRlHWDYAqhzT7J9dmGRYu76M+m/q06vTZ0xAw8NZ4MBf+3wtjPPi7RrH2Y 0nPIGsWcMNqB3T72WvVVg7fPdk/qEBPT6SNO6q6F30C2osCVGLO7ZqPzkUfn3m6dpsBx WG3cNEvMRlGdEBMOlWSb1meNuDqr4TrCQO5QWitwPHh8OoacHpSUTQMr88330B9xlnCA YdLwYou40j+Uy4PM8Yvc56ZufjzFsf3OqeQesoA3nYC2DRoJOYvb7BYangpu3qlb60ud moBNfIYOnaGFYYgZlDKMRaGi9Jgl/Bw2bRsX0/dBthgSP7Wm/+N5DR6jCXQW2vhUh2eT 9xGQ== X-Gm-Message-State: AHQUAuYjonS8GXozaSjKHo1yEp9OFemCxaxcIYW6nUHRTChasaVrZqta zYS47ubKcF7QKgFV8U7v0XE= X-Google-Smtp-Source: AHgI3IbpBUomGw522mrKocr6+xfHMd69NqLnkWeSS2aIDxL02zmQo0zky3DdzDIqiUNVhkZxYl1Row== X-Received: by 2002:a62:e017:: with SMTP id f23mr52349pfh.152.1551366234887; Thu, 28 Feb 2019 07:03:54 -0800 (PST) Received: from local.opencloud.tech.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id 186sm37081953pga.36.2019.02.28.07.03.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 07:03:53 -0800 (PST) From: xiangxia.m.yue@gmail.com To: saeedm@mellanox.com, gerlitz.or@gmail.com, roid@mellanox.com Cc: netdev@vger.kernel.org, Tonghao Zhang Subject: [PATCH net-next v4 1/4] net/mlx5e: Make the log friendly when decapsulation offload not supported Date: Wed, 27 Feb 2019 07:31:16 -0800 Message-Id: <1551281479-69243-2-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1551281479-69243-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1551281479-69243-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tonghao Zhang If we try to offload decapsulation actions to VFs hw, we get the log [1]. It's not friendly, because the kind of net device is null, and we don't know what '0' means. [1] "mlx5_core 0000:05:01.2 vf_0: decapsulation offload is not supported for net device (0)" Signed-off-by: Tonghao Zhang Reviewed-by: Roi Dayan --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c index bdcc5e7..6cbfbfa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c @@ -84,7 +84,7 @@ static const char *mlx5e_netdev_kind(struct net_device *dev) if (dev->rtnl_link_ops) return dev->rtnl_link_ops->kind; else - return ""; + return "unknown"; } static int mlx5e_route_lookup_ipv6(struct mlx5e_priv *priv, @@ -620,8 +620,10 @@ int mlx5e_tc_tun_parse(struct net_device *filter_dev, headers_c, headers_v); } else { netdev_warn(priv->netdev, - "decapsulation offload is not supported for %s net device (%d)\n", - mlx5e_netdev_kind(filter_dev), tunnel_type); + "decapsulation offload is not supported for %s (kind: \"%s\")\n", + netdev_name(filter_dev), + mlx5e_netdev_kind(filter_dev)); + return -EOPNOTSUPP; } return err;