From patchwork Mon Feb 25 10:40:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 1047670 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="C3xBPPZw"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447K010rXFz9s70 for ; Mon, 25 Feb 2019 22:06:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbfBYLG4 (ORCPT ); Mon, 25 Feb 2019 06:06:56 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:45614 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbfBYLGz (ORCPT ); Mon, 25 Feb 2019 06:06:55 -0500 Received: by mail-io1-f67.google.com with SMTP id x9so7107059iog.12 for ; Mon, 25 Feb 2019 03:06:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nFCP9U53ye40mkM1bdC3m4C/lii/yDcNlr34zu0IrQs=; b=C3xBPPZwKgkDy7X9We831xZeRtGu8eUndjTLPE1AJuY8AMfRv+5Im/4DoFsQA8q+dq ffor5+/dwxWGeqvAfYXCXCIdtbNZmT47SiHlqBj05k+1SQ2Nv/i9/pSF/nC7SZ+W+VNY uQQNqMcQ7WJ73hk5JiLqqL5dmHT44rUWDTmkZ6tMxeKKqp6nY6Jn0uBiYgifu/Q/oBF7 mL+9lzOP0jYXqRFwPHpyyV2BS+gMMCRO/MDrqeRJc7CIxBmsnCh3Sk5oVQxp3M6U9V5o JjflklQLGp3CH4G8iyUBF9dYjneozp6Jtjljz7Dn0fC9qtpi3GZmdjVOFz+Sxdm0ZGHG vBAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nFCP9U53ye40mkM1bdC3m4C/lii/yDcNlr34zu0IrQs=; b=XAvIFi4WXdVoIwazIR8krXMZTjXIsLUdqsure/mvwqee7Pje2wQ27g+JC3ubBu1k2s xPXGyvnIvzOE8qM16AFiUUGlahz81aYvQEOW/T7iG2HWH4vFaFqrEzxgyOCPLvh7lW6p APhiKHsATdxs2BfoDXDfiONSBkmRzNw8HCondydSwBt2dji0SKAoXi9LYBznuj/6+UFk TqOjnoGHSmHTl2fhYagZYorzx9yZKJ1OoPF8OTLd8IRw52c0koXC3klLpVX05osA/y5u q7A2wvoQRWqTOR/Wdss5i1+TpRxmKDR146vEV2BM6h6nZVh3C7Fc0h4CtU4o0FxcuCN3 hjgA== X-Gm-Message-State: AHQUAuaxau1pus3iOzqdNKPa72r/ixcnvTIj71Hy+QyjRC2baVfnZbDk 3dqhhVPjdGc9FwcWLQYbczM= X-Google-Smtp-Source: AHgI3IZPs6JFBdFYol8gh0azV0Myv6vbgK9ZXEViKuuveRziekLkG1cyTj1NA7vSvCNs2Zi9pOVCTg== X-Received: by 2002:a6b:710e:: with SMTP id q14mr8937595iog.210.1551092814454; Mon, 25 Feb 2019 03:06:54 -0800 (PST) Received: from local.opencloud.tech.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id c1sm4768369itd.23.2019.02.25.03.06.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 03:06:54 -0800 (PST) From: xiangxia.m.yue@gmail.com To: saeedm@mellanox.com, gerlitz.or@gmail.com Cc: netdev@vger.kernel.org, Tonghao Zhang Subject: [PATCH net-next v2 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported Date: Mon, 25 Feb 2019 02:40:04 -0800 Message-Id: <1551091207-10366-3-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1551091207-10366-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1551091207-10366-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tonghao Zhang If we try to offload decapsulation actions to VFs hw, we get the log [1]. It's not friendly, because the kind of net device is null, and we don't know what '0' means. [1] "mlx5_core 0000:05:01.2 vf_0: decapsulation offload is not supported for net device (0)" Signed-off-by: Tonghao Zhang Reviewed-by: Roi Dayan --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c index bdcc5e7..6cbfbfa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c @@ -84,7 +84,7 @@ static const char *mlx5e_netdev_kind(struct net_device *dev) if (dev->rtnl_link_ops) return dev->rtnl_link_ops->kind; else - return ""; + return "unknown"; } static int mlx5e_route_lookup_ipv6(struct mlx5e_priv *priv, @@ -620,8 +620,10 @@ int mlx5e_tc_tun_parse(struct net_device *filter_dev, headers_c, headers_v); } else { netdev_warn(priv->netdev, - "decapsulation offload is not supported for %s net device (%d)\n", - mlx5e_netdev_kind(filter_dev), tunnel_type); + "decapsulation offload is not supported for %s (kind: \"%s\")\n", + netdev_name(filter_dev), + mlx5e_netdev_kind(filter_dev)); + return -EOPNOTSUPP; } return err;