From patchwork Fri Feb 22 22:36:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiong Wang X-Patchwork-Id: 1047156 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="F3NuTsdr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 445mQq5wcSz9sBr for ; Sat, 23 Feb 2019 09:36:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726472AbfBVWgS (ORCPT ); Fri, 22 Feb 2019 17:36:18 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34246 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbfBVWgR (ORCPT ); Fri, 22 Feb 2019 17:36:17 -0500 Received: by mail-wr1-f65.google.com with SMTP id f14so4012141wrg.1 for ; Fri, 22 Feb 2019 14:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/mzeVNctlEvAwwLIOc8hxdBCbQQ/8Fk7/Vg70KhHuUM=; b=F3NuTsdrcEwoWM+jwl07V4mZAGd/PTfJNpUnI5rMxFEiQZhLynnf8xKs52dgXR6dTz /kiODz1MKY+nA+Dmn7VEXoDwLW4OK31iDv+PVBlzEbe28hJK/9j15bUhkQgBNqLbaVA8 nnxqT8RQgs08zo/gkamJyefnj9Rv38UBNSOG0o7qFgbedhUuiuzl+YF25oqwAonAXVhO +KFSQdEsEp7qL8WLvYNnh/SJj6/MWpaxgPJxFkD1hBn2FjvelIpxAYnKjgYN2sswRF4X GOcRfPmGal9fO+l/bCrztsJBg8Vt6olsQi948RXprjoYXplYpvL+mzKq9skpDh2FSZDX MCiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/mzeVNctlEvAwwLIOc8hxdBCbQQ/8Fk7/Vg70KhHuUM=; b=d7SCMBxXGtM86kknANAeh4Yg0wGt1sxu815jgKItWcoqM7SJy2+NQWJzTw9w/zNgGJ ZqQROX7WquDLpp36OPldqXZfv8dZMDzRVwxq1wZI5/j2Ztamx4zYwYBiuk+BY/0Njnj2 /05N1El0C1BQKsbpSuQJk5h6pJKY+GbnqGrV6T4XJAjD0rFEVdqtixRdl+xzoBEX95jr di3c2mJiB2IWy+WX1m4uZGaO4nsJXfuuyf8OzXzeTrsHoCbxt4LIYR1RJaXlbbmWaQwU 6VOAnncbAxdTvRxj5CfbRlrC/fvsnk6ENVS63IQ+/3nqCw94g8/lAzN3dfE7cpZ/yK3E N0kg== X-Gm-Message-State: AHQUAubQ1b0UaxcvwCTgJjlsrcx2hXN7OfIS8wAMmdzV+O/B0I4dXhaJ WA7TTg7uWyrqntMVKe50COUP0rAW8qs= X-Google-Smtp-Source: AHgI3IYbIADOn4lrZ3qpJL9BNm07qyZe/MJ784Y/giFfMH/58QqPUpl+kmmat9gRB3fMFPrPYmMpMQ== X-Received: by 2002:adf:df0d:: with SMTP id y13mr4376508wrl.69.1550874975416; Fri, 22 Feb 2019 14:36:15 -0800 (PST) Received: from cbtest28.netronome.com ([217.38.71.146]) by smtp.gmail.com with ESMTPSA id m15sm1964975wrx.30.2019.02.22.14.36.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Feb 2019 14:36:14 -0800 (PST) From: Jiong Wang To: alexei.starovoitov@gmail.com, daniel@iogearbox.net Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Jiong Wang Subject: [PATCH bpf 1/2] nfp: bpf: fix code-gen bug on BPF_ALU | BPF_XOR | BPF_K Date: Fri, 22 Feb 2019 22:36:03 +0000 Message-Id: <1550874964-16769-2-git-send-email-jiong.wang@netronome.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1550874964-16769-1-git-send-email-jiong.wang@netronome.com> References: <1550874964-16769-1-git-send-email-jiong.wang@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The intended optimization should be A ^ 0 = A, not A ^ -1 = A. Fixes: cd7df56ed3e6 ("nfp: add BPF to NFP code translator") Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c b/drivers/net/ethernet/netronome/nfp/bpf/jit.c index e23ca90..a096965 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/jit.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/jit.c @@ -2309,7 +2309,7 @@ static int xor_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) static int xor_imm(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) { - return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !~meta->insn.imm); + return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !meta->insn.imm); } static int and_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)