From patchwork Fri Feb 15 14:49:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 1042937 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ORC6BIAJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 441GQR6hd3z9s5c for ; Sat, 16 Feb 2019 01:50:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732883AbfBOOuX (ORCPT ); Fri, 15 Feb 2019 09:50:23 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38949 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbfBOOuW (ORCPT ); Fri, 15 Feb 2019 09:50:22 -0500 Received: by mail-pl1-f196.google.com with SMTP id 101so5064040pld.6 for ; Fri, 15 Feb 2019 06:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sxnLW4/9WnhEo/uxgQj/bn4NV9NpmmO5f0cNI1WIkok=; b=ORC6BIAJCVv6pj2B0i/FQVr6i0yQYF5lojwbB0sjXaxR9ZiKU9cNWZJhrhyHkTM5b1 JY2ff5KBoMvAgknXFcJzeTjGlGr8n3LefE+daObq8EEcTg9M4l33WtxKz/YukRm4kvxJ 5qNGDx1cG2in52eM1op6Q/GpW0m3hPjjadYjPAeJxMRDIHUrOss/Q6pw4Y1W/zIw7MIx FryaF+UUwbfrIc+I9WuQJKmXaiM5AUHls0MsaaZxI9N1QLQFjWEaq6iNKI5SWNUsvjBZ LkwL9S5KYeDDrAJtCaVQKxP0RD6YoDaL8tuyA7gPu0DuwGzc3zlKA3g6KaXOiCTCmuZD knkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sxnLW4/9WnhEo/uxgQj/bn4NV9NpmmO5f0cNI1WIkok=; b=L/ZocGqZjX8AU1aYfhoABSS5jycsCFvzbCK9fg5QzVLzmRhLH1MVlBfd20rA/5reog 6uZxpG4liKslLPlJo9KDv9JI2mEFjL8Ek7jzxliKesvC7Vv5BK2r09bBf+gxc+mlTQ1f gaSJPk9J2/HCUXorfnJgrGERdu4Ngw2XPKaa6fcQLis2jz1WIXSbktZj6J7v+BTEoxcY aZj4+wFK54uK0aOMe8BJNJLJMWBafdJZL1kD/nyZSse3Nqssp5WGXkpxqzfFTpdxgZ4D RI5qrgFpJE2NlObjWP4dRbI4mKRHjahibxRZbPE0Ij0SOCxv1RAl0fytfH3ufcsvMln8 bNkg== X-Gm-Message-State: AHQUAuaq/Ii6LZ8Ee+UUrefCmPBW9hZACnvrmV6F3lckEAs5HgBxa3+8 g9fieXZMp3Q4KWWPvzLtZ/8= X-Google-Smtp-Source: AHgI3IZlGkWZ88bS06CHgJzJthkCzA446e2UpoXmGcDNsVKhWH/fr8nUAdsNKL3cu/4lS9DtXjpUEg== X-Received: by 2002:a17:902:bd86:: with SMTP id q6mr10358662pls.16.1550242221814; Fri, 15 Feb 2019 06:50:21 -0800 (PST) Received: from localhost.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id k65sm1900870pge.74.2019.02.15.06.50.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 06:50:21 -0800 (PST) From: Yafang Shao To: davem@davemloft.net Cc: daniel@iogearbox.net, edumazet@google.com, netdev@vger.kernel.org, shaoyafang@didiglobal.com, Yafang Shao Subject: [net-next 4/5] dccp: clean up SOCK_DEBUG() Date: Fri, 15 Feb 2019 22:49:46 +0800 Message-Id: <1550242187-29660-5-git-send-email-laoar.shao@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> References: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Per discussion with Daniel[1] and Eric[2], the SOCK_DEBUG() is a very ancient interface, which is not very useful for debugging. So we'd better clean up it. This patch cleans up it for dccp. [1] https://patchwork.ozlabs.org/patch/1035573/ [2] https://patchwork.ozlabs.org/patch/1040533/ Signed-off-by: Yafang Shao --- net/dccp/ipv6.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c index d5740ba..8e72e50 100644 --- a/net/dccp/ipv6.c +++ b/net/dccp/ipv6.c @@ -878,8 +878,6 @@ static int dccp_v6_connect(struct sock *sk, struct sockaddr *uaddr, u32 exthdrlen = icsk->icsk_ext_hdr_len; struct sockaddr_in sin; - SOCK_DEBUG(sk, "connect: ipv4 mapped\n"); - if (__ipv6_only_sock(sk)) return -ENETUNREACH;