From patchwork Mon Jan 28 23:28:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 1032952 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TvF1CoIl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43pvYW4NGcz9sBZ for ; Wed, 30 Jan 2019 05:05:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728914AbfA2SFe (ORCPT ); Tue, 29 Jan 2019 13:05:34 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42406 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727607AbfA2SFd (ORCPT ); Tue, 29 Jan 2019 13:05:33 -0500 Received: by mail-pg1-f194.google.com with SMTP id d72so9061778pga.9 for ; Tue, 29 Jan 2019 10:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MRjewqtNEtrdL1DtjkL8Iii7l5DOc3mub9TOYy9HG3o=; b=TvF1CoIl7G0Q+HyTiXq8Fl3LwGJ21EAX3tlSTHKB5mYuqqj/sdwH2TB+wu7l1EnwCM S+4euShQFPvDutLodQR628QlylFebZabjaqfKsLKdHWMBpkOHI/1zjkDI510buJFc/wc ugOxGCxvnl1A6K8GL4Ll8v5O1SaoaRmGVIOmvrCmTZoVk4ckSinJraEREXKSvng+hT9P 32SAw0+WY7qpBIVtPEgjOKDUFNhAHqsukufSgO3LqkjChNtHwWaOjPuFIQsUDK1PNvYj NColvrkw0Au6RC7B0clazLfCz+/PrWV0f/Dukl7nhLDAy2ex7yqwymyZzb0HzlRKdmcU L1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MRjewqtNEtrdL1DtjkL8Iii7l5DOc3mub9TOYy9HG3o=; b=KF+gN5gMcXE3V6rnZGTF19TDysCnl8DJrgpc+5pCqI5Ew7YMB6wbF8JWvQjtRSBT0O C8STZQMJqqhJu18xWqZIl8+o6mtG90gBtHH7H0yePf74bXtWWdCb+NhiE+vOi/Gujooh KSyKvmwoYUVZkhL+71VknxZ88iIY3k7NpdgeXeHgfJy/6STcP9WUF5WT62FzBnlIVDu/ nVtowcFeKVX1cGOV2KFAssjSsP6nJpz4m3W5/hr8pCCr1oVHYoZGEi3jSoJshzXwIJS4 B+cGxQtMLp2W1gPJ4MKR1Opw7tqBFnIxG0uKf4Iz2uD6AjCzgueRVJpHASArifKbzL6d tyaw== X-Gm-Message-State: AJcUukdC//yzl6dzv6epJFjnRQEyI16i09w+wMebW+JLfGbIE2MzLm4n BErqxWUUOz1qBAUY/zy469E= X-Google-Smtp-Source: ALg8bN6oyqaEt7bm3yBRsZR12CJ4M1fICxh1+brGKCeDownc0iM9cGzbtpOyBgqabscv14jVALWqhQ== X-Received: by 2002:a63:374e:: with SMTP id g14mr25112828pgn.59.1548785132923; Tue, 29 Jan 2019 10:05:32 -0800 (PST) Received: from local.opencloud.tech.localdomain ([106.120.33.223]) by smtp.gmail.com with ESMTPSA id b2sm65284351pfm.3.2019.01.29.10.05.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 10:05:32 -0800 (PST) From: xiangxia.m.yue@gmail.com To: saeedm@mellanox.com, gerlitz.or@gmail.com, davem@davemloft.net Cc: netdev@vger.kernel.org, Tonghao Zhang , Or Gerlitz Subject: [PATCH net v5 2/2] net/mlx5e: Don't overwrite pedit action when multiple pedit used Date: Mon, 28 Jan 2019 15:28:06 -0800 Message-Id: <1548718086-20924-2-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1548718086-20924-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1548718086-20924-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tonghao Zhang In some case, we may use multiple pedit actions to modify packets. The command shown as below: the last pedit action is effective. $ tc filter add dev netdev_rep parent ffff: protocol ip prio 1 \ flower skip_sw ip_proto icmp dst_ip 3.3.3.3 \ action pedit ex munge ip dst set 192.168.1.100 pipe \ action pedit ex munge eth src set 00:00:00:00:00:01 pipe \ action pedit ex munge eth dst set 00:00:00:00:00:02 pipe \ action csum ip pipe \ action tunnel_key set src_ip 1.1.1.100 dst_ip 1.1.1.200 dst_port 4789 id 100 \ action mirred egress redirect dev vxlan0 To fix it, we add max_mod_hdr_actions to mlx5e_tc_flow_parse_attr struction, max_mod_hdr_actions will store the max pedit action number we support and num_mod_hdr_actions indicates how many pedit action we used, and store all pedit action to mod_hdr_actions. Fixes: d79b6df6b10a ("net/mlx5e: Add parsing of TC pedit actions to HW format") Cc: Or Gerlitz Signed-off-by: Tonghao Zhang Reviewed-by: Or Gerlitz Acked-by: Saeed Mahameed --- v3: Remove the unnecessary init. v2: Fix comment message and change tag from net-next to net. --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index cae6c6d..a21724d0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -128,6 +128,7 @@ struct mlx5e_tc_flow_parse_attr { struct net_device *filter_dev; struct mlx5_flow_spec spec; int num_mod_hdr_actions; + int max_mod_hdr_actions; void *mod_hdr_actions; int mirred_ifindex[MLX5_MAX_FLOW_FWD_VPORTS]; }; @@ -1934,9 +1935,9 @@ struct mlx5_fields { OFFLOAD(UDP_DPORT, 2, udp.dest, 0), }; -/* On input attr->num_mod_hdr_actions tells how many HW actions can be parsed at - * max from the SW pedit action. On success, it says how many HW actions were - * actually parsed. +/* On input attr->max_mod_hdr_actions tells how many HW actions can be parsed at + * max from the SW pedit action. On success, attr->num_mod_hdr_actions + * says how many HW actions were actually parsed. */ static int offload_pedit_fields(struct pedit_headers *masks, struct pedit_headers *vals, @@ -1960,9 +1961,11 @@ static int offload_pedit_fields(struct pedit_headers *masks, add_vals = &vals[TCA_PEDIT_KEY_EX_CMD_ADD]; action_size = MLX5_UN_SZ_BYTES(set_action_in_add_action_in_auto); - action = parse_attr->mod_hdr_actions; - max_actions = parse_attr->num_mod_hdr_actions; - nactions = 0; + action = parse_attr->mod_hdr_actions + + parse_attr->num_mod_hdr_actions * action_size; + + max_actions = parse_attr->max_mod_hdr_actions; + nactions = parse_attr->num_mod_hdr_actions; for (i = 0; i < ARRAY_SIZE(fields); i++) { f = &fields[i]; @@ -2073,7 +2076,7 @@ static int alloc_mod_hdr_actions(struct mlx5e_priv *priv, if (!parse_attr->mod_hdr_actions) return -ENOMEM; - parse_attr->num_mod_hdr_actions = max_actions; + parse_attr->max_mod_hdr_actions = max_actions; return 0; } @@ -2119,9 +2122,11 @@ static int parse_tc_pedit_action(struct mlx5e_priv *priv, goto out_err; } - err = alloc_mod_hdr_actions(priv, a, namespace, parse_attr); - if (err) - goto out_err; + if (!parse_attr->mod_hdr_actions) { + err = alloc_mod_hdr_actions(priv, a, namespace, parse_attr); + if (err) + goto out_err; + } err = offload_pedit_fields(masks, vals, parse_attr, extack); if (err < 0)