From patchwork Wed Dec 19 01:04:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1015777 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZMQ7F/fZ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43KGdm57p7z9s1c for ; Wed, 19 Dec 2018 11:55:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727280AbeLSAzQ (ORCPT ); Tue, 18 Dec 2018 19:55:16 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44954 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726629AbeLSAzP (ORCPT ); Tue, 18 Dec 2018 19:55:15 -0500 Received: by mail-pg1-f194.google.com with SMTP id t13so8608250pgr.11 for ; Tue, 18 Dec 2018 16:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=5V7IDoU0URcB9RwjD6T7/u6eLbOjAJV4Qq04SrGOew0=; b=ZMQ7F/fZ3ANB3PEs8lyC44d/z75X0Lq8OKF4cLyi2nTiufmjLVajXqtZnIl0zHTzuV S1KIBoUmIziTLX8w8B3es1UoGtOxGDyxPbJchMkufWu5bkZwffgaNP5OawURJE4ZIXhj eH7Oc8VGFGS8iRaTjmVN6zwOiNa2+JmhhXLv9RS3iCpV4f8Y1M58AIXbYapCIo2sxiKE rvVaNkTSs/knoSBecTAQ7B2JWn2Z27m7tCZ/iKjrkLAkhuJfheUAbAfkuun4LaaZ5c6G AbVNftoW+i1SMSu9MorESkblnQA5lQ+InlZoyJc1mgKSCneExCB/h/tE0+tH2AkPFkyE WEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=5V7IDoU0URcB9RwjD6T7/u6eLbOjAJV4Qq04SrGOew0=; b=KVlaA4HdtaujPItK65RCxT+pSH7UAGC1mcG8xTwFlmImc1rhO/SlHQQ6NagQD/VHW/ dCBtmayUPjfNm32OLRL3P+AD15yabpxMmFqn9EQHHXHrBNkSjy0gdKyVKJq/eP8Mddmt O7SQXYIZSc8IkCjLSctND2sK8lrWwH1Jakci2janzkujjH88M/aJRS7PaWFl0zahBKFb 8zPUeAGKqJIBrNd4jX0vq7zzTVTn/NUGt5bOsf4Cg0JwBwifxGHVZoUjBd1+VpAy1ibe zhGt5/TAvsrAC0+fkE7t8Wf1U302buhU9v0Pjx4E6TJFHJ8jIT6qRIGqsite/2C3q098 /skA== X-Gm-Message-State: AA+aEWZGyb9kgXrEaWnHddKki7xYq0wP9gU1Lbdj8mUJfLQS8T3Xa7WL B5N6xsdHuQwLGr0voTD5SEA= X-Google-Smtp-Source: AFSGD/VQEBMn24hkdDwSPrQD9eakxdQVY0JIcxKAJD6Eq9x6l12hiOoBXfbqGcnuSxcLmSR4GBWw2A== X-Received: by 2002:a63:89c2:: with SMTP id v185mr16245357pgd.97.1545180914210; Tue, 18 Dec 2018 16:55:14 -0800 (PST) Received: from sc9-mailhost2.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id c13sm38964804pfe.93.2018.12.18.16.55.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Dec 2018 16:55:13 -0800 (PST) From: William Tu To: bjorn.topel@gmail.com, magnus.karlsson@gmail.com, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, makita.toshiaki@lab.ntt.co.jp, yihung.wei@gmail.com Subject: [bpf-next RFCv2 2/3] veth: support AF_XDP. Date: Tue, 18 Dec 2018 17:04:52 -0800 Message-Id: <1545181493-8743-3-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1545181493-8743-1-git-send-email-u9012063@gmail.com> References: <1545181493-8743-1-git-send-email-u9012063@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The patch adds support for AF_XDP async xmit. Users can use AF_XDP on both side of the veth and get better performance, with the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit simply kicks the napi function, veth_poll, to run, and the transmit logic is implemented there. Tested using two namespaces, one runs xdpsock and the other runs xdp_rxq_info. A simple script comparing the performance with/without AF_XDP shows improvement from 724Kpps to 1.1Mpps. ip netns add at_ns0 ip link add p0 type veth peer name p1 ip link set p0 netns at_ns0 ip link set dev p1 up ip netns exec at_ns0 ip link set dev p0 up # receiver ip netns exec at_ns0 xdp_rxq_info --dev p0 --action XDP_DROP # sender xdpsock -i p1 -t -N -z or xdpsock -i p1 -t -S Signed-off-by: William Tu --- drivers/net/veth.c | 199 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 197 insertions(+), 2 deletions(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index f412ea1cef18..0ce89820ce70 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -25,6 +25,10 @@ #include #include #include +#include +#include +#include +#include #define DRV_NAME "veth" #define DRV_VERSION "1.0" @@ -53,6 +57,8 @@ struct veth_rq { bool rx_notify_masked; struct ptr_ring xdp_ring; struct xdp_rxq_info xdp_rxq; + struct xdp_umem *xsk_umem; + u16 qid; }; struct veth_priv { @@ -737,15 +743,108 @@ static int veth_xdp_rcv(struct veth_rq *rq, int budget, unsigned int *xdp_xmit) return done; } +static int veth_xsk_send(struct napi_struct *napi, int budget) +{ + struct veth_rq *rq = + container_of(napi, struct veth_rq, xdp_napi); + int done = 0; + + /* tx: use netif_tx_napi_add? */ + while (rq->xsk_umem && budget--) { + struct veth_priv *priv, *peer_priv; + struct net_device *dev, *peer_dev; + unsigned int inner_xdp_xmit = 0; + unsigned int metasize = 0; + struct veth_rq *peer_rq; + struct xdp_frame *xdpf; + bool dropped = false; + struct sk_buff *skb; + struct page *page; + void *vaddr; + void *addr; + u32 len; + + if (!xsk_umem_consume_tx_virtual(rq->xsk_umem, &vaddr, &len)) + break; + + page = dev_alloc_page(); + if (!page) { + pr_warn("veth: page allocation fails\n"); + xsk_umem_complete_tx(rq->xsk_umem, 1); + xsk_umem_consume_tx_done(rq->xsk_umem); + return -ENOMEM; + } + + addr = page_to_virt(page); + xdpf = addr; + memset(xdpf, 0, sizeof(*xdpf)); + + addr += sizeof(*xdpf); + memcpy(addr, vaddr, len); + + xdpf->data = addr + metasize; + xdpf->len = len; + xdpf->headroom = 0; + xdpf->metasize = metasize; + xdpf->mem.type = MEM_TYPE_PAGE_SHARED; + + /* Invoke peer rq to rcv */ + dev = rq->dev; + priv = netdev_priv(dev); + peer_dev = priv->peer; + peer_priv = netdev_priv(peer_dev); + peer_rq = &peer_priv->rq[rq->qid]; + + /* put into peer rq */ + skb = veth_xdp_rcv_one(peer_rq, xdpf, &inner_xdp_xmit); + if (!skb) { + /* Peer side has XDP program attached */ + if (inner_xdp_xmit & VETH_XDP_TX) { + /* Not supported */ + pr_warn("veth: peer XDP_TX not supported\n"); + xdp_return_frame(xdpf); + dropped = true; + goto skip_tx; + } else if (inner_xdp_xmit & VETH_XDP_REDIR) { + xdp_do_flush_map(); + } else { + dropped = true; + } + } else { + /* Peer side has no XDP attached */ + napi_gro_receive(&peer_rq->xdp_napi, skb); + } +skip_tx: + xsk_umem_complete_tx(rq->xsk_umem, 1); + xsk_umem_consume_tx_done(rq->xsk_umem); + + /* update peer stats */ + u64_stats_update_begin(&peer_rq->stats.syncp); + peer_rq->stats.xdp_packets++; + peer_rq->stats.xdp_bytes += len; + if (dropped) + rq->stats.xdp_drops++; + u64_stats_update_end(&peer_rq->stats.syncp); + done++; + } + + return done; +} + static int veth_poll(struct napi_struct *napi, int budget) { struct veth_rq *rq = container_of(napi, struct veth_rq, xdp_napi); unsigned int xdp_xmit = 0; - int done; + int done = 0; + int tx_done; + + tx_done = veth_xsk_send(napi, budget); + if (tx_done > 0) + done += tx_done; xdp_set_return_frame_no_direct(); - done = veth_xdp_rcv(rq, budget, &xdp_xmit); + done += veth_xdp_rcv(rq, budget, &xdp_xmit); if (done < budget && napi_complete_done(napi, done)) { /* Write rx_notify_masked before reading ptr_ring */ @@ -776,6 +875,7 @@ static int veth_napi_add(struct net_device *dev) err = ptr_ring_init(&rq->xdp_ring, VETH_RING_SIZE, GFP_KERNEL); if (err) goto err_xdp_ring; + rq->qid = i; } for (i = 0; i < dev->real_num_rx_queues; i++) { @@ -812,6 +912,7 @@ static void veth_napi_del(struct net_device *dev) netif_napi_del(&rq->xdp_napi); rq->rx_notify_masked = false; ptr_ring_cleanup(&rq->xdp_ring, veth_ptr_free); + rq->qid = -1; } } @@ -836,6 +937,7 @@ static int veth_enable_xdp(struct net_device *dev) /* Save original mem info as it can be overwritten */ rq->xdp_mem = rq->xdp_rxq.mem; + rq->qid = i; } err = veth_napi_add(dev); @@ -1115,6 +1217,78 @@ static u32 veth_xdp_query(struct net_device *dev) return 0; } +int veth_xsk_umem_query(struct net_device *dev, struct xdp_umem **umem, + u16 qid) +{ + struct xdp_umem *queried_umem; + + queried_umem = xdp_get_umem_from_qid(dev, qid); + + if (!queried_umem) + return -EINVAL; + + *umem = queried_umem; + return 0; +} + +static int veth_xsk_umem_enable(struct net_device *dev, + struct xdp_umem *umem, + u16 qid) +{ + struct veth_priv *priv = netdev_priv(dev); + struct xdp_umem_fq_reuse *reuseq; + int err = 0; + + if (qid >= dev->real_num_rx_queues) + return -EINVAL; + + reuseq = xsk_reuseq_prepare(priv->rq[0].xdp_ring.size); + if (!reuseq) + return -ENOMEM; + + xsk_reuseq_free(xsk_reuseq_swap(umem, reuseq)); + + priv->rq[qid].xsk_umem = umem; + return err; +} + +static int veth_xsk_umem_disable(struct net_device *dev, + u16 qid) +{ + struct veth_priv *priv = netdev_priv(dev); + struct xdp_umem *umem; + + umem = xdp_get_umem_from_qid(dev, qid); + if (!umem) + return -EINVAL; + + priv->rq[qid].xsk_umem = NULL; + return 0; +} + +int veth_xsk_umem_setup(struct net_device *dev, struct xdp_umem *umem, + u16 qid) +{ + return umem ? veth_xsk_umem_enable(dev, umem, qid) : + veth_xsk_umem_disable(dev, qid); +} + +int veth_xsk_async_xmit(struct net_device *dev, u32 qid) +{ + struct veth_priv *priv = netdev_priv(dev); + struct veth_rq *rq; + + rq = &priv->rq[qid]; + + if (qid >= dev->real_num_rx_queues) + return -ENXIO; + + if (!napi_if_scheduled_mark_missed(&rq->xdp_napi)) + napi_schedule(&rq->xdp_napi); + + return 0; +} + static int veth_xdp(struct net_device *dev, struct netdev_bpf *xdp) { switch (xdp->command) { @@ -1123,6 +1297,26 @@ static int veth_xdp(struct net_device *dev, struct netdev_bpf *xdp) case XDP_QUERY_PROG: xdp->prog_id = veth_xdp_query(dev); return 0; + case XDP_QUERY_XSK_UMEM: + return veth_xsk_umem_query(dev, &xdp->xsk.umem, + xdp->xsk.queue_id); + case XDP_SETUP_XSK_UMEM: { + struct veth_priv *priv; + int err; + + /* Enable XDP on both sides */ + err = veth_enable_xdp(dev); + if (err) + return err; + + priv = netdev_priv(dev); + err = veth_enable_xdp(priv->peer); + if (err) + return err; + + return veth_xsk_umem_setup(dev, xdp->xsk.umem, + xdp->xsk.queue_id); + } default: return -EINVAL; } @@ -1145,6 +1339,7 @@ static const struct net_device_ops veth_netdev_ops = { .ndo_set_rx_headroom = veth_set_rx_headroom, .ndo_bpf = veth_xdp, .ndo_xdp_xmit = veth_xdp_xmit, + .ndo_xsk_async_xmit = veth_xsk_async_xmit, }; #define VETH_FEATURES (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HW_CSUM | \