diff mbox series

[net-next] dpaa2-eth: Add "fall through" comments

Message ID 1543481014-18259-1-git-send-email-ruxandra.radulescu@nxp.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [net-next] dpaa2-eth: Add "fall through" comments | expand

Commit Message

Ioana Radulescu Nov. 29, 2018, 8:43 a.m. UTC
Add comments in the switch statement for XDP action to indicate
fallthrough is intended.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

David Miller Nov. 29, 2018, 6:41 p.m. UTC | #1
From: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Date: Thu, 29 Nov 2018 08:43:40 +0000

> Add comments in the switch statement for XDP action to indicate
> fallthrough is intended.
> 
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index be84171..1ca9a18 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -322,8 +322,10 @@  static u32 run_xdp(struct dpaa2_eth_priv *priv,
 		break;
 	default:
 		bpf_warn_invalid_xdp_action(xdp_act);
+		/* fall through */
 	case XDP_ABORTED:
 		trace_xdp_exception(priv->net_dev, xdp_prog, xdp_act);
+		/* fall through */
 	case XDP_DROP:
 		xdp_release_buf(priv, ch, addr);
 		ch->stats.xdp_drop++;