From patchwork Tue Oct 2 07:24:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eran Ben Elisha X-Patchwork-Id: 977658 X-Patchwork-Delegate: linville@tuxdriver.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42PVzC55yYz9sBq for ; Tue, 2 Oct 2018 17:24:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbeJBOGm (ORCPT ); Tue, 2 Oct 2018 10:06:42 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:44371 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726554AbeJBOGm (ORCPT ); Tue, 2 Oct 2018 10:06:42 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from eranbe@mellanox.com) with ESMTPS (AES256-SHA encrypted); 2 Oct 2018 09:29:27 +0200 Received: from dev-l-vrt-199-005.mtl.labs.mlnx (dev-l-vrt-199-005.mtl.labs.mlnx [10.134.199.5]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w927Olri009512; Tue, 2 Oct 2018 10:24:47 +0300 From: Eran Ben Elisha To: netdev@vger.kernel.org, "John W. Linville" Cc: Chris Preimesberger , Andrew Lunn , Neil Horman , Vidya Sagar Ravipati , Eran Ben Elisha Subject: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump Date: Tue, 2 Oct 2018 10:24:19 +0300 Message-Id: <1538465059-24645-1-git-send-email-eranbe@mellanox.com> X-Mailer: git-send-email 1.8.4.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Struct sff_diags can be used uninitialized at sff8636_show_dom, this caused the tool to show unreported fields (supports_alarms) by the lower level driver. In addition, make sure the same struct is being initialized at sff8472_parse_eeprom function, to avoid the same issue here. Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support") Signed-off-by: Eran Ben Elisha Reviewed-by: Andrew Lunn --- qsfp.c | 2 +- sfpdiag.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qsfp.c b/qsfp.c index 32e195d12dc0..d196aa1753de 100644 --- a/qsfp.c +++ b/qsfp.c @@ -671,7 +671,7 @@ static void sff8636_dom_parse(const __u8 *id, struct sff_diags *sd) static void sff8636_show_dom(const __u8 *id, __u32 eeprom_len) { - struct sff_diags sd; + struct sff_diags sd = {0}; char *rx_power_string = NULL; char power_string[MAX_DESC_SIZE]; int i; diff --git a/sfpdiag.c b/sfpdiag.c index 32e4cd8917a4..fa41651422ea 100644 --- a/sfpdiag.c +++ b/sfpdiag.c @@ -241,7 +241,7 @@ static void sff8472_parse_eeprom(const __u8 *id, struct sff_diags *sd) void sff8472_show_all(const __u8 *id) { - struct sff_diags sd; + struct sff_diags sd = {0}; char *rx_power_string = NULL; int i;