From patchwork Tue Jun 5 01:26:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subash Abhinov Kasiviswanathan X-Patchwork-Id: 925275 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="Y90k3nCD"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Y90k3nCD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 410Dfs62kQz9s1R for ; Tue, 5 Jun 2018 11:26:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbeFEB0n (ORCPT ); Mon, 4 Jun 2018 21:26:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43656 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbeFEB0m (ORCPT ); Mon, 4 Jun 2018 21:26:42 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A060A607E2; Tue, 5 Jun 2018 01:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1528162001; bh=pK9dUKopKT4cltYOPSn6QI/UoHCLc0FuxEvnq70gpTU=; h=From:To:Cc:Subject:Date:From; b=Y90k3nCD6D2tGpmGslg3c7OTtKb2etRHAMD7xF3VNThoUDmNhHqmawDyI83BC+yI4 EqZiP536TC9iibzGKprZkMQ7KcW2aAHvWhHv26EjN3++YECoxLdhyUPT1e4q/l+TNk U9lzfY7duYjqzDCH/MshuwzLmtAC5Ale41t4LWnQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from subashab-lnx.qualcomm.com (unknown [129.46.15.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: subashab@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AEC4060590; Tue, 5 Jun 2018 01:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1528162001; bh=pK9dUKopKT4cltYOPSn6QI/UoHCLc0FuxEvnq70gpTU=; h=From:To:Cc:Subject:Date:From; b=Y90k3nCD6D2tGpmGslg3c7OTtKb2etRHAMD7xF3VNThoUDmNhHqmawDyI83BC+yI4 EqZiP536TC9iibzGKprZkMQ7KcW2aAHvWhHv26EjN3++YECoxLdhyUPT1e4q/l+TNk U9lzfY7duYjqzDCH/MshuwzLmtAC5Ale41t4LWnQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AEC4060590 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=subashab@codeaurora.org From: Subash Abhinov Kasiviswanathan To: davem@davemloft.net, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org Cc: Subash Abhinov Kasiviswanathan , Sean Tranchetti Subject: [PATCH net-next v2] net: ipv6: Generate random IID for addresses on RAWIP devices Date: Mon, 4 Jun 2018 19:26:07 -0600 Message-Id: <1528161967-6382-1-git-send-email-subashab@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org RAWIP devices such as rmnet do not have a hardware address and instead require the kernel to generate a random IID for the IPv6 addresses. Signed-off-by: Sean Tranchetti Signed-off-by: Subash Abhinov Kasiviswanathan --- v1->v2: Yoshfuji suggested to update the I/G and G/L bit. Similar functionality is already implemented by addrconf_ifid_ip6tnl() so use it. --- drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 4 ++++ net/ipv6/addrconf.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c index cb02e1a..b9a7548 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c @@ -221,6 +221,10 @@ void rmnet_vnd_setup(struct net_device *rmnet_dev) rmnet_dev->needs_free_netdev = true; rmnet_dev->ethtool_ops = &rmnet_ethtool_ops; + + /* This perm addr will be used as interface identifier by IPv6 */ + rmnet_dev->addr_assign_type = NET_ADDR_RANDOM; + eth_random_addr(rmnet_dev->perm_addr); } /* Exposed API */ diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index f09afc2..5596d87 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2251,6 +2251,7 @@ static int ipv6_generate_eui64(u8 *eui, struct net_device *dev) return addrconf_ifid_ieee1394(eui, dev); case ARPHRD_TUNNEL6: case ARPHRD_IP6GRE: + case ARPHRD_RAWIP: return addrconf_ifid_ip6tnl(eui, dev); } return -1; @@ -3286,7 +3287,8 @@ static void addrconf_dev_config(struct net_device *dev) (dev->type != ARPHRD_IP6GRE) && (dev->type != ARPHRD_IPGRE) && (dev->type != ARPHRD_TUNNEL) && - (dev->type != ARPHRD_NONE)) { + (dev->type != ARPHRD_NONE) && + (dev->type != ARPHRD_RAWIP)) { /* Alas, we support only Ethernet autoconfiguration. */ return; }