From patchwork Tue May 22 11:16:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 918168 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dJcPgC0T"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qtRd3Yt5z9s70 for ; Tue, 22 May 2018 21:18:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbeEVLSD (ORCPT ); Tue, 22 May 2018 07:18:03 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35285 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbeEVLRq (ORCPT ); Tue, 22 May 2018 07:17:46 -0400 Received: by mail-wr0-f196.google.com with SMTP id i14-v6so19470427wre.2; Tue, 22 May 2018 04:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cSKMj9W6DJSc4fHv5T9AlYxLOMqiy/AAYBA0Vppbt2w=; b=dJcPgC0TrSeHntRtAQ0v2gFXh94xDoX+5+ja4KT/31sJlosYIEn+qswlq2uDxO+NJF HvKE4PCF5KMHS40tcvqsQVFTvWiZGUI2iHEaJgXgIrsG46761S8GRgZw8Umw6OJekNOC HR69n4q1VauiOfoZMQ0Je8yz4yf7MagaYsm9f3GoUnVdK6SwDl/Dtne/gJEHfMQM1kZl uS3Ws+VT1ZEcyzgzPyREJwmhjreM5NilRZgaEExUNVtXBR1pAPalrLYmBQ8HRfhKEkcZ XB6gPcc7sIcu4HiYB9BeNkSqD2Xd9/iF/RuPinxtkMGuYMA/VuYARoA5kH0EeSM/4+dv n/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cSKMj9W6DJSc4fHv5T9AlYxLOMqiy/AAYBA0Vppbt2w=; b=KiCV8PhUFYXQyYgLOLsxuzea9Bj0FtX3n7KnSwoEYP4ZBwqFKzRjSgFzFn5o8Thwsc kEpJY3t+N33D7St99sGzGZ9VO/mUTQOZhQrgEv8waGlvvDX0Sf5Jl5RY2TltaY0YidRV xgvdUt7/+qk58Xs1bcA+HDfQtmwhavkeh3bIPw631Pb/2e8Ay5E3TSHOOsJMmpSMURqA 2pPJ8qLtf5xyaktDsQOkMQzbS7jyIt6WCIhhpVxpK1aI0uj6XUYHJ1466KWKgubCn6zw wVk6dHhwOKGpmQvVmGmEuiWVywDIg1fmCLPTLij7sMJhPD0cMczUJgnxllKSppTKF7WT S5zw== X-Gm-Message-State: ALKqPwdpufmRL01aBTBgHnnGflCqs2juxmTBMJph4/b2Mf4uhZxY9Kwk VBfr/in645pneQBNLIHAJ3yh7AmO X-Google-Smtp-Source: AB8JxZrqe8VjMbm+CM5qZZZLRaXdybnn0mW3fOa4riMPUTT/zF921XlUGbE2aDw6cc5F1zyHA98ryA== X-Received: by 2002:adf:c709:: with SMTP id k9-v6mr5071306wrg.65.1526987864470; Tue, 22 May 2018 04:17:44 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id z2-v6sm15146747wmg.46.2018.05.22.04.17.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 May 2018 04:17:43 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net, michal.vokac@ysoft.com Subject: [PATCH net-next v2 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port Date: Tue, 22 May 2018 13:16:28 +0200 Message-Id: <1526987792-56861-4-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526987792-56861-1-git-send-email-michal.vokac@ysoft.com> References: <1526987792-56861-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When a port is brought up/down do not enable/disable only the TXMAC but the RXMAC as well. This is essential for the CPU port to work. Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family") Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes in v2: - Add "Fixes" tag as pointed out by Florian. - Add "Reviewed-by" tags from Andrew and Florian. drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 6a3ffb2..0d224f3 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -516,7 +516,7 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode) static void qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable) { - u32 mask = QCA8K_PORT_STATUS_TXMAC; + u32 mask = QCA8K_PORT_STATUS_TXMAC | QCA8K_PORT_STATUS_RXMAC; pr_debug("qca: port %i set status %i\n", port, enable);