| Message ID | 1524848820-42258-2-git-send-email-sridhar.samudrala@intel.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | Enable virtio_net to act as a standby for a passthru device | expand |
Fri, Apr 27, 2018 at 07:06:57PM CEST, sridhar.samudrala@intel.com wrote: >This feature bit can be used by hypervisor to indicate virtio_net device to >act as a standby for another device with the same MAC address. > >VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. > >Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> >--- > drivers/net/virtio_net.c | 2 +- > include/uapi/linux/virtio_net.h | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >index 3b5991734118..51a085b1a242 100644 >--- a/drivers/net/virtio_net.c >+++ b/drivers/net/virtio_net.c >@@ -2999,7 +2999,7 @@ static struct virtio_device_id id_table[] = { > VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \ > VIRTIO_NET_F_CTRL_MAC_ADDR, \ > VIRTIO_NET_F_MTU, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, \ >- VIRTIO_NET_F_SPEED_DUPLEX >+ VIRTIO_NET_F_SPEED_DUPLEX, VIRTIO_NET_F_STANDBY This is not part of current qemu master (head 6f0c4706b35dead265509115ddbd2a8d1af516c1) Were I can find the qemu code? Also, I think it makes sense to push HW (qemu HW in this case) first and only then the driver. > > static unsigned int features[] = { > VIRTNET_FEATURES, >diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h >index 5de6ed37695b..a3715a3224c1 100644 >--- a/include/uapi/linux/virtio_net.h >+++ b/include/uapi/linux/virtio_net.h >@@ -57,6 +57,9 @@ > * Steering */ > #define VIRTIO_NET_F_CTRL_MAC_ADDR 23 /* Set MAC address */ > >+#define VIRTIO_NET_F_STANDBY 62 /* Act as standby for another device >+ * with the same MAC. >+ */ > #define VIRTIO_NET_F_SPEED_DUPLEX 63 /* Device set linkspeed and duplex */ > > #ifndef VIRTIO_NET_NO_LEGACY >-- >2.14.3 >
Mon, Apr 30, 2018 at 04:47:03AM CEST, sridhar.samudrala@intel.com wrote: >On 4/28/2018 12:50 AM, Jiri Pirko wrote: >> Fri, Apr 27, 2018 at 07:06:57PM CEST,sridhar.samudrala@intel.com wrote: >> > This feature bit can be used by hypervisor to indicate virtio_net device to >> > act as a standby for another device with the same MAC address. >> > >> > VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. >> > >> > Signed-off-by: Sridhar Samudrala<sridhar.samudrala@intel.com> >> > --- >> > drivers/net/virtio_net.c | 2 +- >> > include/uapi/linux/virtio_net.h | 3 +++ >> > 2 files changed, 4 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >> > index 3b5991734118..51a085b1a242 100644 >> > --- a/drivers/net/virtio_net.c >> > +++ b/drivers/net/virtio_net.c >> > @@ -2999,7 +2999,7 @@ static struct virtio_device_id id_table[] = { >> > VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \ >> > VIRTIO_NET_F_CTRL_MAC_ADDR, \ >> > VIRTIO_NET_F_MTU, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, \ >> > - VIRTIO_NET_F_SPEED_DUPLEX >> > + VIRTIO_NET_F_SPEED_DUPLEX, VIRTIO_NET_F_STANDBY >> This is not part of current qemu master (head 6f0c4706b35dead265509115ddbd2a8d1af516c1) >> Were I can find the qemu code? >> >> Also, I think it makes sense to push HW (qemu HW in this case) first >> and only then the driver. > >I had sent qemu patch with a couple of earlier versions of this patchset. >Will include it when i send out v10. The point was, don't you want to push it to qemu first? Did you at least send RFC to qemu?
On 4/30/2018 12:03 AM, Jiri Pirko wrote: > Mon, Apr 30, 2018 at 04:47:03AM CEST, sridhar.samudrala@intel.com wrote: >> On 4/28/2018 12:50 AM, Jiri Pirko wrote: >>> Fri, Apr 27, 2018 at 07:06:57PM CEST,sridhar.samudrala@intel.com wrote: >>>> This feature bit can be used by hypervisor to indicate virtio_net device to >>>> act as a standby for another device with the same MAC address. >>>> >>>> VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. >>>> >>>> Signed-off-by: Sridhar Samudrala<sridhar.samudrala@intel.com> >>>> --- >>>> drivers/net/virtio_net.c | 2 +- >>>> include/uapi/linux/virtio_net.h | 3 +++ >>>> 2 files changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >>>> index 3b5991734118..51a085b1a242 100644 >>>> --- a/drivers/net/virtio_net.c >>>> +++ b/drivers/net/virtio_net.c >>>> @@ -2999,7 +2999,7 @@ static struct virtio_device_id id_table[] = { >>>> VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \ >>>> VIRTIO_NET_F_CTRL_MAC_ADDR, \ >>>> VIRTIO_NET_F_MTU, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, \ >>>> - VIRTIO_NET_F_SPEED_DUPLEX >>>> + VIRTIO_NET_F_SPEED_DUPLEX, VIRTIO_NET_F_STANDBY >>> This is not part of current qemu master (head 6f0c4706b35dead265509115ddbd2a8d1af516c1) >>> Were I can find the qemu code? >>> >>> Also, I think it makes sense to push HW (qemu HW in this case) first >>> and only then the driver. >> I had sent qemu patch with a couple of earlier versions of this patchset. >> Will include it when i send out v10. > The point was, don't you want to push it to qemu first? Did you at least > send RFC to qemu? Yes. Here is the link to the RFC patch. https://patchwork.ozlabs.org/patch/859521/
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 3b5991734118..51a085b1a242 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2999,7 +2999,7 @@ static struct virtio_device_id id_table[] = { VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \ VIRTIO_NET_F_CTRL_MAC_ADDR, \ VIRTIO_NET_F_MTU, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, \ - VIRTIO_NET_F_SPEED_DUPLEX + VIRTIO_NET_F_SPEED_DUPLEX, VIRTIO_NET_F_STANDBY static unsigned int features[] = { VIRTNET_FEATURES, diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h index 5de6ed37695b..a3715a3224c1 100644 --- a/include/uapi/linux/virtio_net.h +++ b/include/uapi/linux/virtio_net.h @@ -57,6 +57,9 @@ * Steering */ #define VIRTIO_NET_F_CTRL_MAC_ADDR 23 /* Set MAC address */ +#define VIRTIO_NET_F_STANDBY 62 /* Act as standby for another device + * with the same MAC. + */ #define VIRTIO_NET_F_SPEED_DUPLEX 63 /* Device set linkspeed and duplex */ #ifndef VIRTIO_NET_NO_LEGACY
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> --- drivers/net/virtio_net.c | 2 +- include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)