From patchwork Thu Mar 8 10:52:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadi Sharshevsky X-Patchwork-Id: 883053 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="MNOp3duD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zxnQz5x6hz9scM for ; Thu, 8 Mar 2018 21:52:43 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965622AbeCHKwl (ORCPT ); Thu, 8 Mar 2018 05:52:41 -0500 Received: from mail-eopbgr50085.outbound.protection.outlook.com ([40.107.5.85]:12511 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933352AbeCHKwj (ORCPT ); Thu, 8 Mar 2018 05:52:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5FO1jsaGwbhjBkFB+eNGnEXY4Owmob6SDj32wNcAzCk=; b=MNOp3duD5rnoVle3NOQly/1mM6q0+WXZgOaLfwot+Ysk6HxjArdfJs0wW3jtzWSzzrgBdiAXtmDht0Sbz/05E2DIpPSJo0woljKb2yKzU7zwKUQG8qRZOuayB5/GN/pF33indWBqcwtZAI/VsrDPWoar4gE3Hq+MaWoe2rFPCLg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=arkadis@mellanox.com; Received: from dev-r-vrt-156.mtr.labs.mlnx (37.142.13.130) by VI1PR0501MB2463.eurprd05.prod.outlook.com (2603:10a6:800:68::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Thu, 8 Mar 2018 10:52:34 +0000 From: Arkadi Sharshevsky To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, jiri@resnulli.us, Arkadi Sharshevsky Subject: [PATCH net-next] devlink: Change dpipe/resource get privileges Date: Thu, 8 Mar 2018 12:52:25 +0200 Message-Id: <1520506345-49285-1-git-send-email-arkadis@mellanox.com> X-Mailer: git-send-email 2.4.11 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR06CA0150.eurprd06.prod.outlook.com (2603:10a6:7:16::37) To VI1PR0501MB2463.eurprd05.prod.outlook.com (2603:10a6:800:68::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 89060b3b-f087-4b3f-7a67-08d584e2b397 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2463; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 3:oRSRgZ8a/YZKEUr/HbIobgE7VLLwQlOgFSAeeUra+0oNalPqS1E3hQVUr+Fl3tof5sSb7QxKEvpBWK2i+F2Eg/jB8SbLKyudm1W3IGguhvYXN46kY3VGv0M/gNH5sf1OCMZ4sw4jsFP5uOGHk+lIof6isjpI8OuG7YvtYfEZslYO2QXZIGuG1yw80gGvwxoAOCy26My4ObRj8WXKTssUUoBlJO1oYADmvid6/pKqdfrRQGIwR2tNZKctBEx0Uj7X; 25:pbaE47ZDsprGWzjmT7QABg5GcwwD8QbbnpgF0txJ97OBgQAcF3ZpsSN4sh1hZQfWnW17EnXyfr/rPQaFV7lj/C34M1I/2nr6uow2lxY9FxfV/dz//Po3P9/RJBO/waKkC29ahOe15qewB5sHWE72TMMbQYLAxao/NGkwLZreGePcy/4nNfpUH+qWNcgwv1/G/by/CNk/2w71evnmg0xKySxi/99M7mjHoI52mCzaLyb2Bwn4nWgMN1tMKLrkJQo1ffKMBsSIOfqFX8YTOL7xPROW0G87Q0K/N+vr+rLUPdWjXjPbzxsIx2qmkouRrqyWteiUFdMJoYRu62cvWy3QVw==; 31:Wp8gFNJkkIqz3cJR3kTLfM9Td/hMP4RPBZYMyeet/5Zc0LdX3XoY5hRd6MwLDRWcwH65Cn2qd9iTHhBZwfKN8FgFNI3dn4MZLOH/InKy8D71mLcJ4FVh19EhlzgUkl/8pK+0NigtKSw//huuPdlRmdiaZN+mJs+jBblxAPiXXF82Tsa8LhGw6y0VolpZ9C+gsHtFOnIAXXx1Khczdn7ejZ5SFjfGXKL5u6aInsPCPYY= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2463: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 20:vuPtWVy9RsETncmgsugC6smMQfaipPHQnMuX/Dfp4tY6yrB5kKA+q5zo685iJGzWRw173OBoFpyNIOXT8uMNMHD7luxroSJjs2nsJI6zql8wbBMRPOJtGvVAA87JkC69vs3pMHeVbJ7jrH4xjVPPukRdKIF6/ru/WoR9AhAkkxCxo4NCKWpTLP8f4mo2Z9fAT+vR/sNfRPdBxJ1nZi2Zaf/a1z0gryawzWlb2g0pQ3YW8HtsUuTlcwaRQ/zWcnjFyOxn1sUK3XLuWSXR2JBYOaWkwoswspJPp4tpnZN2jwUjh71GZQM9hN+lHTrLWQFnV1kLZA+XWoO0HpiBslHxU/kaQAEpphu86Z/EQDdXxp/m8PCtcES8/XAXnpVgf2fsAVzz+tvDKOkeKMSf3iGzeu9Qyj5cZPtJF3eXQUfYO7JpdFaSxpw3UgfLt4US0sVFsJ3uhII9UI/jzdxujbEU9/SKi55r6ipcQS34YmGYr176lU4MUVSCGysvbfIO9XAM; 4:sd7yBYbmBpVTRtmGBQkbp8GW1XxsE3Id20WPWjr+mdaDTI5lknc3MIQPR7I3rsze6rzPwu842u0h7bKsExh3Rv11m1Toyav9RHrZIO3hsC9CvIuF9j4fpRE+t/obfFmbp23t9N8rrNyvT8J1auR/2j4UMZpAea+IZGQ0og9FtygsWdiJ8LOBYcu6vjTehIe08TOURlI2CVYFXrJOGCwN3YRzEh0MM/dsBalau3d30xwR8GScTCLj4sB0nwkJ7oLq3C8enWs99DqWIyRMShUBew== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR0501MB2463; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2463; X-Forefront-PRVS: 060503E79B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(39860400002)(39380400002)(366004)(189003)(199004)(105586002)(81156014)(50466002)(48376002)(81166006)(51416003)(8676002)(2906002)(8936002)(5660300001)(68736007)(50226002)(6666003)(16526019)(86362001)(6506007)(97736004)(26005)(6916009)(186003)(386003)(106356001)(16586007)(316002)(47776003)(305945005)(107886003)(36756003)(6486002)(4326008)(7736002)(6512007)(3846002)(6116002)(53936002)(25786009)(2351001)(66066001)(2361001)(478600001)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2463; H:dev-r-vrt-156.mtr.labs.mlnx; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 23:X8NjhhDY34HOFv8BMTWDds4+A6hbe+Eyx6YwK36YSGV6VPllKIl3O1tda5qM+ON7Tdqe6O3QUsN6fLxNqxe+X5Yv68eE1M3831IP3pKIBaNU+s6svv9sFCpLbnth1PcYqT3D35wqJAktF46MWUNNaGKjwfVw1tlZMwgTS34pU7pyoU4LzKC3gG+DfG53eqvYD5j+MOs7+7DrNzdgsJEP/oQPbuyuFsje5+7U/KKDpf42a/ZcQHqVT9M/g2CwRrt8vRYJx8jneZJgpt0R41oZa21r/cgk8pU+ze9ksk+jqr+1l4xHLfirEDUsFswRaxyTYR262SZR2F28+kWBNI4xhsDPvzCQnGlsb/i6eHRDB05IkwkulkGy6QoegTWb3awGzDnhWGPerIL8ERQd7HoeXecNrDOlnlBzjtYC0WOq+8l6kw4TEUJGlDTPgYQn2NXW1vhNhUX6ROOnRoC0iZmHhSyUGUCTN3AC3HGjvEcV6O7ef3G6DIWaX5YELgnRKkaDYMu7+KT+Z/0a0I+pPvdpQ3XRV4s1Vbevf21bFQwmcRjGtJkqzpBUwGa15e6EquCButv5rkTbI07vIjGy9SWkbh9zwRKOnijcAz1NceXA7ppP3nc8uVbBKpEPfam5x6b77As7xLvUz3jLMf3nvOpJk32GbS5eTtJvFSssSyflicHXwsCyPdmN5ZqiQmFNNcOm4R8c3F+TQpv9em6jFC06MrULuxVgQGRLTZOjHvSj8sopQIyIqc+mQJ8i5VN22Y37iS+mH9dCTqLB4g4BbDiLPFt9PAaT3whJr9dyMg57KuzLdVFbqVYpDeGT1AGtRuI2Yt73BO8UgcFNybt58xkEBuifb6x49L6ml1b6zeCI3x8XoQzdMAO+1giXcbBe3qoTzYEmzhs28xKlHB8FoBO25pdrRC2XwjRR8Qf3hi5cfmoOLQtwK/ZsbQUxKFafbEkdKyMdGtZh1G+RFg1I1mNN05cGhJYvqAL8Bmi1PNoyXRoBKUvltHAbhBsoz8PXEr1j2F1NGkeVRmnJcPYSCP9EW3YNzk3+8tv1EJ+sai+X8cFn4+rYgZOO1QWY7Xuzvv8wuXD4thK4rc7/BvZW2/I1wv1yjMOrJnhjcN/EAgIkMy0= X-Microsoft-Antispam-Message-Info: /FJVNiPKdV8nhEgWOVlywxow4f8ukp0AbfdOypQZ3Pu0w6H8ePrIEzzrnIZW7PcSes6IyF4XXefFIUDP7uUabxIVZikjMMj7xDc8vGKN2uKMJcksCczkP2y3BAkBk0HA7oYFwKYfS9KD4dCzkMOTduay7YJMCLWluPqn/V6dUin7T4tsSDAvY7Vz/plUeUX+ X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 6:JXJiOwBzXscXIf2cz81mMu81hHrTL7wBWAGEJfpo8Gt4HfRiM05mR9AsxZsx+s7O6BHzvgG0wehe8hGmYNuOwf46D3+9GNg5JcYCS4WcJD1CS4K9OyFnjLuCX4I2+kRGSanTrijD3llwKAaPa3T3seI9ikhhZsBtmCTmtHlsMmMwdlUl+/6ug1Yds4AcljhP+LuNi6glxRNZqpvQRQQEKY1XfH6yo4oSyKqhxiIXARvB59O82UWAmC7Zci3jIuTH0SF/DXPvBL8P/EDkoWoRJswbkLP6+PgzoRDo9MuHzRVUaW109l5lGzKu6aT3VeAwo3xvXHp1YFGZOuzUnABRfesFenNYev4mlqZx7w1Is/g=; 5:eUl1OUvFdVx2FawQV1HdtlsX4CE+d/2gazEhdHgVKQhdgeudz4rCrR2VcwRNRFkT3wf/TIQif0Qz48PBgHnVm3CXUsOGQgi4YqKMgt0Kl2MmUHZV2/SXMDlCTfnyovB9XhwlwcIWUzKVKEFN7A43NT4Xi+8/lRuJm/mc45nycuU=; 24:Vcby9peEXyEjCKTpeuRaJwRp8PsgV+QTh9tdadLdn8Zx2wHHgP6IaQ3s3Y1DcgZ336/8Cxc1ms0t0U5q3SvLC8YIAPNj96ugq2VSIY1btrw=; 7:O5c+TMBgrCi5rtyRkWG/18jyN1aXvGYTEtl5VqSzUaOSI5uh/5MHnYTJK6AnnbKAXzJh/eGoT/pkE5y8KtxaPomgUI5aUM6Fn2W5vMs/okbR2UbNE0Qh98+VWH+64CCt1GspH1niyElED3bJpBEEXwDQVoH4nvBnPcrRRyjZTf6FyEzWcpSSHc8fgaJ+r65fKRhJ+PD4k9ftuF2zm5Cjh6IwIbgn/4xBR3zi8djQvopuqleo8R1acjg3LQ2mRkxO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2018 10:52:34.0817 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89060b3b-f087-4b3f-7a67-08d584e2b397 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2463 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Let dpipe/resource be retrieved by unprivileged users. Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko --- net/core/devlink.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 5bdc61e..f783ea9 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -2733,22 +2733,22 @@ static const struct genl_ops devlink_nl_ops[] = { .cmd = DEVLINK_CMD_DPIPE_TABLE_GET, .doit = devlink_nl_cmd_dpipe_table_get, .policy = devlink_nl_policy, - .flags = GENL_ADMIN_PERM, .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK, + /* can be retrieved by unprivileged users */ }, { .cmd = DEVLINK_CMD_DPIPE_ENTRIES_GET, .doit = devlink_nl_cmd_dpipe_entries_get, .policy = devlink_nl_policy, - .flags = GENL_ADMIN_PERM, .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK, + /* can be retrieved by unprivileged users */ }, { .cmd = DEVLINK_CMD_DPIPE_HEADERS_GET, .doit = devlink_nl_cmd_dpipe_headers_get, .policy = devlink_nl_policy, - .flags = GENL_ADMIN_PERM, .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK, + /* can be retrieved by unprivileged users */ }, { .cmd = DEVLINK_CMD_DPIPE_TABLE_COUNTERS_SET, @@ -2768,8 +2768,8 @@ static const struct genl_ops devlink_nl_ops[] = { .cmd = DEVLINK_CMD_RESOURCE_DUMP, .doit = devlink_nl_cmd_resource_dump, .policy = devlink_nl_policy, - .flags = GENL_ADMIN_PERM, .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK, + /* can be retrieved by unprivileged users */ }, { .cmd = DEVLINK_CMD_RELOAD,