From patchwork Thu Mar 1 05:25:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 879548 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ku83dEpI"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zsLX80nvlz9s23 for ; Thu, 1 Mar 2018 16:26:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966016AbeCAF0g (ORCPT ); Thu, 1 Mar 2018 00:26:36 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:55019 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965953AbeCAF0e (ORCPT ); Thu, 1 Mar 2018 00:26:34 -0500 Received: by mail-it0-f68.google.com with SMTP id c11so6249008ith.4; Wed, 28 Feb 2018 21:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ZgXk7KNon5xcepumWKU0PUgZlxmmd7WevzYxXXoDBH4=; b=ku83dEpIZCtuUjBIBd238mijZo9emmd45S4tvrlUu1H77XS2mi70GXSBiKvmS5GL4k 8NymqgZVMZfkQISWhbX33+uxgiIcnn5oexEhgUboQhJGBX9fitdMGRic4yG3KfCfHBYE qURoEkKmfZUtsrIyrx870Pn+LKc8TP9zGMVpuU4Up5spMLcMhL7K3LmNz12LeVZMNTEd 6PKyj6Fec0+/KsGtWFxyVR6BjFONx262dy0fAI8qOaCcdz5JlznUwXm3Mg5nEUkZ1XW5 LHBBdGAzvITlMx7bPiQ5uE3j9f8f4j/7RTBfQ5tUnjfBaBStXfFl0Zt6OZXeYTtQoUDl Bhjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZgXk7KNon5xcepumWKU0PUgZlxmmd7WevzYxXXoDBH4=; b=qCHijEo+jKZeZf27H98w9RxjFMH6dHwIzm1ts1/kvl56P8HrsqE9rErgBlwA4M0oWq BVToxUIPJozUDtKv8GeGB+UbMCt86m9huADPTj4iP6iOeu5yoFwSQHXPbp5IcU/sdGEH QxRI87Sg55EYZhLQOaGkoI0s5HIWDoX01Mh+sHVhPk5SBIR0e1z36fvJEWncLEFF+H1k bkcIuuSDm8+haoAACLlvbxxvsovZwxosDRX3bxpRqu4/Di0gCpy2ob7pdoZ7+mdPGvKd znYzUioqxfQE++0O9wzPtd3KCw78ch1kM6mkxuK4iGnySm8PN4kVh6snaTNZmeXGW1Ty ex1A== X-Gm-Message-State: APf1xPBZ33IFo5Z9rG2lZtqVjdYeo1aMy/W0ElmRDGmCWcaPVTPZjxMJ yBEF8ej4dIHBEiCeSnMfAExBJQ== X-Google-Smtp-Source: AG47ELs+MffQtFASV+aZOxXTBtY64FOHozlj8+s7z38SRPwjPFKd5VXHpGLm1ASDhmVVkkEInkVVMg== X-Received: by 10.36.37.69 with SMTP id g66mr1203642itg.45.1519881993901; Wed, 28 Feb 2018 21:26:33 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id g186sm11760029itg.2.2018.02.28.21.26.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Feb 2018 21:26:33 -0800 (PST) From: Arvind Yadav To: jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2] net: iucv: Free memory obtained by kzalloc Date: Thu, 1 Mar 2018 10:55:52 +0530 Message-Id: <1519881952-6663-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Free memory, if afiucv_iucv_init is not successful. So calling put_device() before kfree(). This will decrement the last reference. Signed-off-by: Arvind Yadav --- changes in v2: Calling put_device() before kfree(). net/iucv/af_iucv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 1e8cc7b..a07943f 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iucv.c @@ -2433,9 +2433,12 @@ static int afiucv_iucv_init(void) af_iucv_dev->driver = &af_iucv_driver; err = device_register(af_iucv_dev); if (err) - goto out_driver; + goto out_iucv_dev; return 0; +out_iucv_dev: + put_device(af_iucv_dev); + kfree(af_iucv_dev); out_driver: driver_unregister(&af_iucv_driver); out_iucv: