From patchwork Mon Feb 5 21:35:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 869586 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EKRJOOWX"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zb19c6pYqz9t2c for ; Tue, 6 Feb 2018 08:36:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbeBEVgD (ORCPT ); Mon, 5 Feb 2018 16:36:03 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:35305 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbeBEVfu (ORCPT ); Mon, 5 Feb 2018 16:35:50 -0500 Received: by mail-pl0-f65.google.com with SMTP id j19so12673611pll.2 for ; Mon, 05 Feb 2018 13:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=uUHF+B7PAl+oLxn7utX/gBTeTMqAMyk0p+oh5Sqi/sk=; b=EKRJOOWXntE4J8HrpA6M4N4f+k8YWE9zTcT34C4AB2GmDWk8ySlGDgi7X40/v046mN F9OBn20hvkxq9EP/QK/hyF17yv+CN5l8bF5hyaHCntZjQpPZFb8o6ZhBxrVVHesaCTzn M2SbA/ssTEor9EW66xUCDddst5jB3hlMcVk+W7LMuhp3ngLio3rE1gwKG/bKhpP1gM+p a++aMUgzCswdoqmM79X7u1uXaNC/9G4RogQeLOxWRc6zTlMS6yA1DKXj6EP1SaS3NJMO 9xfa321H/5CTA4hbmsxwDM7f0hkw+liqC5dbKrd+tZ0ucITN09kW8lHZFmtytSioPnww LqhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=uUHF+B7PAl+oLxn7utX/gBTeTMqAMyk0p+oh5Sqi/sk=; b=GM1ETqoZNEWwT3XM8/wIWFJux2T/h/SSywIIezefws8kBWE7Xp4TzOUkTOfIAN3lqc gl1jj8uT3/n1FBFgc1BhCP82CAumNxLp7BJJ+T4qD1Suus26f7j3KuzoUxiiSEgEGzkj zPn8H7ubcUDgG1U5jBhWvewlNbfyHpHlsiFhunuzVhvaC3JL1j++6fnox6yO8ZeuNrUY fGZLtoIF3Wv+VwQ2z/H8AUT8/1HJFNeyKiJ8v2kFrXJVO4zRFXngkR5btaejIxSFUVSJ M8sVBSIpcGruW7HFIuUg07IVkV7D8TPy3vbRCywfX6s2N8PY0ncy93i90bgGIEDlnFwP YckA== X-Gm-Message-State: APf1xPDQqfvJOKxFvRg91qGnkFfhw7HZLCb0gYT2Fa9jgBP2VTlmeZzP pH9Z/y6APXmveGo6SnCOyS31BNJD X-Google-Smtp-Source: AH8x226J1ckjys+B1oNcR0jNfyoSwJ+qaG1kHR/RWXq8Y2XOSv9qUqM+n6NxSW9rmMXkCIV0fNCsrg== X-Received: by 2002:a17:902:3083:: with SMTP id v3-v6mr186663plb.426.1517866549725; Mon, 05 Feb 2018 13:35:49 -0800 (PST) Received: from sc9-mailhost3.vmware.com ([208.91.2.2]) by smtp.gmail.com with ESMTPSA id z19sm20136110pff.3.2018.02.05.13.35.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Feb 2018 13:35:49 -0800 (PST) From: William Tu To: netdev@vger.kernel.org Subject: [PATCH net 1/3] net: erspan: fix metadata extraction Date: Mon, 5 Feb 2018 13:35:34 -0800 Message-Id: <1517866536-69908-2-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517866536-69908-1-git-send-email-u9012063@gmail.com> References: <1517866536-69908-1-git-send-email-u9012063@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Commit d350a823020e ("net: erspan: create erspan metadata uapi header") moves the erspan 'version' in front of the 'struct erspan_md2' for later extensibility reason. This breaks the existing erspan metadata extraction code because the erspan_md2 then has a 4-byte offset to between the erspan_metadata and erspan_base_hdr. This patch fixes it. Fixes: 1a66a836da63 ("gre: add collect_md mode to ERSPAN tunnel") Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode") Fixes: 1d7e2ed22f8d ("net: erspan: refactor existing erspan code") Signed-off-by: William Tu --- include/net/erspan.h | 26 +++++++++++++------------- net/ipv4/ip_gre.c | 5 ++++- net/ipv6/ip6_gre.c | 6 ++++-- 3 files changed, 21 insertions(+), 16 deletions(-) diff --git a/include/net/erspan.h b/include/net/erspan.h index 5daa4866412b..d044aa60cc76 100644 --- a/include/net/erspan.h +++ b/include/net/erspan.h @@ -159,13 +159,13 @@ static inline void erspan_build_header(struct sk_buff *skb, struct ethhdr *eth = (struct ethhdr *)skb->data; enum erspan_encap_type enc_type; struct erspan_base_hdr *ershdr; - struct erspan_metadata *ersmd; struct qtag_prefix { __be16 eth_type; __be16 tci; } *qp; u16 vlan_tci = 0; u8 tos; + __be32 *idx; tos = is_ipv4 ? ip_hdr(skb)->tos : (ipv6_hdr(skb)->priority << 4) + @@ -195,8 +195,8 @@ static inline void erspan_build_header(struct sk_buff *skb, set_session_id(ershdr, id); /* Build metadata */ - ersmd = (struct erspan_metadata *)(ershdr + 1); - ersmd->u.index = htonl(index & INDEX_MASK); + idx = (__be32 *)(ershdr + 1); + *idx = htonl(index & INDEX_MASK); } /* ERSPAN GRA: timestamp granularity @@ -225,7 +225,7 @@ static inline void erspan_build_header_v2(struct sk_buff *skb, { struct ethhdr *eth = (struct ethhdr *)skb->data; struct erspan_base_hdr *ershdr; - struct erspan_metadata *md; + struct erspan_md2 *md2; struct qtag_prefix { __be16 eth_type; __be16 tci; @@ -261,15 +261,15 @@ static inline void erspan_build_header_v2(struct sk_buff *skb, set_session_id(ershdr, id); /* Build metadata */ - md = (struct erspan_metadata *)(ershdr + 1); - md->u.md2.timestamp = erspan_get_timestamp(); - md->u.md2.sgt = htons(sgt); - md->u.md2.p = 1; - md->u.md2.ft = 0; - md->u.md2.dir = direction; - md->u.md2.gra = gra; - md->u.md2.o = 0; - set_hwid(&md->u.md2, hwid); + md2 = (struct erspan_md2 *)(ershdr + 1); + md2->timestamp = erspan_get_timestamp(); + md2->sgt = htons(sgt); + md2->p = 1; + md2->ft = 0; + md2->dir = direction; + md2->gra = gra; + md2->o = 0; + set_hwid(md2, hwid); } #endif diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 6ec670fbbbdd..9b50eddd1882 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -261,6 +261,7 @@ static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi, struct ip_tunnel_net *itn; struct ip_tunnel *tunnel; const struct iphdr *iph; + struct erspan_md2 *md2; int ver; int len; @@ -313,8 +314,10 @@ static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi, return PACKET_REJECT; md = ip_tunnel_info_opts(&tun_dst->u.tun_info); - memcpy(md, pkt_md, sizeof(*md)); md->version = ver; + md2 = &md->u.md2; + memcpy(md2, pkt_md, ver == 1 ? ERSPAN_V1_MDSIZE : + ERSPAN_V2_MDSIZE); info = &tun_dst->u.tun_info; info->key.tun_flags |= TUNNEL_ERSPAN_OPT; diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 05f070e123e4..50913dbd0612 100644 --- a/net/ipv6/ip6_gre.c +++ b/net/ipv6/ip6_gre.c @@ -505,6 +505,7 @@ static int ip6erspan_rcv(struct sk_buff *skb, int gre_hdr_len, struct erspan_base_hdr *ershdr; struct erspan_metadata *pkt_md; const struct ipv6hdr *ipv6h; + struct erspan_md2 *md2; struct ip6_tnl *tunnel; u8 ver; @@ -551,9 +552,10 @@ static int ip6erspan_rcv(struct sk_buff *skb, int gre_hdr_len, info = &tun_dst->u.tun_info; md = ip_tunnel_info_opts(info); - - memcpy(md, pkt_md, sizeof(*md)); md->version = ver; + md2 = &md->u.md2; + memcpy(md2, pkt_md, ver == 1 ? ERSPAN_V1_MDSIZE : + ERSPAN_V2_MDSIZE); info->key.tun_flags |= TUNNEL_ERSPAN_OPT; info->options_len = sizeof(*md);