From patchwork Wed Jan 17 13:28:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadi Sharshevsky X-Patchwork-Id: 862263 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="GfZrF6Cp"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zM7H22cXxz9sQm for ; Thu, 18 Jan 2018 00:29:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753009AbeAQN3c (ORCPT ); Wed, 17 Jan 2018 08:29:32 -0500 Received: from mail-eopbgr20052.outbound.protection.outlook.com ([40.107.2.52]:17164 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752488AbeAQN3a (ORCPT ); Wed, 17 Jan 2018 08:29:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vBu6GnGyXgxF6oMAUh8VyZFmMuSXzvsIeZI/M0BFX1M=; b=GfZrF6CpCoh0/8hqBl1fHhtq1hjaV48K38C9sXhK0jiZzM/VTOcslH5XmBELZtWhiWJsa+JDc/lMK2NTap6q941qVmng4NXRqMMBsmAGtqVYz8afU+fhYa146q4NZj0lm285v8Whq6UfujbaFNdGxLn4Zpt3dYQcxWA4wZb3SNs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=arkadis@mellanox.com; Received: from dev-r-vrt-156.mtr.labs.mlnx (37.142.13.130) by HE1PR0501MB2457.eurprd05.prod.outlook.com (2603:10a6:3:6c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 17 Jan 2018 13:29:25 +0000 From: Arkadi Sharshevsky To: netdev@vger.kernel.org Cc: davem@davemloft.net, stephen@networkplumber.org, mlxsw@mellanox.com, Arkadi Sharshevsky Subject: [PATCH iproute2] devlink: Ignore unknown attributes Date: Wed, 17 Jan 2018 15:28:00 +0200 Message-Id: <1516195680-33683-1-git-send-email-arkadis@mellanox.com> X-Mailer: git-send-email 2.4.11 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0701CA0071.eurprd07.prod.outlook.com (2603:10a6:800:5f::33) To HE1PR0501MB2457.eurprd05.prod.outlook.com (2603:10a6:3:6c::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e977d6a4-d94f-47e7-eaf2-08d55dae5478 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0501MB2457; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2457; 3:s7RcAMBiNS0Ml8NFxyJF/LsS7Sj8IFAd0gEV5EH9qLLZaoxCWQlGSUk4RifxJzi6QDOlXj+xUCqtM+hsqCftK+/eQH4qDl5vJRqtHQa0wCj3DBPiXYi/Pi2xuzJ/eOerLVwQNJXEqBR1H2QZv4vgY9Ce2yLhYw01AZpAe566ovZ9fGD5kmS5dcir4KFalKTxrfGW/xE0fX7aZWovDIyx7f6z1ehAGJeOAtfe4fPhe3tMXWrN6X+Sae1qTDNr/E6g; 25:Zk6EOVTEr13dAR4Lv+nyVpKfnCY4Vb5OnK07n/4Me3WTCW1Cuz0I+YUupc137dYo+3J27zhfXxgePZ6s+3P2fNbyZWONsiOqXGaPH4oCV7Y7JOpn3nLuhtp+5dtb1C0VC+28YjUQm4MNNlY2Qv/QDpmYPRvkrSitMiiwWhGmhcyVH4QxL0HFanIJfiIG8hZv3wK4Y/XElDpxweSfxDtnXE9OIDGgdc37aHyDC/eYvoL3x4C7AKOXKblTYRqcbDcj94BuEgu/cX42DXw3PF2SSmT6HyrZWv9/O7zwD8urX6ZqvMCbUA58ecA46UGWJW5FN6FVbTeU8Iuq2iexvCWyoQ==; 31:BJxm3RNS849kK5nNM/I5hQHk43ud7k9N84TH83+x8165owHjjX3GbwxFfEBKOwb8+KZaiaQ4FuXvtdFZk2CAzx92ei3Aigz/cIJ0Ro2ROeGxitetpaXufrPcSQILGS7IbtBlmD3Gl6Qlqrec3mzw3qb6s6xdAPYwjSXrQp0Iajz0jzds/IJON1DxiUmukwBhSPbThEGL3S/7vQpZY79rEZ75uDQDvsZg3xhWxyI7iFo= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2457: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2457; 20:JiOggfvlvgZts1BO087o5lZEU2XRwfLM0BxY7LtOGoe2RonAYl+uHnmTuoi2y4HFGA326xlFXg1GaEu4HLxNn9AqoJ1LO1q1vdeE4n1uQPEzobs6Z0SLCrINQcRRna8tJ2g0cB1FCMjpXOsD+QrNjKLsMTSNv8i26mVdmNmqZe4D830oOPH5uGqJKiKv0zqF4AN8zqGiaB1FVVFISSRoYc6hoKqyXrU/QnVTXVRJYlxG5ETBcR7SmBZgWzu5OrdRs7jfl1OALLz1FbjtQ5+8QhkA+8aBF4Hr6IWyIr4sGvKs0wMBj2uxA6cSLELEeA1zaGSlcLbNA1FJpWgLgXLI+d+SYwcQZc4C1f6nkKVqx7QOmMtUBe2Mr9xg+fA+bSJ+vkNoFMg8DYdhyexlea1qjfoLxR8a+Ag+mvX/rbxqzExprhVchYtQvlSx54jI99jogpr96VbUXzVnj2gY5VXNDFv+LbwGO7ii268v0H5Pm44wEX1Vl2YrOJbU/CubA1VU; 4:ur8uumnXcz0jHj37Lw3xTa9vG8aA6RMiFmKa3x3cqqePe36sE2hHh9dVc9jxIB8XcUVk7BzpwveEQ8B/uDNuCTDLKKHUnWbrvCwsxSVTTW1h2Jm6O5c7WTZH01+wZTAIoEcQSjOgu+GG23evuHf5HCWVybPd+9I9A1VD2OMXErmAKRptEETPrXbmz+mOqvB3ddI84/+/nwaZ5fRdA1uE8S7Q/BKCCb/XEaUlvZh5EsXnjQCek3eA6o0NKpjqNvTyvN3pqW3K1A4R/BXC9qxxLw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231023)(944501161)(10201501046)(6055026)(6041268)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0501MB2457; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0501MB2457; X-Forefront-PRVS: 0555EC8317 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(346002)(39860400002)(39380400002)(199004)(189003)(81156014)(105586002)(107886003)(2361001)(86362001)(66066001)(2351001)(16526018)(97736004)(316002)(16586007)(68736007)(8676002)(81166006)(4326008)(106356001)(50466002)(6512007)(25786009)(50226002)(36756003)(8936002)(48376002)(51416003)(6506007)(47776003)(6916009)(305945005)(478600001)(59450400001)(386003)(6116002)(53936002)(2906002)(5660300001)(26005)(52116002)(7736002)(6666003)(3846002)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2457; H:dev-r-vrt-156.mtr.labs.mlnx; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2457; 23:78srGRoNTnAQzNXJXghaS7SsQUvITcykZ2WXiNHAW0R0F5FzjbZ9pkPEtiRphrESPVi1+pnB64YLUucAWxwtprodLRNCw+bbYWi8wrIpAlob8fpgvBLDHAg+NMrJnz0YMytd3heva0h7OKIZpS2HNVcsHR9pMEGWkqlvDilaWul0xL/aPZ+MVrXSYEwvWZp/kBlE4e657+ST4WSTQs7gPPVQ4CEOqm8aKi5JRsxTbvhEMhMBunB9EiGiVWVXT40b/1B/PSV0uVR0ljLV+YQON0vL+2jKkEhvlDO4Fb59pGS1W2E1FVD2mrAYGpM0MlG2aVWl520FZfSQrELw2EVtncRWfwPUfSfOqlbUgRSdI3x0oTRZOFYEZvh0bxrvrUGnO28klsKJwMGNRNZ8LltEkWqhqYsOAdNblhUx3EANixLJzS0CfI1KZpblMxUJKf/WJmXaDaWoJDsWRZE8Ny19KAkiZBwPscPGcWwMbtCg5O3oCM0rlcw8FN3eevoREu6IJFgXZzY4sKFQiyC9rTN6GvxMaVYbWF8vDOlHtF8fO4QbIwPeQ3AeJeopG/hz6Mo35VKagXC+mehxnx42I9arkAqNPuxxwNKj/wBYT+rsLAxuIQd/uvyxBdFO0LfWNOElip+aaJDA+uXi9coiCVmaBlJnTcRmGftus67QZVBYZF3xwtMubsVsySeLY29iYUb0trPhtoBin1aZFbr603x3x/M0o2wYerMBDc9JEIL+Lf59NhXc0kP97+EYZmSQlb9U67wsGyV/qU6eLLbFEj8HpRMiE7Urzvf2m5mHX+PR4rviCs5RUz80jenn7lNtGtAbiLsrd5iUdm0Vl/mdhUQ14LJMCfcUFfvcCw1NzQxRi4TKlbQU2JqwPyykZkuMLwtMNXzR4V22nAzShTW1pEnvDGgGZjAEZL2PtMdjYlA663LyeaD/HWRkeN1ES0eEbrB3iS43byetBEjITTCbJEEH4y1qZUxs+HlMnmzzcAJtAE1IVI8MMXa7J45tDtcp653cacGi7XT5uIJLT0ewMdbyPstJ9xFyZdO2Bnp37yp43Df6qdZcqZeG6uc4XMIwBPSFYcE7o+3uEIkl9mzkD5kVVw7Tm2tvkQBCuid+zv0e1w0= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2457; 6:no1B5rw46JXYF4diJaQQBJyhgxR37OIAO343HkjjSes/YijZX5LhI4NcP3roqaRnhCU5340yDKG1NBaMGcfu/f8vndHszXNOIYjglLKnGVIqT1ZgdRWjO2WX4QOvB7EWu/9ZVfSBUUZHC65bpDj5qWK6saBEtyrML2JC7uY5ZoNUvAB2fDxs0hejvYVpULeGWhE6E/TJx9iDXwa/lBqC+GPFAbsfrAP/N6biU1MYU8MCKs2ayEQALw7FJWrxtaq7M5WOlXBHaPB/+XmEzzPbhlDm1rzaWFZYrvO+M7/MyZYQwCB2iwDGw/1qGZulWwdr4IpinebuuRKMa8k0/cIFM4JtgbuY4N7fSoj6gP2DCKs=; 5:H0fCeCAOj4scMnCOuz1nrA5J5fUKtdZdWnFFltySh+/u8ohgUzHTCFwFtq9coV9eCBodimhqKvPNcXozZq47wfsaY6cHQ2dE0sfKEOuwt4iaBEa07iSWMwPIM+2B1JP4qibqml3hWldqElbg5USRzJqX1yEiG4YwHlKulL0Zoh8=; 24:Xvi5mgZC7Tn44hC2PMGUZqjPgik9RQovI7PTbY5HacqIf5aOYmKyQ/jKVqajdQ4RJmPT2o2LuKQ5r7unEuEBWwQTVz2QnZQPs5vS/XX6uUE=; 7:+Q5M1TplAjUa78EIUF8AvW3ajNZaveGCF5YeUvjXixgd5XZHYMgrgeGGUKfbf41Y4AQHsF81OJK5v2j6dY066t65aEg92pPy71IcxBQNzToQVt7H6bNuOX4ydeSAEFGqF0zkcDbMPdfvXJ0JURebhjwQoq7nwlls7Zh8yYcclxJ8RhUuBpJfBZb9dIeX4JpnQrgT26Xe6n5cH7YgUv5a1/MRZdf8Kb4ZEHPycTMM1xq0pxjKijteD4a37ODNd1s8 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2018 13:29:25.7258 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e977d6a4-d94f-47e7-eaf2-08d55dae5478 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2457 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case of extending the UAPI old packages would break. Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 39cda06..c9d1838 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -343,7 +343,7 @@ static int attr_cb(const struct nlattr *attr, void *data) int type; if (mnl_attr_type_valid(attr, DEVLINK_ATTR_MAX) < 0) - return MNL_CB_ERROR; + return MNL_CB_OK; type = mnl_attr_get_type(attr); if (mnl_attr_validate(attr, devlink_policy[type]) < 0)