| Message ID | 1514128239-2331-1-git-send-email-laoar.shao@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2,net-next] net/trace: fix printk format in inet_sock_set_state | expand |
From: Yafang Shao <laoar.shao@gmail.com> Date: Sun, 24 Dec 2017 23:10:39 +0800 > There's a space character missed in the printk messages. > > Put the message into one line could simplify searching for > the messages in the kernel source. > > Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint with > inet_sock_set_state tracepoint") Please do not break up long "Fixes: " tag lines, for the same reason you shouldn't break up long kernel log message and trace message strings. I fixed it this time. > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Applied.
diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h index 3b9094a..3537c5f 100644 --- a/include/trace/events/sock.h +++ b/include/trace/events/sock.h @@ -160,8 +160,7 @@ } ), - TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4" - "saddrv6=%pI6c daddrv6=%pI6c oldstate=%s newstate=%s", + TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c oldstate=%s newstate=%s", show_inet_protocol_name(__entry->protocol), __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
There's a space character missed in the printk messages. Put the message into one line could simplify searching for the messages in the kernel source. Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint") Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: Yafang Shao <laoar.shao@gmail.com> --- include/trace/events/sock.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.8.3.1