From patchwork Mon Dec 4 17:48:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844342 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EMNoFKMG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC743Bs0z9t16 for ; Tue, 5 Dec 2017 04:49:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbdLDRtJ (ORCPT ); Mon, 4 Dec 2017 12:49:09 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35755 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbdLDRtD (ORCPT ); Mon, 4 Dec 2017 12:49:03 -0500 Received: by mail-pf0-f194.google.com with SMTP id j124so9073122pfc.2; Mon, 04 Dec 2017 09:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8rqQr8sXhlG0r+Vj07MdtxMVsMkG4hAOsts65oR12C4=; b=EMNoFKMG3WxChuquar0MmhTNFWu46+DVDFMiadVUIOWyoPA7RCNWSB/HKEDoa8hSDW pWarcjjYNdvBqCdqxe585lbzFNuhX0GyF/C4n5wEBwBvd/BgG6s9PiruTzXOJRmitGIa dZyN46VqOZXNBMe5cReqoO4DGwQckLQd+7BUBhJaPfZBt+R+zo3HA48rH/80VWb3Poh4 5OXZu1n/i0sVxiZVA+XaiG+wa2C3Hxl8aAc+CcRLCjRq5oc5VtyBJqHacxYW82YgIamJ PQm/exkT72ILnyeu8CLboZYkjnVfpQ6/Qhl5qL9U3C06jjsJUh9SZe5h1jcBOHWr3ckO Z5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8rqQr8sXhlG0r+Vj07MdtxMVsMkG4hAOsts65oR12C4=; b=W2GfcVCIbmxcK1oC/XevPbQkO6S471YJL+aMorMZAGr0aFlWdALUT4/1/E0a99Z/or 4ghVl2R5tcc8krj8hC0dSwAlRZ5QTqMGlV8PL5fbWLLho+S7dIPVXI3oWf1hiT3jqUDa aoPxKaB9eoufJrpg0w8eW8H23UB3uRRrKyq1bh2bjgHQVoCJShTYCV6ZkPmeSN2/AeGJ 0ifJmTMj4G+TMltKcGgZVeqZM3ViJai83TXnNFxQ0oHrBbCy2npAQ93J7os+HwyESRrR veVY75PRUcl6Bbn54an8V7mhfAqbsskbseJucExRX5BSZyFE1WGFt0IxvIRJWPgoYYh5 JptA== X-Gm-Message-State: AJaThX6A/F3pp8NWw1PpTlZ02EORNB3QgpQscIx3ARywF9vOwKkgahYQ IU9X/61F4tDiMFzXwmOnsR8= X-Google-Smtp-Source: AGs4zMZiiiXmWsIZWwjeYh1Eedo+YhWsaub3K2CwEpG3A9i6CyA27QTLAypFOQ4CMiJfzB8HQwUi9w== X-Received: by 10.98.150.221 with SMTP id s90mr19957679pfk.151.1512409742857; Mon, 04 Dec 2017 09:49:02 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.49.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:49:02 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 7/7 v2] net: fjes: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:23 +0530 Message-Id: <1512409703-20881-8-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/fjes/fjes_main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 750954b..af7204b 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1268,6 +1268,11 @@ static int fjes_probe(struct platform_device *plat_dev) hw->hw_res.start = res->start; hw->hw_res.size = resource_size(res); hw->hw_res.irq = platform_get_irq(plat_dev, 0); + if (hw->hw_res.irq <= 0) { + err = hw->hw_res.irq ? hw->hw_res.irq : -ENODEV; + goto err_free_netdev; + } + err = fjes_hw_init(&adapter->hw); if (err) goto err_free_netdev;