From patchwork Mon Dec 4 17:48:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844344 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WCgxRhPf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC7c2L5zz9t16 for ; Tue, 5 Dec 2017 04:49:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbdLDRtj (ORCPT ); Mon, 4 Dec 2017 12:49:39 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38046 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdLDRtA (ORCPT ); Mon, 4 Dec 2017 12:49:00 -0500 Received: by mail-pf0-f195.google.com with SMTP id u25so9064587pfg.5; Mon, 04 Dec 2017 09:49:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LWu3LD/6qgRdIa3DnmTL6kI3hmvkfcjPZM7Zc5irb+U=; b=WCgxRhPfgd7dwtzpk9EA8f+N2M2IIjJI3JI6sxW7W+2/kYr/BMD+e05Clm6o4uP42m Uh8N6RXzGSbenqqx9S5KvJ0F5WFmq4lvc1CetFlfvN1i3ynHfPbwehzjbR6xeijCjiZ5 IwK3BnodAC04EUH3UOGlFZ31rCmiij4JnC+02W42Tvyycr5edUabVmSPg8CKdRDO6+Ve YGVYGMRgv/QvKASkVuj6UssQz7MFVIfglHySsA/fG9eKDpSJO3z5Df8FrjDZ7rPnqf5a BrxcVksj82lGjdUoVzP7hK6kqhiV/pCWTFaqW0qfBY0z570LQhWB2CwEm7aRUrnDxQAi F92w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LWu3LD/6qgRdIa3DnmTL6kI3hmvkfcjPZM7Zc5irb+U=; b=Z2GcQC4qptMfS1Q+UDZRj1TZC575au0x2rpfkAsDWM+Cv4n11KUU91dK0nP92NBQRA 7/Py30y21Id5aPSTsEse93tHJ1rhxMuHus+VdgzsE5vJX+Sn9D09zGaqNSyEXKlKVght rdPneSrYzppBcisFkmb7rl8Me3QSZ09tiEKxjsrdo8Gh/6L5kHEAzULYLTFRpFL7lfkh wSDB+d3ftbJJy1mzvL6VgESvYzQHwmEaKAf6E6W7v08Vd1e40DTJzq6W/d8TxuNl6yG2 ihIDjU2HLh/UtIpsUx0DcS89C7SMNQoIdVf+0r5C08lihpSuztNws5D54Z2r4HS2TZ3Q Wb5w== X-Gm-Message-State: AJaThX6trh7aUkzqWhLFQgUBExUNTxR7UJC/EqKQyha5WFHgI6rvp4a5 z7YZhx+5M5sMzUm0VUdj6d0= X-Google-Smtp-Source: AGs4zMZc9Gn8ec5J5uVcdlrDA9/ZQQyVc3uOioJPDp30b5kJIsSHvwWB6oH3SJZkbnrUziaWUiDf4g== X-Received: by 10.101.70.11 with SMTP id v11mr14545199pgq.306.1512409739791; Mon, 04 Dec 2017 09:48:59 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:59 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 6/7 v2] net: ethernet: smsc: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:22 +0530 Message-Id: <1512409703-20881-7-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/smsc/smc911x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 0515744..5e3c7af 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -2088,6 +2088,11 @@ static int smc911x_drv_probe(struct platform_device *pdev) ndev->dma = (unsigned char)-1; ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto release_both; + } + lp = netdev_priv(ndev); lp->netdev = ndev; #ifdef SMC_DYNAMIC_BUS_CONFIG