From patchwork Mon Dec 4 17:48:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844343 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KB3nAaM7"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC7H53gvz9sPt for ; Tue, 5 Dec 2017 04:49:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667AbdLDRtC (ORCPT ); Mon, 4 Dec 2017 12:49:02 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:45571 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598AbdLDRs5 (ORCPT ); Mon, 4 Dec 2017 12:48:57 -0500 Received: by mail-pg0-f65.google.com with SMTP id m25so8684382pgv.12; Mon, 04 Dec 2017 09:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sHfA+6F9vTHh2ekUViwDNjHWbMbNHM/vAfW6Ho/GIRI=; b=KB3nAaM7wfUj17nAeZRB57lEUMfALzC93NqA7G5MM6FWlWxY7lC+4HYFW3STUD1w7E lsOsQZcx30G7JKmz7INuELSuSRuywi1C0AjytiX3C03bo+sFobZyBjHuVKOIOvmRKiYG Aw6hJLlPc35TVsNGx5IfuCQjgkBm3R767ji6/YnJtIYbcwf8v7LbqRfS5pl3jIFxLUpD nKyZFZcJyfee1oYOmjHvm+k8/bNNe5OniiZNDwn5C1kayU/aFeAjC+gJzIW0oHL/bsKq NK5ft5xWKy30GrbMVqVlS0Gzmz1EdYRrj/mgOR9D+B1foGeNa22lx/ladzqp1V/cS20M M5dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sHfA+6F9vTHh2ekUViwDNjHWbMbNHM/vAfW6Ho/GIRI=; b=qnwMmQ4Q+l5l79wZCb2vTfeyz73TWu0NCHM36TnFwyAXZZeIo07vy74Jx05xVLE8bb IkfJstWvMXrDWT8i4SBjntD2BqVpePyqY0czpqxMAdcpKKG5Mrq6liWieUb3Av94uLyy e6i9aCK+lj+cpiUMisokUnzdYfRL4wyrdPcJ2PDkcfrKn0wxsBi3IH+i6EmP6rwBG1H/ VOtCAVSb5JiTkkrSJHj0nXyv5ZFt+j+YLTuM9f87Ve88Ku3vrUoF4OBCxO/pSmkJOISR sjO7m8DkBtkfDI/n1EhulTHJr1wf93SpJhwJwdzUpgxcp7sSxI4TVOT6aLyQqGRkbPoL Qtfw== X-Gm-Message-State: AKGB3mLN5se7Nl1FhPY8Emaa8QAdLqeOOTLh9no2GlryZsQK48r8vo7k Ja9oUQUMOgOKhdtSOuHjkCo= X-Google-Smtp-Source: AGs4zMb2aOrbpcGixz4hDfyFJf+4C0yL0qT82NXiyLM3LpjI9H7KkX81zB8nxRqRRhq5o36Tw4zP4A== X-Received: by 10.99.171.69 with SMTP id k5mr3999988pgp.229.1512409736687; Mon, 04 Dec 2017 09:48:56 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:56 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 5/7 v2] net: ethernet: natsemi: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:21 +0530 Message-Id: <1512409703-20881-6-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/natsemi/jazzsonic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c index d5b2888..22424e9 100644 --- a/drivers/net/ethernet/natsemi/jazzsonic.c +++ b/drivers/net/ethernet/natsemi/jazzsonic.c @@ -242,6 +242,11 @@ static int jazz_sonic_probe(struct platform_device *pdev) dev->base_addr = res->start; dev->irq = platform_get_irq(pdev, 0); + if (dev->irq <= 0) { + err = dev->irq ? dev->irq : -ENODEV; + goto out; + } + err = sonic_probe1(dev); if (err) goto out;