From patchwork Mon Dec 4 17:48:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844347 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XRBPQyjv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC8N3yndz9t3w for ; Tue, 5 Dec 2017 04:50:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbdLDRuQ (ORCPT ); Mon, 4 Dec 2017 12:50:16 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32808 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbdLDRsy (ORCPT ); Mon, 4 Dec 2017 12:48:54 -0500 Received: by mail-pf0-f195.google.com with SMTP id y89so9072246pfk.0; Mon, 04 Dec 2017 09:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HVtnnuyOvyE8ocsPzZGR4MSoo1SDTNoQYRipMRHSScM=; b=XRBPQyjv9XSUMvr8x6hqq+ILMIswANxPD/oczkSwER0wumCb2iljcgvuzTsL9OH1Wo tXdeMfiJCoqI15resNtCAGXTY6f/uiiOlb5oXGzAnUGWSmKtVh6PttWUdtbZaMfJGzKz 4mxzpXNYmlOh6Md9MDTSZwF1TqsrKx3IfnHO8qwQrrooBACRIYHXhhJmQV8Y1MX4WgJO xENlNxCOxfxQfPdKCBleeKYpMmHgowtdX6oJjNYSi6eJe+sxBq8YivRYxpIH1dcboDep vamkVrmhV+iDE2WF4IiUfRjgjul1pxc4dqXCURdkA0ePD8RjY/ve9/KkeNBN0MjnRQRG zgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HVtnnuyOvyE8ocsPzZGR4MSoo1SDTNoQYRipMRHSScM=; b=M6o6+H5dH7ScNSeUfTFD3tDNK11Z88MB4+9rohLT6VqpoJftGkTL1zDXdre8ADH4ps PSUA9KD1qrUwjfAX5T8UYwG9ILX7E7JBLK2rZNI5sYBgFOWcT1GfedRuwPgtAY3SNnRs 8xH8Om1xo8gBvkJ5xVxl6KHhYE7MDaVNVE6KQQi2ivPLnokU26Ttd1K3eBbHD1kRZa0f GlegCGsNB9yEzguL6PDul5nZSqFYsK5PYWMVYffyd8OZWIO7SF+cFbj++24UZlwV32on 8u3xalLi8OwJ+1QahXL9yH1In7hszulCcTENOqkcnLCYiDCfhociSWO0mfbZbe5IEI4/ QLVQ== X-Gm-Message-State: AJaThX61xO6H2qe7xug0ypnn+Aa96iHXOAW82SiZ9CIsSSt6uOogAxdy YmWjZ0yrUZj3wYtIAPWcDHk= X-Google-Smtp-Source: AGs4zMafXgIWpbITTDUKmzrueE1KUIZo52MYvnMndwC+DPOLPsBWFU164TNwqp5qfto0osoovjStVg== X-Received: by 10.99.39.5 with SMTP id n5mr14937714pgn.48.1512409733691; Mon, 04 Dec 2017 09:48:53 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:53 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:20 +0530 Message-Id: <1512409703-20881-5-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative number if an error occurs, Zero if No irq is found and positive number if irq gets successful. platform_get_irq() error checking only for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596.c index b2c04a7..f2a11fc 100644 --- a/drivers/net/ethernet/i825xx/sni_82596.c +++ b/drivers/net/ethernet/i825xx/sni_82596.c @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5] = readb(eth_addr + 0x06); iounmap(eth_addr); - if (!netdevice->irq) { + if (netdevice->irq <= 0) { printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n", __FILE__, netdevice->base_addr); + retval = netdevice->irq ? netdevice->irq : -ENODEV; goto probe_failed; }