From patchwork Mon Dec 4 17:48:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844348 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="S2JrnyET"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC9d68GQz9t16 for ; Tue, 5 Dec 2017 04:51:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbdLDRvW (ORCPT ); Mon, 4 Dec 2017 12:51:22 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34803 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbdLDRsv (ORCPT ); Mon, 4 Dec 2017 12:48:51 -0500 Received: by mail-pg0-f65.google.com with SMTP id j4so8702253pgp.1; Mon, 04 Dec 2017 09:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=a9XOSbs5CQZUxGIwxlLU8l//z1tddPklL65AwplANDU=; b=S2JrnyETsPLPzmfhh2/bO17CUtSjaNgQh6qkWC3LA0hI8gBgVCa36a6orUr4OK+ZT1 wAIyKtehFrh6P0hDLg4DIcKfoxNeLE3e3A8XTyRVjM6NYVigrnUETog+MPLwpaT60i9r e168VYm6wEjJQ9lzPFsxFLOa69TM57EJ4OG9UEWjHNv+M27advdkfVH+yXz5OckjK9UN /muJweou3un6K+jBLy7tUlgtsBfKH4NQLTAL4n4eiP+BF9VyD/QNvYgKEFl1Zycj4CYs Ac+ZV7R24hrkONSrpp4ycV5WdVj91yWHCM9jTAgSP3iJ6QzsxHa+E2a7/S/y++NMgq5/ o7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=a9XOSbs5CQZUxGIwxlLU8l//z1tddPklL65AwplANDU=; b=tGEdD2cJ6m3gEzKqIEv/5VdwKUoMLS/Q4r/0+sIuJJ3mud6AyD8fMLpZI1EIRVaNXQ 57TW21p0BngCH99WnxmUNFuMB5SJ0FhBH/NG826NWhEvzs6Hryn0BK6etWgk2Qi7KRB5 Ak4SBnBXUUaJf7qZHYXpvT/C0l06Z/xxsxcdc9GCNBBYwANfPo5TioOaT93rFnOTYAh7 xmLksYkCWQzw0PG2ZKjBK4TlqRm5wRTZMlMCgc4cVNXeHIysHgyvQEBXQwJ3CVXPMHcJ ZAmyMRCs72eVHM/NAXJ4ESkkWAFfXMsOg9KcXyPsvaNGOy4RmBkR9+OVbWrtlfbtqIFZ uyag== X-Gm-Message-State: AJaThX4de7hJ6g4WEjeepf2bVoVlA8N9gUJmhtQQGBm6cJMWo5pnkp78 JIYHHc3nuZzl7N+Km3ldfgM= X-Google-Smtp-Source: AGs4zMafzYYblOVydGMYU2pfhK+Gw2On31eX4qYiZpNg7hr/oQm/dpYy743ehzInvr5bHvv091tZNA== X-Received: by 10.98.55.3 with SMTP id e3mr19817946pfa.63.1512409730541; Mon, 04 Dec 2017 09:48:50 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:50 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 3/7 v2] can: xilinx: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:19 +0530 Message-Id: <1512409703-20881-4-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/can/xilinx_can.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 89aec07..1b859af 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1111,6 +1111,10 @@ static int xcan_probe(struct platform_device *pdev) /* Get IRQ for the device */ ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto err_free; + } ndev->flags |= IFF_ECHO; /* We support local echo */ platform_set_drvdata(pdev, ndev);