From patchwork Mon Dec 4 17:48:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844346 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ii0Cn5yr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC8F1hGlz9t16 for ; Tue, 5 Dec 2017 04:50:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdLDRsx (ORCPT ); Mon, 4 Dec 2017 12:48:53 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38027 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbdLDRss (ORCPT ); Mon, 4 Dec 2017 12:48:48 -0500 Received: by mail-pg0-f67.google.com with SMTP id f12so8701025pgo.5; Mon, 04 Dec 2017 09:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FQ0IJdlFZ/dw/FO2WR2T18XOEAtQnVWMzHfV07ZNNIc=; b=ii0Cn5yr3zSEk3sFmdJbnNIc1Jd08i8obMdxKr4lDWtEvjAaytF+wDloLh1rFXmH15 IQKu9z/lGAE7x2aQWYPztOAlebL0PxJBxslFAcKOBDhwLyCKuKG5vOecGD8B0UVJp/qT ruoUqOuvLAQNOlMtdc3+Dd2wDbK4CzQeFNwPfAhPDjKa2hbfxVYMCwZYrt3TXcroFRdv nFVhHqUwOhD0sVFCCUHdeYHHPwn7vg4nWj6tErL4uJkFzICouuFDcXB5Vne+b7+48GYN bMTPBy/TXOO4hI2HO09+RhBeLd9mvVD4vfKhCOUZhTYThT++C8U05hFoAV11FDudlQPf P3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FQ0IJdlFZ/dw/FO2WR2T18XOEAtQnVWMzHfV07ZNNIc=; b=PoFCjSyiCjozXxRbq0SzjdvFldIrZ6nX8hojBYOVJinwmG39do0zTSPLvTwrnhhwou TjkWolB5bA7Jxnyqz1G0GZmwKGEH2dWfUfQhMLgzvYtKnYS5pAT8PCyiyNgwY2excrLM Wu3wuHol2K/DXmCiUVeljip1DuKINLr6Udh9sL4u3ynt1gEn6k7IRsEFn8elwn4IxIZy GZ3O1itEmvHppxzvQYpKpD+/aTwmekJ5OMERlogmlkaCjr0Sfj3vLaoZlONKuB/Y9hcQ welkueGDAXh99n/yuwGwdfegX9pYAFLIWAKRnlpr4H0rsBQHvpeVqFG6SFVtcrkdOYA8 63pQ== X-Gm-Message-State: AKGB3mIM62AY6JVh4EEP9tgd/zElIq8DJJHSQcrS3CHe3e/Zq+nEjm5O MwREexyDBWEKPIi7V1ZdtfCJOg== X-Google-Smtp-Source: AGs4zMbGIVc/UO6peVzmq586RdLKeaRvjSfZTLZdoNlXFGTEXFvIzDm1/RsEI453uWr93jEAlVrYRw== X-Received: by 10.159.244.149 with SMTP id y21mr4261908plr.157.1512409727441; Mon, 04 Dec 2017 09:48:47 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:46 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 2/7 v2] net: ezchip: nps_enet: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:18 +0530 Message-Id: <1512409703-20881-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative number if an error occurs, Zero if No irq is found and positive number if irq gets successful. platform_get_irq() error checking only for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/ezchip/nps_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c index 659f1ad..7d4b628 100644 --- a/drivers/net/ethernet/ezchip/nps_enet.c +++ b/drivers/net/ethernet/ezchip/nps_enet.c @@ -623,9 +623,9 @@ static s32 nps_enet_probe(struct platform_device *pdev) /* Get IRQ number */ priv->irq = platform_get_irq(pdev, 0); - if (!priv->irq) { + if (priv->irq <= 0) { dev_err(dev, "failed to retrieve value from device tree\n"); - err = -ENODEV; + err = priv->irq ? priv->irq : -ENODEV; goto out_netdev; }