From patchwork Mon Dec 4 17:48:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844345 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MkexBlKU"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC7y1VxJz9sPt for ; Tue, 5 Dec 2017 04:50:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbdLDRsz (ORCPT ); Mon, 4 Dec 2017 12:48:55 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35727 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdLDRso (ORCPT ); Mon, 4 Dec 2017 12:48:44 -0500 Received: by mail-pf0-f194.google.com with SMTP id j124so9072469pfc.2; Mon, 04 Dec 2017 09:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aUiBfAM1hQQ8wVvHa9tA+Vs3EHwhl2XhGngA2ge69Us=; b=MkexBlKUO/2Xp6rgsGaWE8bTBWXogAqxmiJONBqYtfcTAETRKnbUsC3fv2hnP01yIZ OSyOyPRzQCBl7h9A8MewTshx3Vzh2xaVb1bOGOOcrW9wiI4IACldAHRNsl/EdOovcJf5 YKdoO3jPyc5msZwZ38ylDIqOami7JDNCrwSOmiRlg3mbcwLFmN9grPlloLTCaY0Ogcfs gcL+uieCVLSyPYJxGLH4o8sZ+xFG4kGWv4AY2HOfrrorNDU0JwR5c9+YVM/RKkM1Ij4Q PhcRBVNNw8pnf7zxKzITbjkX3Sa1AUPArO0pIPlnRoUU4jArZEKrYJ+ETmApBGbV7uUN oJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aUiBfAM1hQQ8wVvHa9tA+Vs3EHwhl2XhGngA2ge69Us=; b=gmmQyhN/ctgzUBWqTqpXTHYrDjnEhOngYMlnwhA3M/eXkBJjJj+1kgMV/I15lmlHGX xH8Pl6SWF8Fo/3fLBnOUoP1tRx4luBdbrDPmk/hRFWAzhplZw6LYpd38MwLjN7bO8z7W C4jT0jfDCOfFN5y9JJNwx7wYcZ/7hl4hcDF2GGu3xzL7uGrIsC9Nrr8pPiL1q1LhSZBf eK6ZEesD76RCBDbmTFxq66+JBE2RPZnme6DeQuyfcCPl9potyhMJIXnITOCQ7xTbAVXC k974VGqD+vIW/aVw6fI7NWm3Bt+MK4PW5lpyK+jUSvdDkelj28nZPmteZY2UBssIiyvO XJFQ== X-Gm-Message-State: AKGB3mJb0Bqon6ugvxz6mGCyKCZbSaGP/K2SkOaPdX1kRJUXv3nwShwS ta3ddBJ03dJCB2Iqib34tXw= X-Google-Smtp-Source: AGs4zMZosltycpSds08AlQgROos5aOR7XZdeAuMUy23v3XfadhJVUDz97gq3ntPPttig58WpQNXSaw== X-Received: by 10.84.131.41 with SMTP id 38mr993194pld.149.1512409724110; Mon, 04 Dec 2017 09:48:44 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:38 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 1/7 v2] net: bcmgenet: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:17 +0530 Message-Id: <1512409703-20881-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative number if an error occurs, Zero if No irq is found and positive number if irq gets successful. platform_get_irq() error checking only for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 24b4f4c..e2f1268 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3371,7 +3371,7 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->irq0 = platform_get_irq(pdev, 0); priv->irq1 = platform_get_irq(pdev, 1); priv->wol_irq = platform_get_irq(pdev, 2); - if (!priv->irq0 || !priv->irq1) { + if (priv->irq0 <= 0 || priv->irq1 <= 0 || priv->wol_irq <= 0) { dev_err(&pdev->dev, "can't find IRQs\n"); err = -EINVAL; goto err;