From patchwork Sat Dec 2 19:26:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843912 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z+yBLdUg"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Pw6QpRz9sBd for ; Sun, 3 Dec 2017 06:28:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbdLBT1y (ORCPT ); Sat, 2 Dec 2017 14:27:54 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:43692 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbdLBT1B (ORCPT ); Sat, 2 Dec 2017 14:27:01 -0500 Received: by mail-pf0-f195.google.com with SMTP id e3so6083973pfi.10; Sat, 02 Dec 2017 11:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c/w01skmvyGMwSEFlTBH0OiX5hl4ZGAKrevZLfi3YUs=; b=Z+yBLdUg29lrwIYQnWdGtjffCbWPZfZpGwL5ao3+4xkLs3YbmHwBragIqM8Jp4jOJg 5YAaMZofgRq5AZzfSBe+ktWyDRoL2/0HY4eH1DVKQrqLi7MmJrz2FVIzJunDchvdmeif dz732y5buPUkElrscwpuEHRdlMu3ZoVEeEwNK+EfVIJIheL5XbCs8Knf7f+srQZasnva 6X+k6ayIuoYihRsv2ytOS1NnzRsIwgLUjB+IRYnWL+UPRswSagoyIljrGPNY0F3N5jLB V+NKqrkAngOh9o4yfRbY8sMLg5hbGRCaedFlXYdem+aFW4NCn/PRS78JQn9Xep2jWpXG s9fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c/w01skmvyGMwSEFlTBH0OiX5hl4ZGAKrevZLfi3YUs=; b=VrVTZ/mUIoboVQZ+uaFmfHmDKzoZFRuNwgNnGkBxXYcY4dbWXu2GG/OldhziAvTV9d n0gWiKMLcDZbLL1duPRoyH7BM4+IEiZhWttShAa1N5QcYHZ3j2ZOW+bkHNQ0FKp6R0fN /nUbBj6uyjsD5uiTssw31SZBRc2sXQIr90+NbPJ4GnQNzT8gWUsTCeUvRVZK9qaDF3XW InUCK45Swg+eqlhj6CHoaTIs6bbJetBHbYZ5NEEaesTTf0En9LrL2Q8DQH/qkUJ6WVkL kXQlpGU7mh9QrRFrCNi1lDQyJVHEBbrzEhPYQdAl0HbZR6bqGJ1xLfHtyT+zSTTXqRbx mUoQ== X-Gm-Message-State: AJaThX6mxZNcKu2APljH9Y7eunIBuJEzwgHZI+484Wo/7Z3f+4JnIYWe q0oCBfgvOMC22fPpb2U5VbM= X-Google-Smtp-Source: AGs4zMYk0LyC35SplBudAf0YsYVk6QQnMtprXhtKxPTNsw3QksdJmU3SyrZCyF6rps03suOpszneYw== X-Received: by 10.98.207.70 with SMTP id b67mr14462447pfg.220.1512242820578; Sat, 02 Dec 2017 11:27:00 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:27:00 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource Date: Sun, 3 Dec 2017 00:56:20 +0530 Message-Id: <1512242782-7134-9-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/fjes/fjes_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 750954b..540dd51 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1265,9 +1265,19 @@ static int fjes_probe(struct platform_device *plat_dev) adapter->interrupt_watch_enable = false; res = platform_get_resource(plat_dev, IORESOURCE_MEM, 0); + if (!res) { + err = -EINVAL; + goto err_free_netdev; + } + hw->hw_res.start = res->start; hw->hw_res.size = resource_size(res); hw->hw_res.irq = platform_get_irq(plat_dev, 0); + if (hw->hw_res.irq <= 0) { + err = hw->hw_res.irq ? hw->hw_res.irq : -ENODEV; + goto err_free_netdev; + } + err = fjes_hw_init(&adapter->hw); if (err) goto err_free_netdev;