From patchwork Sat Dec 2 19:26:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843909 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Nl8IkjzS"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Nn21Thz9sBd for ; Sun, 3 Dec 2017 06:27:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbdLBT1C (ORCPT ); Sat, 2 Dec 2017 14:27:02 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:44333 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbdLBT05 (ORCPT ); Sat, 2 Dec 2017 14:26:57 -0500 Received: by mail-pf0-f194.google.com with SMTP id m26so6080927pfj.11; Sat, 02 Dec 2017 11:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nRQlom2cn1YQyAodDUM0fj2/PoEM0RA/qcwNM4u1u6g=; b=Nl8IkjzSCb0CIGvm4tUkA2sK2PZZ1tqJ6IU7Pcxv/4k3EU+0COSje++/PEYQtiQdnJ HgsIBMM3W3O42kfEgosaua7i3xS8yxwT2l4J+qJSPiSGY/jbUIDY2QkIwYLzQmPz5fnZ M6NYw7uA3eHS8gQtk43bFyVdfkCrjm2EhLEXK84EEWq0B+FlEyjMPuBM/cQ4cPWldUMY ZIpkl+6o7mZHvVEwciuyOXYO3IhEFnUmzVJcMgpnAmRQU8HJItesntqi3gyHVgZ7mzRA GUsn/bkvH44Ps4E8J+Z2ratebez2zldTuzvpQuFzub5eutl9P35V8N1fJ78q3Z/A5MrE Gt+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nRQlom2cn1YQyAodDUM0fj2/PoEM0RA/qcwNM4u1u6g=; b=TgKf+UE8PM5Doxa7RwBSQOm2bXCOkRDAIkxUSGIwpN5rmKlIoWAOXUVcJCcoZ//IjQ cI3aShBO5kL8prAGptPWMZ5/6XdkciyTD5lRfhpQxXHFMoK8WkfuKasTD4TVshweN+/C 0RMG+Ahu9niPp6MULYzI2vOgbEASzmLMkCk8s5sz+1dUxxa93NzO8xKbqvoS17TWSADk pyy/USwIm6DyUJYdDq/Fx2piQFoXyTpnlnyf8mtSP1xMdcDsKnkPkp0LvH8S2SPQx28U 9zSQe+HUuUzzXatDn8tGm0BP2XMhoBd001+lZDfnUXLajdeHonzZJltHuOLEmZhX7iBa 9lJQ== X-Gm-Message-State: AJaThX6BM9IsvDHFGK3J9pd4L4AohDmA0L1MsFPtmJv6kJS8eejlGVAG hH+rthSYcDzgiLUD5Nri/bE= X-Google-Smtp-Source: AGs4zMaQ1+b8rTMPLvySnf321YGBvVzqwQxdJt9yXcYSmGdNDLBLh7K+mTZFF5bBMsY/ICJ5q49v8A== X-Received: by 10.99.144.68 with SMTP id a65mr9951213pge.429.1512242817258; Sat, 02 Dec 2017 11:26:57 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:56 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 07/10] net: ethernet: smsc: Handle return value of platform_get_irq Date: Sun, 3 Dec 2017 00:56:19 +0530 Message-Id: <1512242782-7134-8-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/smsc/smc911x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 0515744..a1cf18c 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -2088,6 +2088,11 @@ static int smc911x_drv_probe(struct platform_device *pdev) ndev->dma = (unsigned char)-1; ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto release_both; + } + lp = netdev_priv(ndev); lp->netdev = ndev; #ifdef SMC_DYNAMIC_BUS_CONFIG