From patchwork Sat Dec 2 19:26:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843913 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="U2tmXBny"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1QD0qpJz9sBd for ; Sun, 3 Dec 2017 06:28:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752489AbdLBT0z (ORCPT ); Sat, 2 Dec 2017 14:26:55 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33492 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbdLBT0x (ORCPT ); Sat, 2 Dec 2017 14:26:53 -0500 Received: by mail-pg0-f67.google.com with SMTP id g7so5891645pgs.0; Sat, 02 Dec 2017 11:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QgPO+53vmcPegXdhyeXpMvXzghtPjd9fKNczdhwW6NE=; b=U2tmXBnyjABksnrW1EvsJuEQej19RgkZFm1/pvD4HWYtm1/qq5tzIuheEuyadDBTJq 9tSlSVWieRAvTALWXRNTGYjysf/PFysDArSKGUZ4IkIHE0udLH9OBLORhu25LGIHClYC T/VCDCWBex+wksRBsbi6sEppd9OCQ0JjjchfCCBvxNzYRuh7kst9S70Z4dHv93AP0EZJ rqGglw13IouI9hY+tp4bXIlEoHFincjs+oD9I3Fb6+zcIEqYfJTspRpZC8Vit7EXhdNu A81QLUGXUfRjfJnwvWwSuT5puODQ9qThckHzgMox5wvf9iaiePXMF4d2KtsjyA+9bXrm YsTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QgPO+53vmcPegXdhyeXpMvXzghtPjd9fKNczdhwW6NE=; b=m1qJ+sChOM7txGuI5btnAeffCiXD9dmvFnXyS4MM61hRTE6TxkzASCPAbZlepVrLBd aoa1qpGKa+OVsmvjFVqr21OhuNYP2gI3JQZUIsBEpYkEaLRg7WdE7EMilPwNaMDBTs4J 3cauLCLZYGZmhKKEaT6y+t7ILZ+T5TdwRsTJIwzfy1bhX0SoAmYDyrw4RHAdvU2k8W++ 51ndiTbqkcEPrJawFw3RnKijTHv6wIV1p+dWN76OA2jUmTsZYn84bkyZiXiFsznKENlY 5KOr1IAdSH/PsTNhlQ3Kfv7oRN27BGuCHdd3/N///M/tpAQcCIdf6danRadxCXqcvmR5 BCrA== X-Gm-Message-State: AJaThX4rYDgE+qY9NiMtwx31Zhp9UNgqJcDk8HKHnsfiL0zkxHyZPJpO 6frpn4P0Y7Y79Z1nP1vb7hY= X-Google-Smtp-Source: AGs4zMbixsckT4zmZcU30W0Y+A7ZdPnCM5SEga3wc+izTg8t81HfYttLEWVo24YzNh+Ynh2Sx/41ug== X-Received: by 10.99.4.142 with SMTP id 136mr9442493pge.72.1512242812999; Sat, 02 Dec 2017 11:26:52 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:52 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 06/10] net: ethernet: natsemi: Handle return value of platform_get_irq Date: Sun, 3 Dec 2017 00:56:18 +0530 Message-Id: <1512242782-7134-7-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/natsemi/jazzsonic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c index d5b2888..3cf0856 100644 --- a/drivers/net/ethernet/natsemi/jazzsonic.c +++ b/drivers/net/ethernet/natsemi/jazzsonic.c @@ -242,6 +242,11 @@ static int jazz_sonic_probe(struct platform_device *pdev) dev->base_addr = res->start; dev->irq = platform_get_irq(pdev, 0); + if (dev->irq <= 0) { + err = dev->irq ? dev->irq : -ENODEV; + goto out; + } + err = sonic_probe1(dev); if (err) goto out;