From patchwork Sat Dec 2 19:26:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843915 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ffGQi4zv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Qk02P4z9sNw for ; Sun, 3 Dec 2017 06:28:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649AbdLBT2i (ORCPT ); Sat, 2 Dec 2017 14:28:38 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:40955 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbdLBT0u (ORCPT ); Sat, 2 Dec 2017 14:26:50 -0500 Received: by mail-pf0-f193.google.com with SMTP id v26so6090071pfl.7; Sat, 02 Dec 2017 11:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3N9N+1VLcUW/4uQzg/7SimUBvcthJGhtRDiEuoqOQ+E=; b=ffGQi4zvMNEkXraUjnnrlmDAiUUJAQh7s1JlSoaU9b2AiKKl881oNaniBDzHIvry6H 6ul5Hy+qCkJP8oi3hFn3PryJtvfAuAkNgmD1jw+ce76r0EgCh0rRALDWoINz+UdlIWMV 1jv3u72nZHdgV65Ajpxqa17nnpWl607MwZLSPprkx2pyxn2qX+GfKNQL/IRkJDEkoD9i e8tKn+lvdHAI4of+d5R5oArtIFWm+qXIQDk5K59HjNWdpqeiTUeYRpXbsgUP0zIoykXW bOVVtgelk0GIctTD4dK5UIoayFzzeOaYUMnDm4w4k/y3+ihdFllHKAN4gqqpHpzoJWRj Lonw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3N9N+1VLcUW/4uQzg/7SimUBvcthJGhtRDiEuoqOQ+E=; b=GbsCU9ym14eMeOYDjTO4KYnZgfPiQ7UOI6V2VOqATOpDywA8eMAM8q2R4RTWRngYhV /RsKynkR+Ku2DBZsCT5YJ/ktgNSz1tjmA7UKKzXyf2zfSh2/38/uYJRgOY7Pjr3BVYFQ p7DrVjzUPD1ewE1DZm58gzciTZDKJHQX0LsgKMD5BF2l1G9HpmGjfKBwY75hB6YZ1rmj MiHnHmCtipzBVqe7mmAsuaNceNqkhwmPMAcUezlMpUT0sAIELJLLgdeelfUO18o+q6nF xYmb3EMJxIh+KWTJTIrH0q63BSBfwMl6Cuqjf0ZL9B62Q5dgC7XcjGw7dEvJVhckrLPj Ecng== X-Gm-Message-State: AJaThX5CoTdV89cXj1NDMgpl4064grRchiYu9Z6NpwZ7uofEfF43hMxt 5yYR3mpSWpkd63wVFxEqpQw= X-Google-Smtp-Source: AGs4zMZH+yfsH5A0rLofzkpBM9nbHH32HE61/qd/Le69O0CYuQCNxRMXo9H5HasAy8VOjr/fbkIrqA== X-Received: by 10.101.77.210 with SMTP id q18mr5459356pgt.145.1512242809702; Sat, 02 Dec 2017 11:26:49 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:49 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:17 +0530 Message-Id: <1512242782-7134-6-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596.c index b2c04a7..a6d56f5 100644 --- a/drivers/net/ethernet/i825xx/sni_82596.c +++ b/drivers/net/ethernet/i825xx/sni_82596.c @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5] = readb(eth_addr + 0x06); iounmap(eth_addr); - if (!netdevice->irq) { + if (netdevice->irq <= 0) { printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n", __FILE__, netdevice->base_addr); + retval = netdevice->irq ? netdevice->irq : -ENODEV; goto probe_failed; }