From patchwork Sat Dec 2 19:26:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843914 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FNY0ATTj"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1QQ2DGZz9sBd for ; Sun, 3 Dec 2017 06:28:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430AbdLBT0v (ORCPT ); Sat, 2 Dec 2017 14:26:51 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:35464 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752402AbdLBT0r (ORCPT ); Sat, 2 Dec 2017 14:26:47 -0500 Received: by mail-pl0-f68.google.com with SMTP id b96so8150752pli.2; Sat, 02 Dec 2017 11:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2wkEKFnkLt6c0J6yaAdVLSQXa08/bN9qdqEhXeSys1Y=; b=FNY0ATTjfEafiCOER8P1nbQZKtVNKhIxkYkX5tFbOjV4NCR/gWwxFDI56v5QfNS8e9 6ny2eJ5n3bPodlJw0vB47TmTBrbxFlxLDB12dSBq7eAGYcbKYZEBC2NsrF3NrytIrptb vDusRex4T8sSzvWXyqXjAwVicp7NAiygTyvnPbef8feN/EOB/+bTqMEByvG9zv8fG9uP yGJ+zsYIexXJsEvIrSSXHx0MW2eElJQJeDT1YtTaAhvfnIQ6Hqxv8NzRXoaVJkleRUJp 4XNmyGzh/lJ+c3x9nJG6vSY7tefSfAwCDHDLOMn9mv+MpDXU3IP+yGS/JiCwbeMztFOD 3Dhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2wkEKFnkLt6c0J6yaAdVLSQXa08/bN9qdqEhXeSys1Y=; b=FcmZntugM4X1TunLjEfio4JnA8mN601bsutTJOx+EmAVCLtxK6CY05cglfc1aMm+2W IQEBOolb/R0ILF6k0SI+4/zMfdQG/v0R9VuZR4MUO1LDFwq3adS9bz7bBeV/8yu6Xyh0 82JszJZta70ayAja4NUIxOmYB9vU6uNRCmfVakxuXw2zhENfyoRKYr1V0IjYm0U7Mz81 pZGukA03PYnKW+092KwwkkLyKiSXtjoWazlTLLDh8UL6CAXM/gg7GoFrm3DYTCPhTvYQ ZZjYS79FWYm0YpdUXTPI7ImRZEUZPq1pGcR1RnAO/Q0QIhkEe2xckOvt3a+nzufPKR+0 16Cw== X-Gm-Message-State: AJaThX7KeKjHBcXFF2yNsrUgu+iwZ3QJCBaM40rztSP/A3OyWaSg1hmm GXYpGD9X9bC4FY1NAxKL7+A= X-Google-Smtp-Source: AGs4zMaYE9dwhEp4pHPsXQSKYHvtswSOb0jMwZ8rxAqEc5n8tqql0OWsLrm/mB+YHUQ5i/Vr+8fX6w== X-Received: by 10.84.172.195 with SMTP id n61mr9969446plb.49.1512242806384; Sat, 02 Dec 2017 11:26:46 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:45 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 04/10] can: xilinx: Handle return value of platform_get_irq Date: Sun, 3 Dec 2017 00:56:16 +0530 Message-Id: <1512242782-7134-5-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/can/xilinx_can.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 89aec07..e36e2a2 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1111,6 +1111,10 @@ static int xcan_probe(struct platform_device *pdev) /* Get IRQ for the device */ ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto err_free; + } ndev->flags |= IFF_ECHO; /* We support local echo */ platform_set_drvdata(pdev, ndev);