From patchwork Sat Dec 2 19:26:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843916 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nnP0Wk25"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1R95mwxz9sBd for ; Sun, 3 Dec 2017 06:29:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752674AbdLBT3A (ORCPT ); Sat, 2 Dec 2017 14:29:00 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:40963 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbdLBT0n (ORCPT ); Sat, 2 Dec 2017 14:26:43 -0500 Received: by mail-pl0-f65.google.com with SMTP id g2so8147040pli.8; Sat, 02 Dec 2017 11:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U5xU1EIb3TFWE3G1JhyDbFCLGf7eLplAxWrip/41w7w=; b=nnP0Wk25+PyaNbKBlUOjpw/pJivKRsuKPEX2ZEVv7VVVy9pjhz2qCNftGZXuPl7uab xVXxP2NG9zRfAryy4w+TaCnyiiADDySQ9z5LYMk5ZL94e/+S0X764rrdOz3fGSnDy1Rd VaOe7tcO9Pgcjq1vWkOfd46MPXj3ntKpqRA5NwXxrwQO+jljzyRSocn+bMCAVr3ZVwt5 GJDa7m2IlHEqyu4sq1oYtLB8P2ez+vb2SIeANI8Rh5GPmzPYE4iDQGbx5rUuns00231Z EM8doxWewlwjVm6x25EBBr5VA1dp7nbGya8DkQMBmThJfzY30Q2G4nn1S4mNqjvwzB96 lxxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U5xU1EIb3TFWE3G1JhyDbFCLGf7eLplAxWrip/41w7w=; b=WP1ZLFPJP7iHzxGu3KIoWuejDaV+c96wn1edZY3wJEg83WTe9jgOt/bJ2fpWs0B63B /k16bSrc3rB+5yMhMKf5cDeE+lRgg3KQQI0OIyPJlNsbMKF8oGmYdD7NMFiN17UOiJDQ OdssFqOiCPhcoRJfe2pFQCfcgZ9Mr7PgTinhZpAQhEt3I7tjYG5e6Cb84Ga/abMZoHuZ WWWhJ6Osv1NI/z/oaknkK2MA9rvhNouVrGeLGFo+eDE0U0TiW4si+cliFeDsSo7i/C3t urNlU8BAJ5R/ViSQZOGW2fbLsO6MFFkPQGeThSyF/kC8wX2qYRM3FVc+PBzXnGpHyxOV sbhQ== X-Gm-Message-State: AJaThX69NDYIvZMosEgylLYayP+jzb3hi5tnMVGRazy4ULOh0SmfP886 UGRuXCSjG/i51vL3LEd85/Y= X-Google-Smtp-Source: AGs4zMYYARtNNgX0Z2I15sFO4RJ/b0HUaymnGn8tKmYEjbjswk687JsjZ/SnoDmrxwLgRPx519lTmg== X-Received: by 10.84.224.5 with SMTP id r5mr9972291plj.341.1512242803183; Sat, 02 Dec 2017 11:26:43 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:42 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:15 +0530 Message-Id: <1512242782-7134-4-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. And remove unnecessary check for free_netdev(). Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ezchip/nps_enet.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c index 659f1ad..82dc6d0 100644 --- a/drivers/net/ethernet/ezchip/nps_enet.c +++ b/drivers/net/ethernet/ezchip/nps_enet.c @@ -623,9 +623,9 @@ static s32 nps_enet_probe(struct platform_device *pdev) /* Get IRQ number */ priv->irq = platform_get_irq(pdev, 0); - if (!priv->irq) { + if (priv->irq <= 0) { dev_err(dev, "failed to retrieve value from device tree\n"); - err = -ENODEV; + err = priv->irq ? priv->irq : -ENODEV; goto out_netdev; } @@ -646,8 +646,7 @@ static s32 nps_enet_probe(struct platform_device *pdev) out_netif_api: netif_napi_del(&priv->napi); out_netdev: - if (err) - free_netdev(ndev); + free_netdev(ndev); return err; }