From patchwork Sat Dec 2 19:26:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843917 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="prRzuaaq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1RM4Y8lz9sBd for ; Sun, 3 Dec 2017 06:29:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbdLBT0n (ORCPT ); Sat, 2 Dec 2017 14:26:43 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:34325 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752302AbdLBT0k (ORCPT ); Sat, 2 Dec 2017 14:26:40 -0500 Received: by mail-pl0-f67.google.com with SMTP id d21so8130124pll.1; Sat, 02 Dec 2017 11:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c5yPUC96jn/8H+4UY4VH7zzqjk2anlVoo6BwYSe2BmA=; b=prRzuaaqDg1KEL/m8QxOyySSjSPtGnd2GBSB9lPc8CRf2nkvFRz0UsD08ItH+/o999 sr6jukDogjRWkyzHVn3jjattF1+itAyiQbRc4XzKkPOISpzk6BOCHetLfyZCfz2LO7St CzXQ5RXicYDKRufzNBPX90f4B4yhFEa2MnbFa9x/2e8LWkgQK4E/IiMi1lDgRKkll7nR bVgqbmsxwTZpNBamaXn7OVEN2elNykZnxGNYKNCagbG+3U0+41I8GXNFTDeZKk2CZivy 5BZMHwj9N2dQ4W4wRejxmtxJBC9G0OibS+CwR8Q0gSAFzqq+2Wxzvkic9z5NHb9lwu0G psXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c5yPUC96jn/8H+4UY4VH7zzqjk2anlVoo6BwYSe2BmA=; b=tYyEkPec2XSETS1UJZ2MtETB6EQjDZiAlBCDahhrkvZLd/ZrloQr9Uii+AQJ+XyJQo nN6RrritVBWU4Sju11ZqWiXbczR7wdr4eS9118zF56ZURxYZWsxyp49Lpj2lk3tEiUmR zVDSvjGDnz3sHU0h2QaSBd9u4J83TwoWJuHCeflnmhXeESxfh2fbrA2SVjk8kgu1TINb 2w7FPkh/2O3ooJApGMHT/QENqdADRqPThRNLJUYVs/fnUECDEzG90AskyN3Stq38JYhe uV2z++RnjMv2O7mlxV+uujxK7rrOL6eYrx2drIs1n5yW/N+kN72VH9renFuVD4ID6Azd Bbow== X-Gm-Message-State: AJaThX6fvsuFsDdbeHBj9vRmzo0fElLM19SLRUhzFYu0O6TQqQ+6WEEN z1W5gO2CFWsVShA267l8mmA= X-Google-Smtp-Source: AGs4zMafBK0ePykW1chjRvGEJtdsZwWgrthlLBy+O5+HlZobOxoMXw5Sjeutyv1uBKMzh1K5v9nRNg== X-Received: by 10.84.168.193 with SMTP id f59mr9832432plb.22.1512242799975; Sat, 02 Dec 2017 11:26:39 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:39 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error Date: Sun, 3 Dec 2017 00:56:14 +0530 Message-Id: <1512242782-7134-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The change is to call free_netdev(), If of_match_node() will fail. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index e2f1268..e0a8f79 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3363,8 +3363,10 @@ static int bcmgenet_probe(struct platform_device *pdev) if (dn) { of_id = of_match_node(bcmgenet_match, dn); - if (!of_id) - return -EINVAL; + if (!of_id) { + err = -EINVAL; + goto err; + } } priv = netdev_priv(dev);