From patchwork Sat Dec 2 19:26:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843918 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="V9hrVbBh"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1RW6vxHz9sNw for ; Sun, 3 Dec 2017 06:29:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbdLBT0k (ORCPT ); Sat, 2 Dec 2017 14:26:40 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:42680 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbdLBT0h (ORCPT ); Sat, 2 Dec 2017 14:26:37 -0500 Received: by mail-pl0-f67.google.com with SMTP id bd8so8148845plb.9; Sat, 02 Dec 2017 11:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JfiabAyDisYZJU+0y91+jP3o+8uMbeI+e2BtLwuDaxg=; b=V9hrVbBhKOmKdIMWxi+QWUjAOIIclI663Sw3A2k2o/zRzPNkmUMrkRbM+p95Fb++9m in5TWoE0pnWrjWyg6NI+blisoPDbyrVG0bet/zQrtuegIDY3Jg4Wj+y3IOR0ZykcHDDW m2mmMwo3f5rOPIaYIerlFzpveUgLl88hW+7eDz9i4MonYmFQN+0LouLDucteZihsGrAG SLImtjECEhRlrhOGWyBy5p+PnSfZxvUA8A46dDgTAGmANYs6Fd9XuZhsqARjCCrOpGMh Yuo4EIJSmsfO3tQUkcj9A+AWLKuXO8xW5Cp6hXn7APOY55cUU1DUJdUkWmaE1i2tIUv4 wVdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JfiabAyDisYZJU+0y91+jP3o+8uMbeI+e2BtLwuDaxg=; b=Ekudk5lNpkwWqcFnjAMXLzM9S2UN8TwIiSEl80bMQAMKBWawgp+2YqXi8w1bjvPaDF HGHHqnFbcibi+J84tXuS293Yn+RRCkij5kTZDeUJFu0cNh4OoUISfbsodWD/t57ZF8FG Qqp3CJymzShMD65lWkpI29Qk2UBEaENejtqOZyCZHtT89njv32NC1ZCzosjfVbfr2jLU L4QsXaGtI6zwSNxiyAoXPOu+5ru3jIAeM4Py3FeeBEwkupxXplUzZiMjcomrg56ABMiU smeUM60FvqvmGENbXz37hDI4HQ8Qd/sXkCsrtGQsMxfV9PNUgyNiI/B+BuEmtsbK8MTC b3UQ== X-Gm-Message-State: AJaThX6UQgJABiRg8RPBTjf7NRj7sSR8EYYyKoDgvXWgh4wZMdDkCe9G Oub0mVvw4DgQqGERSY6hYQY= X-Google-Smtp-Source: AGs4zMZA6bi7hGE6AUlwQar4VzbVl8LF0NNpA/lUMmoDvjK4UehYFE03PmCze9HlQC4ovFa7hBIIZA== X-Received: by 10.84.136.135 with SMTP id 7mr10025913pll.21.1512242796829; Sat, 02 Dec 2017 11:26:36 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:36 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 01/10] net: bcmgenet: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:13 +0530 Message-Id: <1512242782-7134-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 24b4f4c..e2f1268 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3371,7 +3371,7 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->irq0 = platform_get_irq(pdev, 0); priv->irq1 = platform_get_irq(pdev, 1); priv->wol_irq = platform_get_irq(pdev, 2); - if (!priv->irq0 || !priv->irq1) { + if (priv->irq0 <= 0 || priv->irq1 <= 0 || priv->wol_irq <= 0) { dev_err(&pdev->dev, "can't find IRQs\n"); err = -EINVAL; goto err;