From patchwork Sat Dec 2 19:26:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843911 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hFG5oE/3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1PD72PFz9sBd for ; Sun, 3 Dec 2017 06:27:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbdLBT1U (ORCPT ); Sat, 2 Dec 2017 14:27:20 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36499 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbdLBT1H (ORCPT ); Sat, 2 Dec 2017 14:27:07 -0500 Received: by mail-pf0-f196.google.com with SMTP id p84so6091044pfd.3; Sat, 02 Dec 2017 11:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z+6CJ3RtGM8Bou5Q7udY1q++55omMoBN8Ue3KlKf4M0=; b=hFG5oE/3TJHQX6vwTxf+Q7Q7FWemU7JFMnzMpMqCtx+6oNVjsYYWbzwu2Ke1vgEIt6 6w6GY9XHeNUIwnb5E29DEP6gbb5AC4GEDTOQB90XFK7ucDHlJPtnCYkpg34DC4Gw0lfB +Auf1/rF+jZFRgZKwIxutpc2rQGJC8DpkOdJVseeDnAwZ+wMzXmwWfAuIn6UG7/cTvcs qC6m3fAiMy/e1BN+hlFw07/m4RCL8DxH2ODUMhpsGRpPdA+IiWaD1VFGJZE1CQc9uvDI HEP05+BxdB0BOuGu3sPRyyt5PJb4RnxWP/+LZRagZXHTPzqf2m+OJTpWay4SuGq2Ug7b AU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z+6CJ3RtGM8Bou5Q7udY1q++55omMoBN8Ue3KlKf4M0=; b=gGBBoQrvgSMTCXA+B1YaxzVU3abfuXpfIEJg44oEYhVPYgCmOHwhJGKdJrTG4FhTqU n0pZMwV5oYprNAhPFopJJlH3hntZ7vFzCXBo2gh9QVNg3G5knmMG9jUcijWck54KxwSK v6U2zpnLUHc+o97JNcygdTgwfW63C47YZc9VA6/fg92lvtzcqecwrUN6k7dnmvsUgpuZ 2moGestA6teiVHCM9A3Ygl0DfdS6zYc/ldSE2KU+x71RtYc1uXqPLuispugLy9PPpoXe X+nBorOvDNHEXJ1nUfCU/5f/DShxvwNm8sP+OxmNECqUNZWk1VVcNgGbUHG5FcD5BGAR 2Qyw== X-Gm-Message-State: AJaThX6oB4YsMOrphVYUk+TyH9FHf1K2LC9sXUuHDQGRQr1fh3qylj+I smhNehDZznSHs4OIM74DxoY= X-Google-Smtp-Source: AGs4zMaVpJk00p57hE5+qmGKq4bvf8nxMc5jhiD/XdTnuYpjGijB2Tlf/s879A2/8QewQRwdsj/MJA== X-Received: by 10.101.68.201 with SMTP id g9mr9645893pgs.149.1512242827414; Sat, 02 Dec 2017 11:27:07 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.27.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:27:06 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 10/10] net: ethernet: cpmac: Handle return value of platform_get_irq_byname Date: Sun, 3 Dec 2017 00:56:22 +0530 Message-Id: <1512242782-7134-11-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq_byname() can fail here and we must check its return value Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ti/cpmac.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index 9b8a30b..f3acfc0 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c @@ -1124,6 +1124,10 @@ static int cpmac_probe(struct platform_device *pdev) } dev->irq = platform_get_irq_byname(pdev, "irq"); + if (dev->irq < 0) { + rc = dev->irq; + goto fail; + } dev->netdev_ops = &cpmac_netdev_ops; dev->ethtool_ops = &cpmac_ethtool_ops;