From patchwork Sat Dec 2 19:26:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843910 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="A+lLBJdo"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Ny6MBvz9sBd for ; Sun, 3 Dec 2017 06:27:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbdLBT1I (ORCPT ); Sat, 2 Dec 2017 14:27:08 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:42237 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbdLBT1E (ORCPT ); Sat, 2 Dec 2017 14:27:04 -0500 Received: by mail-pg0-f65.google.com with SMTP id e14so5883029pgr.9; Sat, 02 Dec 2017 11:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=raJNXmbwVqpq83KKgT3XBuMmTgFvd7SAupVC/Uzr9r0=; b=A+lLBJdoYx/MuIjPer2wMCgl2Fut1P9YLeQ/oEL6OYV/+6XoVr/fptzUf5dZFkZndZ 4I8L5oPnJTQtOkG3Pa8qTv2QJNZBG0lHTrZdgunCSa8ljkmZHXGjl1vpIZu0DXDiGwDP UG60eGxP/DWe9pUEWFe3V4FaSAwUmLwQWFbJn67TpjlQbppheTJwyWSVHYWnTGlKTECU Mou5pSBKIF/xAK7JpMEpvmwlE0HZ9Cm1Km8n+EA0fWjDU+N7TV19RpYNgi474B3l7ZCR u1Wo/zvxNLqqjmF+OloLbtR892fy814BCUH5xHpGEFz9zp7JcVTo6E2VAtbnKppc487q dEHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=raJNXmbwVqpq83KKgT3XBuMmTgFvd7SAupVC/Uzr9r0=; b=mS0c1pp5nWBcHq15ptP4UtWjhbxDLmtv3NeotN3vUGjmyHRQXNlP/gQWQ3ZA61NTF0 c84s084H0awnVtdEJjfY8gKa9gkJ+ba6KryWX2m0G9fmKG2ZAiCupWOUJmRyZM6GiVB0 478Ry1ObSYszjpR6hPQhaXlSJ9Wcp9RXBiX4AmH3v94EbaKOpuN8XVGjh3nBVgiihsge w8M+mjxCTCgVNxcdySw6XHKyoou+mewnTEGqd1Kn3FcrNbP1+EIlVpzE8Gp7P0npVVYr pY4gDm10JJpeUtYXr4oEtTmRhv8iFyaTCCiIlA5U98SPt5bpJK225junWwZovwovAr9V eMyA== X-Gm-Message-State: AJaThX47l93MlJE6SyDkjgRtuOmorSI0mZ4oWsp1v2IyvT/mkngAHRCh xwga7lK7uiFlX4jZtMSBTaM= X-Google-Smtp-Source: AGs4zMbachQ5DScqu6fIGTVu9K0pPOsiWkTCjx/gIUIy5aPfyaTZ14613bcbfulplw0z4Ac2LOeG1A== X-Received: by 10.98.200.221 with SMTP id i90mr14445573pfk.19.1512242824062; Sat, 02 Dec 2017 11:27:04 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.27.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:27:03 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 09/10] net: ethernet: korina: Handle return value of platform_get_irq_byname Date: Sun, 3 Dec 2017 00:56:21 +0530 Message-Id: <1512242782-7134-10-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq_byname() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/korina.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index ae195f8..e778504 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ethernet/korina.c @@ -1039,7 +1039,16 @@ static int korina_probe(struct platform_device *pdev) memcpy(dev->dev_addr, bif->mac, ETH_ALEN); lp->rx_irq = platform_get_irq_byname(pdev, "korina_rx"); + if (lp->rx_irq < 0) { + rc = lp->rx_irq; + goto probe_err_out; + } + lp->tx_irq = platform_get_irq_byname(pdev, "korina_tx"); + if (lp->tx_irq < 0) { + rc = lp->tx_irq; + goto probe_err_out; + } r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "korina_regs"); dev->base_addr = r->start;