From patchwork Wed Jul 26 15:36:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadi Sharshevsky X-Patchwork-Id: 793987 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xHfJp5B8sz9sN5 for ; Thu, 27 Jul 2017 01:33:30 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbdGZPd2 (ORCPT ); Wed, 26 Jul 2017 11:33:28 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:51574 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750898AbdGZPd1 (ORCPT ); Wed, 26 Jul 2017 11:33:27 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from arkadis@mellanox.com) with ESMTPS (AES256-SHA encrypted); 26 Jul 2017 18:33:22 +0300 Received: from dev-r-vrt-156.mtr.labs.mlnx (dev-r-vrt-156.mtr.labs.mlnx [10.212.156.1]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v6QFXMNW012202; Wed, 26 Jul 2017 18:33:22 +0300 From: Arkadi Sharshevsky To: netdev@vger.kernel.org Cc: davem@davemloft.net, stephen@networkplumber.org, nikolay@cumulusnetworks.com, vivien.didelot@savoirfairelinux.com, mlxsw@mellanox.com, Arkadi Sharshevsky Subject: [PATCH iproute2] bridge: Assume master at FDB modification Date: Wed, 26 Jul 2017 18:36:34 +0300 Message-Id: <1501083394-26180-1-git-send-email-arkadis@mellanox.com> X-Mailer: git-send-email 2.4.11 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org According to the man page the master flag should be the default, yet, the current code assumes otherwise. Signed-off-by: Arkadi Sharshevsky --- bridge/fdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/fdb.c b/bridge/fdb.c index e5cebf9..7c77157 100644 --- a/bridge/fdb.c +++ b/bridge/fdb.c @@ -496,9 +496,9 @@ static int fdb_modify(int cmd, int flags, int argc, char **argv) return -1; } - /* Assume self */ + /* Assume master */ if (!(req.ndm.ndm_flags&(NTF_SELF|NTF_MASTER))) - req.ndm.ndm_flags |= NTF_SELF; + req.ndm.ndm_flags |= NTF_MASTER; /* Assume permanent */ if (!(req.ndm.ndm_state&(NUD_PERMANENT|NUD_REACHABLE)))