From patchwork Thu Nov 16 04:27:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838412 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jljRhUvv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpJM5bt3z9s7g for ; Thu, 16 Nov 2017 15:32:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbdKPE3O (ORCPT ); Wed, 15 Nov 2017 23:29:14 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:57284 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757688AbdKPE25 (ORCPT ); Wed, 15 Nov 2017 23:28:57 -0500 Received: by mail-pf0-f195.google.com with SMTP id q4so10577911pfg.13; Wed, 15 Nov 2017 20:28:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=9VlEMkQnYW0EJtBWOPxVioj2m2eWpIhIJDCeNas65iM=; b=jljRhUvv9eGf5W31+WhGztQpYYxGcze3uf8i8RRwF58zPyb8LIWYQKQ3Uj3tOhtGpt JTWNGu/jBozWNzneVBllHGMGIikWkge3TiZWF5iSuIREYUqojEPQbYMN7BmokTu6uyOE 4EQSUMNHhNRAedFnrDR0gj0qjNtUZz9wk/Hetd1b7pMVcWaLO+ivPZjS1r32cKj1d5/l pyNDDtDHqaz2vzk8BgzjMWZk58756dqyERKOAiSKx8CUWhAaLkpf46wHzan3TAvj042K X0P6uUYMjKBOE1YXbyrODyULMFb26XdHG8YNU8t2ZogF0TAFpspE8RgzhoihNxclRXS0 PQoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=9VlEMkQnYW0EJtBWOPxVioj2m2eWpIhIJDCeNas65iM=; b=jAvtLEBjDmgKWf9VcjHBM2UhKwtLlCalvQU0H3ky3OO9mXATtzOQTdCaiSVbo8FxL9 6OtxkxgK5OCVgyGeP2/FvANRFrah/QljkEdeCAndWUzGtmzCjD/d01GrsYKthiMnAlun dX42ufLHe40tzmajkrSwizQGNZ3T+g2BqVwkmcQtizVq9MK1j2obyJwcXV7zr72wrIZo 8yjmuEmwwSj2bl3kTCI1fCGvyN0klVHtIwDkW0t9xwYMxizQtxZR10EP7xR5G1BkyzP/ QI+RIrAyDfsdbUe9bxBlclKMyRpjcjZXrfRyxN/nlJwj4GjGyRaN8knHUtJ11/WinipF GmJg== X-Gm-Message-State: AJaThX6tS8tuD+Ed5Sdnhu2K324pa2YWuTGsQue29r3zYf83lgqogQva VAwz+sjGrML/SyGqYFe1N60= X-Google-Smtp-Source: AGs4zMbEW74V5L7lbvoTJEbPOTzcXj7Ydy3or/uCd9QJEgLx9hZ48RcdQJXZCLOEO7hvNgfnfN76TA== X-Received: by 10.84.132.42 with SMTP id 39mr405396ple.382.1510806537088; Wed, 15 Nov 2017 20:28:57 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:28:56 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 02/12] isdn: hisax: Fix pnp_irq's error checking for avm_pnp_setup Date: Thu, 16 Nov 2017 09:57:19 +0530 Message-Id: <14ab3ba543bf96791f5284e1ed16f48a2f460842.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/avm_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/avm_pci.c b/drivers/isdn/hisax/avm_pci.c index daf3742..a18b605 100644 --- a/drivers/isdn/hisax/avm_pci.c +++ b/drivers/isdn/hisax/avm_pci.c @@ -805,7 +805,7 @@ static int avm_pnp_setup(struct IsdnCardState *cs) cs->hw.avm.cfg_reg = pnp_port_start(pnp_avm_d, 0); cs->irq = pnp_irq(pnp_avm_d, 0); - if (!cs->irq) { + if (cs->irq == -1) { printk(KERN_ERR "FritzPnP:No IRQ\n"); return (0); }