From patchwork Wed Apr 12 00:02:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Ahern X-Patchwork-Id: 749686 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w2kf65rlYz9sNv for ; Wed, 12 Apr 2017 10:03:26 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="Dymg4PaJ"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831AbdDLADZ (ORCPT ); Tue, 11 Apr 2017 20:03:25 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34413 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbdDLACx (ORCPT ); Tue, 11 Apr 2017 20:02:53 -0400 Received: by mail-pf0-f179.google.com with SMTP id c198so5460358pfc.1 for ; Tue, 11 Apr 2017 17:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4gksXTcpJBZkewT/VU+bPQVbvkipZS9AK4rEkSsnnzs=; b=Dymg4PaJJAZ47W+lN7WxsskTpEdUNSBoNq3UQfMUIxc+fo53WXgxTGcbK+cXuGGqax mhGE5Uij32LsG/XzHzGCV+FDOyvaCJ7sWdJnm4Wmb7vl+RuxNaRwBZv5OU9X2Jiv9hAK 0tLwC8khx5FQVmrUyq1v2LPZ0/nEbaK2qTnCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4gksXTcpJBZkewT/VU+bPQVbvkipZS9AK4rEkSsnnzs=; b=a3uPBTkzzn/kDIXjDbkNcw5iBCBj3QoF+8SDtNVzkSOc+CTfOZ8Urhz6OhcuNWaWha vdn9k6aUkTLzMkGvuj2YbepvVIvrvs+Ah97cqqFemZD+6+ewTpDyTWWy5l1R0uOTtV7x JdH8BMp7K7eUd1kY0crn8+hcCrgTPlEoekryo0sLce2RGtkC7uvV9XtjMG9dA25dfpTB nDQ8LxyoXFjMQmjMcTI7UQ41nxTCrgk/lPFAgGDiH1mFRbm+EigSaiMzxPj6YItMeCck XYOxWpf5POKWvBrR05A6JMYGkwBAyt2GJMO3co7lsIMrGb7CoIMK0JiTVwasSf7eKvgf F5sw== X-Gm-Message-State: AFeK/H2xCE+rzLDQAhOcPkjagLEpSt2Oa3m9b9oPeMSxezonfVRtpWI8vnG+WaHq3OREvmXC X-Received: by 10.98.192.25 with SMTP id x25mr64961175pff.158.1491955372821; Tue, 11 Apr 2017 17:02:52 -0700 (PDT) Received: from kenny.it.cumulusnetworks.com. ([216.129.126.126]) by smtp.googlemail.com with ESMTPSA id w16sm32674168pgc.44.2017.04.11.17.02.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 11 Apr 2017 17:02:52 -0700 (PDT) From: David Ahern To: netdev@vger.kernel.org Cc: David Ahern Subject: [PATCH net-next v2 1/8] rtnetlink: Do not generate notifications for MTU events Date: Tue, 11 Apr 2017 17:02:40 -0700 Message-Id: <1491955367-12443-2-git-send-email-dsa@cumulusnetworks.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1491955367-12443-1-git-send-email-dsa@cumulusnetworks.com> References: <1491955367-12443-1-git-send-email-dsa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Changing MTU on a link currently causes 3 messages to be sent to userspace: [LINK]11: dummy1: mtu 1490 qdisc noqueue state UNKNOWN group default link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff Remove the messages sent for PRE_CHANGE_MTU and CHANGE_MTU netdev events. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 58419da7961b..79ab43796b08 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4117,7 +4117,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi switch (event) { case NETDEV_REBOOT: - case NETDEV_CHANGEMTU: case NETDEV_CHANGEADDR: case NETDEV_CHANGENAME: case NETDEV_FEAT_CHANGE: @@ -4126,7 +4125,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi case NETDEV_NOTIFY_PEERS: case NETDEV_CHANGEUPPER: case NETDEV_RESEND_IGMP: - case NETDEV_PRECHANGEMTU: case NETDEV_CHANGEINFODATA: case NETDEV_PRECHANGEUPPER: case NETDEV_CHANGELOWERSTATE: