From patchwork Fri Apr 7 21:25:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Ahern X-Patchwork-Id: 748473 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w0CLp0pHJz9s7t for ; Sat, 8 Apr 2017 07:26:26 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="D11IhXcc"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934178AbdDGV0X (ORCPT ); Fri, 7 Apr 2017 17:26:23 -0400 Received: from mail-pg0-f42.google.com ([74.125.83.42]:35257 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933491AbdDGV0E (ORCPT ); Fri, 7 Apr 2017 17:26:04 -0400 Received: by mail-pg0-f42.google.com with SMTP id 81so77184755pgh.2 for ; Fri, 07 Apr 2017 14:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/zlQozviOA7dX2AT6ZdlqnNKBn4n44mX+BfQphhhTRw=; b=D11IhXcc+C+SDDynOj4pHq05UBGidL+CxVgtQt/p8rSHCvP0Bwul/SKz6hiZvSF5ur EzWnviobLGOSYFKPT3Tqdez9Ek3AsALM+AtIp1lJ3IZEd8NL0zLS4LolARYMvPfEHhgS wNI9dt703B06fpLYidh1e211aUx+m1bT3OC1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/zlQozviOA7dX2AT6ZdlqnNKBn4n44mX+BfQphhhTRw=; b=tUk+COLAQNMk0qpZrmASr9TFguZxnFCYr3MzVklXat2esE0vRCbKIhYcScyxZwOH8N mhFFDmlOzkqt44Tf96pQFTsea4afCfotvi4AgflR2pw0fHra0VUWkdMKU/qiVCkIAhMU x5suVupuGILFtUSWuqSgNFTK+DW/TspUazOr53rxHdjDL+jqGv4RhFINg45KWGU9OoXs I4zDBZAyt+YphbMQsYV6HxpOwfBsxZuFMppOcF9n0koJsO6Tcxfi9nhaOtGkbUMS7oZ1 QNBzDPULj88Uo9zRvaWQdLktpLlCnCactn6ioNFDIsLaGi9VRhgSch6Asyi2un8x+hNg 8p4w== X-Gm-Message-State: AFeK/H0/rbEBKHk9IyU6VQ0kR4daZ3RKiQrCUJ8L+ydmNy6UbaSlcFn0oRj5t+2Vb5r8FhJb X-Received: by 10.84.132.97 with SMTP id 88mr53048796ple.61.1491600348599; Fri, 07 Apr 2017 14:25:48 -0700 (PDT) Received: from kenny.it.cumulusnetworks.com. ([216.129.126.126]) by smtp.googlemail.com with ESMTPSA id t15sm11274422pfl.25.2017.04.07.14.25.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Apr 2017 14:25:48 -0700 (PDT) From: David Ahern To: netdev@vger.kernel.org Cc: vyasevic@redhat.com, davem@davemloft.net, David Ahern Subject: [PATCH net-next 4/8] rtnetlink: Do not generate notifications for POST_TYPE_CHANGE event Date: Fri, 7 Apr 2017 14:25:36 -0700 Message-Id: <1491600340-8359-5-git-send-email-dsa@cumulusnetworks.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1491600340-8359-1-git-send-email-dsa@cumulusnetworks.com> References: <1491600340-8359-1-git-send-email-dsa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Changing the master device for a link generates many messages; the one generated for POST_TYPE_CHANGE is redundant: [LINK]11: dummy1: mtu 1500 qdisc noqueue master br1 state UNKNOWN group default event POST_TYPE_CHANGE link/ether 02:02:02:02:02:03 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue master br1 state UNKNOWN group default link/ether 02:02:02:02:02:03 brd ff:ff:ff:ff:ff:ff Remove POST_TYPE_CHANGE from the list of notifiers that generate notifications. Signed-off-by: David Ahern --- include/uapi/linux/if_link.h | 1 - net/core/rtnetlink.c | 4 ---- 2 files changed, 5 deletions(-) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index df5ade1bc684..80f3574a4630 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -906,7 +906,6 @@ enum { IFLA_EVENT_CHANGE_NAME, IFLA_EVENT_FEAT_CHANGE, IFLA_EVENT_BONDING_FAILOVER, - IFLA_EVENT_POST_TYPE_CHANGE, IFLA_EVENT_NOTIFY_PEERS, IFLA_EVENT_CHANGE_UPPER, IFLA_EVENT_RESEND_IGMP, diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 1503138ebfe1..739b06ac3e7f 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1294,9 +1294,6 @@ static int rtnl_fill_link_event(struct sk_buff *skb, unsigned long event) case NETDEV_BONDING_FAILOVER: rtnl_event = IFLA_EVENT_BONDING_FAILOVER; break; - case NETDEV_POST_TYPE_CHANGE: - rtnl_event = IFLA_EVENT_POST_TYPE_CHANGE; - break; case NETDEV_NOTIFY_PEERS: rtnl_event = IFLA_EVENT_NOTIFY_PEERS; break; @@ -4182,7 +4179,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi case NETDEV_CHANGENAME: case NETDEV_FEAT_CHANGE: case NETDEV_BONDING_FAILOVER: - case NETDEV_POST_TYPE_CHANGE: case NETDEV_NOTIFY_PEERS: case NETDEV_CHANGEUPPER: case NETDEV_RESEND_IGMP: