From patchwork Fri Apr 7 21:25:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Ahern X-Patchwork-Id: 748467 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w0CLQ52V8z9s84 for ; Sat, 8 Apr 2017 07:26:06 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="RjlbYuuA"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933969AbdDGVZ4 (ORCPT ); Fri, 7 Apr 2017 17:25:56 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:34584 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754935AbdDGVZs (ORCPT ); Fri, 7 Apr 2017 17:25:48 -0400 Received: by mail-pg0-f41.google.com with SMTP id 21so77251825pgg.1 for ; Fri, 07 Apr 2017 14:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=d09/Wq80JRAPVNQxfFWjrvwrIGHgMGXvwGmsw9DCMZ4=; b=RjlbYuuACx+Iq7Ktps9VMOkKbZaRqfsBaSngOzFodZqCi6Z1eHmKEarRj/2mDDlIRW TwePV79bV2g6eLVbLniftohQTmQqSL/VpMEGowKfCbonZ8XKuM9zmwbkAu9d2B3TdMse YkOoaHymHupMZmRo0divELPBwZntrXLyyJoPA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=d09/Wq80JRAPVNQxfFWjrvwrIGHgMGXvwGmsw9DCMZ4=; b=HT7GVbgTtaWLTaeffGLKt4r2JVqRNaLmKHd6oo97tbZJISJAk0yopigimoJCtkk3db CJPNWNQB+PgJG7nd9ByNfnIypvU8vCWgnZ6Bu4qZTpVelR0WH/ooIhL61BtbyTsFo7RS uwTrfYt+W8qaTgarzUR4OCmeF+2zcvwrjmq/B3sstSygiOXOsg99GF4Tg4nsVxSOBkg6 QLCmMbClkbg19yXwMeChHmtgy3UsZPUfZeKr2lKLESmYi6Q4aLsoYveSlvg1HHTrZ0E6 FPWqfQa5laank/Nh4EpwW07qS/q4jstmbJfSxFTurlv1812pSm0sgE9XU7VPw5bHH7be lhFQ== X-Gm-Message-State: AFeK/H2t6ll3bGAfBf/HTtntt2EVuMgN8K66k5s+isWsWpadvr/znqVYLrGx6ZIOlix/oAoN X-Received: by 10.84.231.201 with SMTP id g9mr53120934pln.1.1491600347793; Fri, 07 Apr 2017 14:25:47 -0700 (PDT) Received: from kenny.it.cumulusnetworks.com. ([216.129.126.126]) by smtp.googlemail.com with ESMTPSA id t15sm11274422pfl.25.2017.04.07.14.25.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Apr 2017 14:25:47 -0700 (PDT) From: David Ahern To: netdev@vger.kernel.org Cc: vyasevic@redhat.com, davem@davemloft.net, David Ahern Subject: [PATCH net-next 3/8] rtnetlink: Do not generate notifications for CHANGEADDR event Date: Fri, 7 Apr 2017 14:25:35 -0700 Message-Id: <1491600340-8359-4-git-send-email-dsa@cumulusnetworks.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1491600340-8359-1-git-send-email-dsa@cumulusnetworks.com> References: <1491600340-8359-1-git-send-email-dsa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Changing hardware address generates redundant messages: [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default event CHANGE_ADDR link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff Do not send a notification for the CHANGEADDR notifier. Signed-off-by: David Ahern --- include/uapi/linux/if_link.h | 1 - net/core/rtnetlink.c | 4 ---- 2 files changed, 5 deletions(-) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index 064218a840b7..df5ade1bc684 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -903,7 +903,6 @@ enum { enum { IFLA_EVENT_UNSPEC, IFLA_EVENT_REBOOT, - IFLA_EVENT_CHANGE_ADDR, IFLA_EVENT_CHANGE_NAME, IFLA_EVENT_FEAT_CHANGE, IFLA_EVENT_BONDING_FAILOVER, diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 1a46be074fd6..1503138ebfe1 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1285,9 +1285,6 @@ static int rtnl_fill_link_event(struct sk_buff *skb, unsigned long event) case NETDEV_REBOOT: rtnl_event = IFLA_EVENT_REBOOT; break; - case NETDEV_CHANGEADDR: - rtnl_event = IFLA_EVENT_CHANGE_ADDR; - break; case NETDEV_CHANGENAME: rtnl_event = IFLA_EVENT_CHANGE_NAME; break; @@ -4182,7 +4179,6 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi switch (event) { case NETDEV_REBOOT: - case NETDEV_CHANGEADDR: case NETDEV_CHANGENAME: case NETDEV_FEAT_CHANGE: case NETDEV_BONDING_FAILOVER: