From patchwork Mon Mar 27 13:37:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 743828 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vsFcc54RNz9s76 for ; Tue, 28 Mar 2017 00:44:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbdC0Nln (ORCPT ); Mon, 27 Mar 2017 09:41:43 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:53243 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292AbdC0Nkg (ORCPT ); Mon, 27 Mar 2017 09:40:36 -0400 Received: from duckbill-v2-sdk.fritz.box ([109.104.53.45]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MLFtx-1csDir0qTh-000MjL; Mon, 27 Mar 2017 15:37:36 +0200 From: Stefan Wahren To: Rob Herring , Mark Rutland , "David S. Miller" Cc: Greg Kroah-Hartman , Jiri Slaby , Marcel Holtmann , Sebastian Reichel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH RFC v4 02/10] net: qca_debug: use net_device_ops instead of direct call Date: Mon, 27 Mar 2017 15:37:20 +0200 Message-Id: <1490621848-24828-3-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1490621848-24828-1-git-send-email-stefan.wahren@i2se.com> References: <1490621848-24828-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K0:cdBKeMxgUrao7TVNLnBE2lllY17OL0xil9M0iWO+dIx64T0ut5K s1KY30Q0d2M8gN6yXdpX68/spOsTsmLDRVMPmXP7MyDsW6ABySKpGB0mN1wVJ2m+nn4yoxQ bZQKxLbZPgCuiWPf8IH0rye4tRw+l+kQn3oqc73HdSONXCXJ+E9K5k0a6k7xwjZ/6As1grb vxh5IzMJrrg+eAuBxDJMg== X-UI-Out-Filterresults: notjunk:1; V01:K0:W3K/3FnHEYc=:NuJhOhd6gynmN7MVNmf+GE IuWyVotMKBWocH4ldTjYQVdkLl4vHX79YDLtrkOmiKqYoBRKx+sub+mdN/8lKIy8uKhHIlSmC T/l9d/SH2Apal41pPEe0smh5jugPo9MXhDszJn5fTjstTiPUb6lZtpCT5CFnguCfsKU5f7Fu6 /QIynLemj80P7fwmvTBRLFqQsO2v9LaoD5lX7rtfdjvZ8fH8grBGXqBItF8VrKjYR7MAhhJT3 edB2Bz4wSxUPs/TE0sfkcqbLms4VtRRx0QcljpzwiStvqDbZTeDAyNY4NjWuPGjBQOqDrxww7 3omMSqv7J7v7vKC4K98aIX/xb5RZ5o5+tW3EB41bpsFFHcreQ7/NOtxPqnahZtfAjOC3IZ8/D +jcyXg0dfqIgn2MGpC/te3qaJcthg8ujMCinbXkz5yplnMGRUVIHKlt6QuWrOKLpJxjKNBFq/ UyeEr3OTuKe0awfzozAA36PxdRcTMbVnqOA9owxFM4vtvxMfnBhvRbi/juQcLcvIDEDUoedue 9Qq9dwbRq9xq39YzHBZ2NR74zb+Z+vytaNxlBIIkZ3hGzqaSwdKLPmBDY8XhAMgJb7YwIj51q u3t3U+FGwVl4AFPfsCrEPRcITxrYku1tOVkAmfzzc8FXXt/+6z7dMmom9l66tE7JkAn4wW9RF s2w4mFwoW0sZScZebwojTfyOIF+CHmOzeWU2hCEqiHLYsYC0szQTpYIR52ruouzC8AQ8= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index d145df9..92b6be9 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -275,6 +275,7 @@ qcaspi_get_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) static int qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) { + const struct net_device_ops *ops = dev->netdev_ops; struct qcaspi *qca = netdev_priv(dev); if ((ring->rx_pending) || @@ -283,13 +284,13 @@ qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring) return -EINVAL; if (netif_running(dev)) - qcaspi_netdev_close(dev); + ops->ndo_stop(dev); qca->txr.count = max_t(u32, ring->tx_pending, TX_RING_MIN_LEN); qca->txr.count = min_t(u16, qca->txr.count, TX_RING_MAX_LEN); if (netif_running(dev)) - qcaspi_netdev_open(dev); + ops->ndo_open(dev); return 0; } diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index 6e31a0e..064853d 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -108,7 +108,4 @@ struct qcaspi { u16 burst_len; }; -int qcaspi_netdev_open(struct net_device *dev); -int qcaspi_netdev_close(struct net_device *dev); - #endif /* _QCA_SPI_H */