From patchwork Fri Mar 10 17:46:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Ahern X-Patchwork-Id: 737500 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vfvns64Pvz9s7v for ; Sat, 11 Mar 2017 04:46:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="fe2GcOZs"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755361AbdCJRqZ (ORCPT ); Fri, 10 Mar 2017 12:46:25 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35786 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbdCJRqW (ORCPT ); Fri, 10 Mar 2017 12:46:22 -0500 Received: by mail-pf0-f170.google.com with SMTP id j5so44356289pfb.2 for ; Fri, 10 Mar 2017 09:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id; bh=DgGssLxEg/6bQ7LMSS4QRg2juRyfHkCQRT+hZKGTCWo=; b=fe2GcOZsKFa1NLUGHzZZl0c8EsJbXFf7xeKhyK73xTO5zD4GzJmXNrqR277/4nqWPH zFmzrjyz8bavNVNjjHfhqPg8NNEPg9XlC3cSmhtbiNDU4ofR+hxPLc6mhcdEDcWvjxZR 3x8bQ7C5NY7eXY/s/6ovdoUSA60yClC5ZXX0E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DgGssLxEg/6bQ7LMSS4QRg2juRyfHkCQRT+hZKGTCWo=; b=NEksMcqqXaViD5wIQHE6u951f9v+7+469zEEBUzdzfOB0X/j7kNbLI13yQZbAFvG6f 0g+j81AjceeaTQ+TfJTLJeA+Z6RvGgudpE+NrvfKBALbTcC64iZk9z/9lwQNf3e3ebmO s3KId2ZM0it30oGWmWqde66CRGfvNlA7wYsFCM2z11efEkTs5yNOPqIaYQmCGNs6r0WI pKXvfxm5q2ErgheeGlOrbjTLo/Wh3YOiWfbq5gb76xCXUlSnpmWos9vfJV/NUcz+1YRS EL8t068PlQXxkEbXYgVEgWXTPGz5TyNHszU+DD4zP5d0KZmjwql80bh0SK8uQPPQ1dNA /iPw== X-Gm-Message-State: AMke39n0RgxYrOyovFkrCBKX8ztnYbxYCP/enfLjuFf7pb1nOS27WUHZ8PXkxQA/hwhi2NNd X-Received: by 10.84.202.163 with SMTP id x32mr26898315pld.67.1489167980681; Fri, 10 Mar 2017 09:46:20 -0800 (PST) Received: from kenny.it.cumulusnetworks.com. ([216.129.126.126]) by smtp.googlemail.com with ESMTPSA id 75sm19843063pfp.80.2017.03.10.09.46.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Mar 2017 09:46:20 -0800 (PST) From: David Ahern To: netdev@vger.kernel.org Cc: ebiederm@xmission.com, roopa@cumulusnetworks.com, rshearma@brocade.com, David Ahern Subject: [PATCH] mpls: Send route delete notifications when router module is unloaded Date: Fri, 10 Mar 2017 09:46:15 -0800 Message-Id: <1489167975-11729-1-git-send-email-dsa@cumulusnetworks.com> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When the mpls_router module is unloaded, mpls routes are deleted but notifications are not sent to userspace leaving userspace caches out of sync. Add the call to mpls_notify_route in mpls_net_exit as routes are freed. Fixes: 0189197f44160 ("mpls: Basic routing support") Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index 3818686182b2..a1477989ed0b 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c @@ -2028,6 +2028,7 @@ static void mpls_net_exit(struct net *net) for (index = 0; index < platform_labels; index++) { struct mpls_route *rt = rtnl_dereference(platform_label[index]); RCU_INIT_POINTER(platform_label[index], NULL); + mpls_notify_route(net, index, rt, NULL, NULL); mpls_rt_free(rt); } rtnl_unlock();