From patchwork Tue Jan 31 09:33:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yotam Gigi X-Patchwork-Id: 721877 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vCLdH0dX4z9ryZ for ; Tue, 31 Jan 2017 20:32:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751343AbdAaJcQ (ORCPT ); Tue, 31 Jan 2017 04:32:16 -0500 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:46502 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751218AbdAaJcH (ORCPT ); Tue, 31 Jan 2017 04:32:07 -0500 Received: from Internal Mail-Server by MTLPINE1 (envelope-from yotamg@mellanox.com) with ESMTPS (AES256-SHA encrypted); 31 Jan 2017 11:31:29 +0200 Received: from dev-r-vrt-156.mtr.labs.mlnx (dev-r-vrt-156.mtr.labs.mlnx [10.212.156.1]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v0V9VSuf028212; Tue, 31 Jan 2017 11:31:29 +0200 From: Yotam Gigi To: davem@davemloft.net, jhs@mojatatu.com, netdev@vger.kernel.org, jiri@mellanox.com, eladr@mellanox.com Cc: Yotam Gigi Subject: [PATCH net-next 2/2] net/sched: act_psample: Remove unnecessary ASSERT_RTNL Date: Tue, 31 Jan 2017 11:33:54 +0200 Message-Id: <1485855234-9941-3-git-send-email-yotamg@mellanox.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1485855234-9941-1-git-send-email-yotamg@mellanox.com> References: <1485855234-9941-1-git-send-email-yotamg@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The ASSERT_RTNL is not necessary in the init function, as it does not touch any rtnl protected structures, as opposed to the mirred action which does have to hold a net device. Reported-by: Cong Wang Reviewed-by: Jiri Pirko Signed-off-by: Yotam Gigi --- net/sched/act_sample.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c index 02b6749..0b8217b 100644 --- a/net/sched/act_sample.c +++ b/net/sched/act_sample.c @@ -76,7 +76,6 @@ static int tcf_sample_init(struct net *net, struct nlattr *nla, } s = to_sample(*a); - ASSERT_RTNL(); s->tcf_action = parm->action; s->rate = nla_get_u32(tb[TCA_SAMPLE_RATE]); s->psample_group_num = nla_get_u32(tb[TCA_SAMPLE_PSAMPLE_GROUP]);