From patchwork Mon Dec 19 15:05:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 707116 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tj4482VhDz9vFY for ; Tue, 20 Dec 2016 02:06:00 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Uxa4/kDd"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932383AbcLSPFv (ORCPT ); Mon, 19 Dec 2016 10:05:51 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37324 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762389AbcLSPFt (ORCPT ); Mon, 19 Dec 2016 10:05:49 -0500 Received: by mail-wm0-f46.google.com with SMTP id t79so103465011wmt.0 for ; Mon, 19 Dec 2016 07:05:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5RVemztCZgQz53lX4FCvlPmOeEDNqlOv4Aprd4sqIAo=; b=Uxa4/kDd8IaFivcNH9Otz9hM7UnjRL4riNfIBfxfuuMJT+/KE4lb3e2TGBE7eG7XsU UbvDAYZI7egzDoA8w8GV1OJ6xE5at0ey2coIO90Lw26S6aNvEREYvxiCaevQRpk+pLp9 ASM3FSV9eTLNd0Do/MSK6RD+aXKfBl6tk5QRKnl0cDd9VALT7VtrMeCiSyWcMA77j5Fa 8TBydL3m66BbfCYSLbotHkC/UtHvOveBv3CkM/PM+En+YKz5sD6WQaP7X03xXFKVdqEi IKApnxa44UzZUUs32Wt0sf5GnRqUtU2oYWI55aJK4H22YnuvDNSDJMZu9RbFF1iJA/fw 1U+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5RVemztCZgQz53lX4FCvlPmOeEDNqlOv4Aprd4sqIAo=; b=ueLKIfe7M7Ier9sRCoC8tg9TcDHIhm4pPsPY9122WPidtPF3sHgSsOhKiPFZco9PGJ x3JhFpQ9blmEZQs3FxgI2XZD97lQ/9DlAM9NKz/gosrDikL6U5sBSOJhTXcX1wohjqAB cuHUUgZwzX42Sm/HBZw39um0oOeoX7Gs+1XjB68xPQrNzWplOUYQ37cu5NszMtgisq9S VvAPbHkGNG+evruk6ZILPl3kic+oRZuWJ84iYj6geXkbnZxptRK9QIlH0C+dqE2W+Eiz KYPKIucZw7r/VNp7yGfjCBBcEM6z5th3llvUgo/H6rmyG6TI0vMzlFdIUyjG3gEUeDNc O2Hw== X-Gm-Message-State: AIkVDXKXvMo8V+4m5mFll7l/pGlX1yXno7HfWW8Ak17/F3Sg8rNBeDUroPInNALJvoZnMpQD X-Received: by 10.28.12.84 with SMTP id 81mr14320450wmm.51.1482159948117; Mon, 19 Dec 2016 07:05:48 -0800 (PST) Received: from boomer.localdomain ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id v2sm21046655wja.41.2016.12.19.07.05.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Dec 2016 07:05:47 -0800 (PST) From: Jerome Brunet To: netdev@vger.kernel.org, devicetree@vger.kernel.org, Florian Fainelli Cc: Jerome Brunet , Carlo Caione , Kevin Hilman , Martin Blumenstingl , Andre Roth , Andrew Lunn , Neil Armstrong , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Julia Lawall , Yegor Yefremov , =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [PATCH net 1/3] net: phy: fix sign type error in genphy_config_eee_advert Date: Mon, 19 Dec 2016 16:05:36 +0100 Message-Id: <1482159938-13239-2-git-send-email-jbrunet@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482159938-13239-1-git-send-email-jbrunet@baylibre.com> References: <1482159938-13239-1-git-send-email-jbrunet@baylibre.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In genphy_config_eee_advert, the return value of phy_read_mmd_indirect is checked to know if the register could be accessed but the result is assigned to a 'u32'. Changing to 'int' to correctly get errors from phy_read_mmd_indirect. Fixes: d853d145ea3e ("net: phy: add an option to disable EEE advertisement") Reported-by: Julia Lawall Signed-off-by: Jerome Brunet --- drivers/net/phy/phy_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 9c06f8028f0c..ee5ebadb1463 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1187,8 +1187,8 @@ static int genphy_config_advert(struct phy_device *phydev) */ static int genphy_config_eee_advert(struct phy_device *phydev) { - u32 broken = phydev->eee_broken_modes; - u32 old_adv, adv; + int broken = phydev->eee_broken_modes; + int old_adv, adv; /* Nothing to disable */ if (!broken)