From patchwork Wed Nov 30 22:02:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 701250 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tTZDj5x04z9t3N for ; Thu, 1 Dec 2016 09:03:33 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="L5wOJDbB"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759326AbcK3WDL (ORCPT ); Wed, 30 Nov 2016 17:03:11 -0500 Received: from mail-wj0-f173.google.com ([209.85.210.173]:35030 "EHLO mail-wj0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbcK3WDJ (ORCPT ); Wed, 30 Nov 2016 17:03:09 -0500 Received: by mail-wj0-f173.google.com with SMTP id v7so188087854wjy.2 for ; Wed, 30 Nov 2016 14:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=s3x09TZwrz/Oap34f8sC8WialSev9bpK0CHCYrI6u1U=; b=L5wOJDbBgrI30kGTbT5sOWWHL2d1meov4/FmfWe5kZgxFl+3Ii1MFJdngnYSvqdssS HutBle6CglDgLJ8jkaEVEqkRKIYCAazw9iPxgSpdSmbFpjjOnY8KVpA6tt23RUsZeiAN Pq0pGusZvV69ZGE33DFXNsceXCXNhUTHoKYQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=s3x09TZwrz/Oap34f8sC8WialSev9bpK0CHCYrI6u1U=; b=CRb4RIqkvEfFM5/1NSNjUNxhMCYKDB0kZlvKOk+HBuDoLdWrhwbtkH01Vg5ca9nxPK NcDZkrlIjuyoa+LJnXCdQeEssXA1mbyd0T5e3FM1pZr+Ai4qoInSrAdK6y5BSGp3o+Pz ILQCM/9kj99hSnlgGDX0KUGq/baJsrPHDN+w8FeFCHAqBnjFeiUuWuVhn6jQCxuIcZph riddmdoZlzzYh0cZtg292EgPaUW3zByiFos7nWICSDLrbP1N4DTfOgSIuO6sB9LIeFMK 8omFeiur4s6FUqrFeEMwq0Vu7pKHM7EZ8aW1yY4TMFLyviReJaRMsH6EiQmZhUzKyP94 Fcsw== X-Gm-Message-State: AKaTC02MMWMx/QP+fmgI7e3Wify2tK420La4njIaxXIxir+U1OR+4LG2truiUlNejtb8/g== X-Received: by 10.194.0.167 with SMTP id 7mr29016108wjf.80.1480543387769; Wed, 30 Nov 2016 14:03:07 -0800 (PST) Received: from lvps87-230-87-209.dedicated.hosteurope.de (wildmoose.dk. [87.230.87.209]) by smtp.gmail.com with ESMTPSA id g10sm74848501wjw.18.2016.11.30.14.03.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Nov 2016 14:03:07 -0800 (PST) From: Rasmus Villemoes To: Felipe Balbi Cc: Rasmus Villemoes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: atarilance: use %8ph for printing hex string Date: Wed, 30 Nov 2016 23:02:54 +0100 Message-Id: <1480543375-28904-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is already using the %pM printf extension; might as well also use %ph to make the code smaller. Signed-off-by: Rasmus Villemoes --- drivers/net/ethernet/amd/atarilance.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/amd/atarilance.c b/drivers/net/ethernet/amd/atarilance.c index d2bc8e5dcd23..d208a0532811 100644 --- a/drivers/net/ethernet/amd/atarilance.c +++ b/drivers/net/ethernet/amd/atarilance.c @@ -1013,13 +1013,9 @@ static int lance_rx( struct net_device *dev ) u_char *data = PKTBUF_ADDR(head); printk(KERN_DEBUG "%s: RX pkt type 0x%04x from %pM to %pM " - "data %02x %02x %02x %02x %02x %02x %02x %02x " - "len %d\n", + "data %8ph len %d\n", dev->name, ((u_short *)data)[6], - &data[6], data, - data[15], data[16], data[17], data[18], - data[19], data[20], data[21], data[22], - pkt_len); + &data[6], data, &data[15], pkt_len); } skb_reserve( skb, 2 ); /* 16 byte align */