| Message ID | 1480285588-13501-1-git-send-email-afaerber@suse.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Nov 27, 2016 at 11:26:28PM +0100, Andreas Färber wrote: > mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, > so free the same amount. This will be 8 or 9 in practice, less than 16. > > Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") > Cc: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Andreas Färber <afaerber@suse.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Thanks Andrew
From: Andreas Färber <afaerber@suse.de> Date: Sun, 27 Nov 2016 23:26:28 +0100 > mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, > so free the same amount. This will be 8 or 9 in practice, less than 16. > > Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") > Cc: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Andreas Färber <afaerber@suse.de> Applied, thanks.
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index b14b3d5099c8..77f13ada2612 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -421,7 +421,7 @@ static void mv88e6xxx_g1_irq_free(struct mv88e6xxx_chip *chip) free_irq(chip->irq, chip); - for (irq = 0; irq < 16; irq++) { + for (irq = 0; irq < chip->g1_irq.nirqs; irq++) { virq = irq_find_mapping(chip->g1_irq.domain, irq); irq_dispose_mapping(virq); }
mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, so free the same amount. This will be 8 or 9 in practice, less than 16. Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.") Cc: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Andreas Färber <afaerber@suse.de> --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)