From patchwork Thu Nov 24 18:21:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 698971 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tPndR3S9Hz9t1H for ; Fri, 25 Nov 2016 05:23:23 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lzjpYDwi"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940995AbcKXSWy (ORCPT ); Thu, 24 Nov 2016 13:22:54 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34295 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935645AbcKXSWu (ORCPT ); Thu, 24 Nov 2016 13:22:50 -0500 Received: by mail-lf0-f65.google.com with SMTP id o141so2286929lff.1; Thu, 24 Nov 2016 10:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=NaR+JmVE4752b7HY4cJKHDYESfOJayrimnmKYl/n7BY=; b=lzjpYDwiwF9/Qrq3h1ccf2N5YGc1MulTkQtFynpLtD8iZX4tvjqq5LeFKd5q02zxNB JTxdj8ClFncBGWTQo7hnzvA96sgzOl4fqK/jAFjaqkBpAJpYo8s0MFVK6wbZPor9NYEu ygGRsnHL50EtYfHEhOQAZJ8vi3aRQ9/gc8serwc9wZZ/Uggyc/b3LWUU7aJsyxIZe4Dq 7qQNP3h9ZbU6W4VCjVU381Qp/LyWDgMHGvVqI2ce8bmgXVFIOFParbqfNApiRKq64122 txTEpD5bEmf4Yfy6gM+Qbom6Ufx0tgNq/u8gXC9n35n43/dKWyCwXy9X+3xSvw6Hycme yJgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=NaR+JmVE4752b7HY4cJKHDYESfOJayrimnmKYl/n7BY=; b=Zv9MfOotw9jNe/t3TMm12icbr1WNoMVc+983SHORQ52WTon3PPyv+zDSFITUqq8C+l FTA7vxcX62P1MoO9AZ8UKX0aMK4TI9kKMEsbHWc8hXc1sG3PYwE8+j+jCb7PHGdLEiCh ji+QXBaMVGUXmXSiWEGpLUzYV/2MzlMBSorcE3AakZAtVO1OgxEsJtt5a2sn+6fisoMu c1J2puqqEn4RjSXg/+6Tcy7bjg8iRyrKn+N0gEBAHySQeFr0Qzi8fi4vVFZbNBLZtzQY PjD+xm4VGIevDqvGtjzSW7yQ6ya6DM2XH74hzKyre4jzAsjA/qPINXx50oxcluuEXgtG pPhQ== X-Gm-Message-State: AKaTC01K+tbRtM/M3lBORLdIzFhWQP4X5s6WhQVUW3+7WYMm1dY8YtAH4kEZ/GiioIJarg== X-Received: by 10.46.76.26 with SMTP id z26mr2114861lja.9.1480011768448; Thu, 24 Nov 2016 10:22:48 -0800 (PST) Received: from xi.terra (c-04aadb54.07-184-6d6c6d4.cust.bredbandsbolaget.se. [84.219.170.4]) by smtp.gmail.com with ESMTPSA id d16sm8556232lfj.14.2016.11.24.10.22.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Nov 2016 10:22:47 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.87) (envelope-from ) id 1c9yfV-0003Ti-VU; Thu, 24 Nov 2016 19:22:45 +0100 From: Johan Hovold To: "David S. Miller" Cc: Florian Fainelli , Madalin Bucur , Timur Tabi , Andrew Lunn , Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH net v2 4/5] net: fsl/fman: fix fixed-link-phydev reference leak Date: Thu, 24 Nov 2016 19:21:30 +0100 Message-Id: <1480011691-13278-5-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1480011691-13278-1-git-send-email-johan@kernel.org> References: <1480011691-13278-1-git-send-email-johan@kernel.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Make sure to drop the reference taken by of_phy_find_device() when looking up a fixed-link phydev during probe. Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Johan Hovold --- drivers/net/ethernet/freescale/fman/mac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 8fe6b3e253fa..736db9d9b0ad 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -892,6 +892,8 @@ static int mac_probe(struct platform_device *_of_dev) priv->fixed_link->duplex = phy->duplex; priv->fixed_link->pause = phy->pause; priv->fixed_link->asym_pause = phy->asym_pause; + + put_device(&phy->mdio.dev); } err = mac_dev->init(mac_dev);